Enable Protection Validation and TBDs implementation Part 3

Author: pragrawa

src/ResourceManager/RecoveryServices.Backup/Cmdlets/Item/EnableAzureRmRecoveryServicesProtection.cs

@@ -20,9 +20,11 @@
 using System.Management.Automation;
 using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models;
 using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.ProviderModel;
+using Microsoft.Azure.Commands.RecoveryServices.Backup.Properties;
 using Microsoft.Azure.Commands.RecoveryServices.Backup.Helpers;
 using HydraModel = Microsoft.Azure.Management.RecoveryServices.Backup.Models;
 
+
 namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
 {
     /// <summary>
@@ -82,12 +84,7 @@ public override void ExecuteCmdlet()
                 // Track Response and display job details
                 // -- TBD to move it to common helper and remove hard-coded vaules
 
-                var response = HydraAdapter.GetProtectedItemOperationStatusByURL(jobResponse.AzureAsyncOperation);
-                while (response.OperationStatus.Status == HydraModel.OperationStatusValues.InProgress)
-                {
-                    response = HydraAdapter.GetProtectedItemOperationStatusByURL(jobResponse.AzureAsyncOperation);
-                    System.Threading.Thread.Sleep(TimeSpan.FromSeconds(5));
-                }
+                var response = OperationStatusHelper.TrackOperationStatus(jobResponse, HydraAdapter);
 
                 if (response.OperationStatus.Status == HydraModel.OperationStatusValues.Succeeded)
                 {
@@ -106,9 +103,9 @@ public override void ExecuteCmdlet()
                         WriteObject(JobConversions.GetPSJob(job));
                     }
 
-                    var errorMessage(string.Format("Operation failed with error code and error message",
-                    response.OperationStatus.OperationStatusError,
-                    response.OperationStatus.OperationStatusError));
+                    var errorMessage = string.Format(Resources.EnableProtectionOperationFailed,
+                    response.OperationStatus.OperationStatusError.Code,
+                    response.OperationStatus.OperationStatusError.Message);
 
                     throw new Exception(errorMessage);
                 }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/Commands.RecoveryServices.Backup.Helpers.csproj

@@ -51,6 +51,7 @@
   <ItemGroup>
     <Compile Include="Conversions\JobConversions.cs" />
     <Compile Include="Conversions\RecoveryPointConversions.cs" />
+    <Compile Include="OperationStatusHelper.cs" />
     <Compile Include="Utils.cs" />
     <Compile Include="Validations\PolicyValidations.cs" />
     <Compile Include="Conversions\SchedulePolicyConversions.cs" />
@@ -64,6 +65,10 @@
       <Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
       <Name>Commands.Common</Name>
     </ProjectReference>
+    <ProjectReference Include="Commands.RecoveryServices.Backup.HydraAdapter\Commands.RecoveryServices.Backup.HydraAdapter.csproj">
+      <Project>{b758fec1-35c1-4f93-a954-66dd33f6e0ec}</Project>
+      <Name>Commands.RecoveryServices.Backup.HydraAdapter</Name>
+    </ProjectReference>
     <ProjectReference Include="..\Commands.RecoveryServices.Backup.Logger\Commands.RecoveryServices.Backup.Logger.csproj">
       <Project>{5e675749-6139-464a-904c-59c0ffdfec82}</Project>
       <Name>Commands.RecoveryServices.Backup.Logger</Name>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/OperationStatusHelper.cs

@@ -0,0 +1,41 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System;
+using System.Collections.Specialized;
+using System.Web;
+using CmdletModel = Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models;
+using HydraModel = Microsoft.Azure.Management.RecoveryServices.Backup.Models;
+using Microsoft.Azure.Management.RecoveryServices.Backup.Models;
+using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.HydraAdapter;
+
+namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Helpers
+{
+    public class OperationStatusHelper
+    {
+        public const double defaultOperationStatusRetryTimeInSec = 5.0;
+
+        public static BackUpOperationStatusResponse TrackOperationStatus(BaseRecoveryServicesJobResponse jobResponse, HydraAdapter hydraAdapter)
+        {
+            var response = hydraAdapter.GetProtectedItemOperationStatusByURL(jobResponse.AzureAsyncOperation);
+            while (response.OperationStatus.Status == HydraModel.OperationStatusValues.InProgress)
+            {
+                response = hydraAdapter.GetProtectedItemOperationStatusByURL(jobResponse.AzureAsyncOperation);
+                System.Threading.Thread.Sleep(TimeSpan.FromSeconds(defaultOperationStatusRetryTimeInSec));
+            }
+
+            return response;
+        }
+    }
+}

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.Designer.cs

@@ -323,4 +323,7 @@ Please contact Microsoft for further assistant.</value>
   <data name="BothCloudServiceNameAndResourceGroupNameShouldNotEmpty" xml:space="preserve">
     <value>For Azure VM, both cloud service name and resource group name can not be empty</value>
   </data>
+  <data name="EnableProtectionOperationFailed" xml:space="preserve">
+    <value>Enable Protection OperationFailed with error code {0} , and error Message {1}</value>
+  </data>
 </root>