Move ModuleFilter from VersionController to Tools.Common (#12122)

* Move ModuleFilter from VersionController to Tools.Common。

* Fix the places that use ModuleFilter before.

* Fix "Stack" problem use ModuleFilter in StaticAnalyzer.

Author: chenlei-yang

tools/StaticAnalysis/BreakingChangeAnalyzer/BreakingChangeAnalyzer.cs

@@ -30,6 +30,7 @@
 using Tools.Common.Loaders;
 using Tools.Common.Loggers;
 using Tools.Common.Models;
+using Tools.Common.Utilities;
 
 namespace StaticAnalysis.BreakingChangeAnalyzer
 {
@@ -97,7 +98,7 @@ public void Analyze(
             }
 
             foreach (var baseDirectory in cmdletProbingDirs.Where(s => !s.Contains("ServiceManagement") &&
-                                                                        !s.Contains("Stack") && Directory.Exists(Path.GetFullPath(s))))
+                                                                        !ModuleFilter.IsAzureStackModule(s) && Directory.Exists(Path.GetFullPath(s))))
             {
                 var probingDirectories = new List<string> {baseDirectory};
 

tools/StaticAnalysis/BreakingChangeAttributesAnalyzer/BreakingChangeAttributesAnalyzer.cs

@@ -28,6 +28,7 @@
 using Tools.Common.Helpers;
 using Tools.Common.Issues;
 using Tools.Common.Loggers;
+using Tools.Common.Utilities;
 
 namespace StaticAnalysis.BreakingChangeAttributesAnalyzer
 {
@@ -104,7 +105,7 @@ public void Analyze(IEnumerable<string> cmdletProbingDirs, Func<IEnumerable<stri
             try
             {
                 foreach (var baseDirectory in cmdletProbingDirs.Where(s => !s.Contains("ServiceManagement") &&
-                                                                            !s.Contains("Stack") && Directory.Exists(Path.GetFullPath(s))))
+                                                                            !ModuleFilter.IsAzureStackModule(s) && Directory.Exists(Path.GetFullPath(s))))
                 {
                     var probingDirectories = new List<string> {baseDirectory};
 

tools/StaticAnalysis/SignatureVerifier/SignatureVerifier.cs

@@ -23,6 +23,7 @@
 using Tools.Common.Loaders;
 using Tools.Common.Loggers;
 using Tools.Common.Models;
+using Tools.Common.Utilities;
 
 namespace StaticAnalysis.SignatureVerifier
 {
@@ -74,7 +75,7 @@ public void Analyze(IEnumerable<string> cmdletProbingDirs,
             }
 
             foreach (var baseDirectory in cmdletProbingDirs.Where(s => !s.Contains("ServiceManagement") &&
-                                                                       !s.Contains("Stack") && Directory.Exists(Path.GetFullPath(s))))
+                                                                       !ModuleFilter.IsAzureStackModule(s) && Directory.Exists(Path.GetFullPath(s))))
             {
                 //Add current directory for probing
                 probingDirectories.Add(baseDirectory);

tools/Tools.Common/Tools.Common.Netcore.csproj

@@ -26,6 +26,7 @@
 
   <ItemGroup>
     <Content Include="SerializedCmdlets\*.json" CopyToOutputDirectory="PreserveNewest" />
+    <Content Include="WhiteList.csv" CopyToOutputDirectory="PreserveNewest" />
   </ItemGroup>
 
 </Project>

tools/VersionController/Utilities/ModuleFilter.cs renamed to tools/Tools.Common/Utilities/ModuleFilter.cs

@@ -3,9 +3,9 @@
 using System.Linq;
 using System.Reflection;
 
-namespace VersionController.Utilities
+namespace Tools.Common.Utilities
 {
-    class ModuleFilter
+    public class ModuleFilter
     {
         public static bool IsAzureStackModule(String fileName)
         {
@@ -22,7 +22,7 @@ public static bool IsAzureStackModule(String fileName)
                 var lines = File.ReadAllLines(whiteListFile).Skip(1).Where(c => !string.IsNullOrEmpty(c));
                 foreach (var line in lines)
                 {
-                    var cols = line.Split(",").Select(c => c.StartsWith("\"") ? c.Substring(1) : c)
+                    var cols = line.Split(',').Select(c => c.StartsWith("\"") ? c.Substring(1) : c)
                                               .Select(c => c.EndsWith("\"") ? c.Substring(0, c.Length - 1) : c)
                                               .Select(c => c.Trim()).ToArray();
                     if (cols.Length >= 1)

tools/VersionController/WhiteList.csv renamed to tools/Tools.Common/WhiteList.csv

@@ -7,7 +7,7 @@
 using System.Reflection;
 using System.Text.RegularExpressions;
 using Tools.Common.Models;
-using VersionController.Utilities;
+using Tools.Common.Utilities;
 
 namespace VersionController.Models
 {

tools/VersionController/Models/VersionBumper.cs

@@ -1,7 +1,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using VersionController.Utilities;
+using Tools.Common.Utilities;
 
 namespace VersionController.Models
 {

tools/VersionController/Models/VersionFileHelper.cs

@@ -7,7 +7,7 @@
 using System.Reflection;
 using Tools.Common.Models;
 using VersionController.Models;
-using VersionController.Utilities;
+using Tools.Common.Utilities;
 
 namespace VersionController
 {

tools/VersionController/Program.cs

@@ -48,7 +48,6 @@
 
   <ItemGroup>
     <Content Include="MinimalVersion.csv" CopyToOutputDirectory="PreserveNewest" />
-    <Content Include="WhiteList.csv" CopyToOutputDirectory="PreserveNewest" />
   </ItemGroup>
 
 </Project>