Skip to content

Commit 924c340

Browse files
cormacpaynecormacpayne
authored
Merge pull request #8073 from maddieclayton/keyvaultbc
KeyVault breaking changes
2 parents df53142 + 0a39827 commit 924c340

File tree

6 files changed

+21
-14
lines changed

6 files changed

+21
-14
lines changed

‎src/ResourceManager/KeyVault/Commands.KeyVault/ChangeLog.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@
1717
* Overview of change #1
1818
- Additional information about change #1
1919
-->
20-
## Current Release
20+
## Current Release
21+
* Remove deprecated PurgeDisabled property from PS models

‎src/ResourceManager/KeyVault/Commands.KeyVault/Microsoft.Azure.Commands.KeyVault.format.ps1xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
<PropertyName>Updated</PropertyName>
4848
</ListItem>
4949
<ListItem>
50-
<Label>Purge Disabled</Label>
51-
<PropertyName>PurgeDisabled</PropertyName>
50+
<Label>Recovery Level</Label>
51+
<PropertyName>RecoveryLevel</PropertyName>
5252
</ListItem>
5353
<ListItem>
5454
<Label>Tags</Label>
@@ -109,8 +109,8 @@
109109
<PropertyName>Updated</PropertyName>
110110
</ListItem>
111111
<ListItem>
112-
<Label>Purge Disabled</Label>
113-
<PropertyName>PurgeDisabled</PropertyName>
112+
<Label>Recovery Level</Label>
113+
<PropertyName>RecoveryLevel</PropertyName>
114114
</ListItem>
115115
<ListItem>
116116
<Label>Tags</Label>

‎src/ResourceManager/KeyVault/Commands.KeyVault/Models/PSKeyVaultKeyAttributes.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ internal PSKeyVaultKeyAttributes(bool? enabled, DateTime? expires, DateTime? not
6464

6565
public DateTime? Updated { get; private set; }
6666

67-
[Obsolete("The PurgeDisabled property is being deprecated and will be removed in a future release. Please use the RecoveryLevel property instead.")]
68-
public bool PurgeDisabled { get; private set; }
69-
7067
public string RecoveryLevel { get; private set; }
7168

7269
public Hashtable Tags { get; set; }

‎src/ResourceManager/KeyVault/Commands.KeyVault/Models/PSKeyVaultKeyIdentityItem.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ internal PSKeyVaultKeyIdentityItem(PSKeyVaultKey keyBundle)
7171

7272
public DateTime? Updated { get; protected set; }
7373

74-
[Obsolete( "The PurgeDisabled property is being deprecated and will be removed in a future release. Please use the RecoveryLevel property instead." )]
75-
public bool PurgeDisabled { get; protected set; }
76-
7774
public string RecoveryLevel { get; protected set; }
7875

7976
public Hashtable Tags { get; set; }

‎src/ResourceManager/KeyVault/Commands.KeyVault/Models/PSKeyVaultSecretAttributes.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ internal PSKeyVaultSecretAttributes(bool? enabled, DateTime? expires, DateTime?
6262

6363
public Hashtable Tags { get; set; }
6464

65-
[Obsolete( "The PurgeDisabled property is being deprecated and will be removed in a future release. Please use the RecoveryLevel property instead." )]
66-
public bool PurgeDisabled { get; private set; }
67-
6865
public string RecoveryLevel { get; private set; }
6966

7067
public string TagsTable

‎tools/StaticAnalysis/Exceptions/Az.KeyVault/BreakingChangeIssues.csv

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,16 @@
11
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
2+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.AddAzureKeyVaultKey","Add-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyAttributes' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyAttributes'."
3+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.AddAzureKeyVaultKey","Add-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey'."
4+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.BackupAzureKeyVaultKey","Backup-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem'."
5+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.GetAzureKeyVaultKey","Get-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem'."
6+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.GetAzureKeyVaultKey","Get-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey'."
7+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.GetAzureKeyVaultKey","Get-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKeyIdentityItem' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKeyIdentityItem'."
8+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.GetAzureKeyVaultKey","Get-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKey'."
9+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.GetAzureKeyVaultSecret","Get-AzKeyVaultSecret","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultSecretAttributes' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultSecretAttributes'."
10+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.RemoveAzureKeyVaultKey","Remove-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKey'."
11+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.RemoveAzureKeyVaultKey","Remove-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem'."
12+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.RestoreAzureKeyVaultKey","Restore-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey'."
13+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UndoAzureKeyVaultKeyRemoval","Undo-AzKeyVaultKeyRemoval","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey'."
14+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UndoAzureKeyVaultKeyRemoval","Undo-AzKeyVaultKeyRemoval","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKeyIdentityItem' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSDeletedKeyVaultKeyIdentityItem'."
15+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UpdateAzureKeyVaultKey","Update-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKey'."
16+
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UpdateAzureKeyVaultKey","Update-AzKeyVaultKey","0","3010","The property 'PurgeDisabled' of type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem' has been removed.","Add the property 'PurgeDisabled' back to type 'Microsoft.Azure.Commands.KeyVault.Models.PSKeyVaultKeyIdentityItem'."

0 commit comments

Comments
 (0)