-PerformancePlus for New-AzDiskConfig (#20937)

* add it to New-AzDiskConfig

* help doc and change log

* suppress false positive

---------

Co-authored-by: Theodore Chang <[email protected]>

Author: grizzlytheodore

src/Compute/Compute/ChangeLog.md

@@ -20,6 +20,7 @@
 
 -->
 ## Upcoming Release
+* Added `-PerformancePlus` parameter to `New-AzDiskConfig`
 
 ## Version 5.4.0
 * Added `-SkipIdentity`, `-PathUserIdentity`, `-IsTest` parameter to `Set-AzVMAEMExtension` 

src/Compute/Compute/Generated/Disk/Config/NewAzureRmDiskConfigCommand.cs

@@ -242,6 +242,12 @@ public partial class NewAzureRmDiskConfigCommand : Microsoft.Azure.Commands.Reso
         [PSArgumentCompleter("X64", "Arm64")]
         public string Architecture { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Set this flag to true to get a boost on the performance target of the disk deployed, see here on the respective performance target. This flag can only be set on disk creation time and cannot be disabled after enabled.")]
+        public bool? PerformancePlus { get; set; }
+
         protected override void ProcessRecord()
         {
             if (ShouldProcess("Disk", "New"))
@@ -351,6 +357,15 @@ private void Run()
                 vCreationData.LogicalSectorSize = this.LogicalSectorSize;
             }
 
+            if (this.IsParameterBound(c => c.PerformancePlus))
+            {
+                if (vCreationData == null)
+                {
+                    vCreationData = new CreationData();
+                }
+                vCreationData.PerformancePlus = this.PerformancePlus;
+            }
+
             if (this.IsParameterBound(c => c.EncryptionSettingsEnabled))
             {
                 if (vEncryptionSettingsCollection == null)

src/Compute/Compute/help/New-AzDiskConfig.md

@@ -25,7 +25,8 @@ New-AzDiskConfig [[-SkuName] <String>] [-Tier <String>] [-LogicalSectorSize <Int
  [-DiskEncryptionSetId <String>] [-EncryptionType <String>] [-DiskAccessId <String>]
  [-NetworkAccessPolicy <String>] [-BurstingEnabled <Boolean>] [-PublicNetworkAccess <String>]
  [-AcceleratedNetwork <Boolean>] [-DataAccessAuthMode <String>] [-Architecture <String>]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-PerformancePlus <Boolean>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
+ [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -484,6 +485,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -PerformancePlus
+Set this flag to true to get a boost on the performance target of the disk deployed, see here on the respective performance target. This flag can only be set on disk creation time and cannot be disabled after enabled.
+
+```yaml
+Type: System.Nullable`1[System.Boolean]
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: True (ByPropertyName)
+Accept wildcard characters: False
+```
+
 ### -PublicNetworkAccess
 Policy for controlling export on the disk.
 

tools/StaticAnalysis/Exceptions/Az.Compute/SignatureIssues.csv

@@ -156,3 +156,4 @@
 "Az.Compute","Get-AzGalleryApplication","Get-AzGalleryApplication","2","8200","Get-AzGalleryApplication changes the confirm impact.  Please ensure that the change in ConfirmImpact is justified","Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact."
 "Az.Compute","Get-AzGalleryApplicationVersion","Get-AzGalleryApplicationVersion","2","8010","Get-AzGalleryApplicationVersion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
 "Az.Compute","Get-AzGalleryApplicationVersion","Get-AzGalleryApplicationVersion","2","8200","Get-AzGalleryApplicationVersion changes the confirm impact.  Please ensure that the change in ConfirmImpact is justified","Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact."
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmDiskConfigCommand","New-AzDiskConfig","1","8410","Parameter PerformancePlus of cmdlet New-AzDiskConfig does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."