Addressing initial round of feedback.

Author: wilcobmsft

TestMappings.json

@@ -123,6 +123,9 @@
   "src/ResourceManager/StreamAnalytics/": [
     ".\\src\\ResourceManager\\StreamAnalytics\\Commands.StreamAnalytics.Test\\bin\\Debug\\Microsoft.Azure.Commands.StreamAnalytics.Test.dll"
   ],
+  "src/ResourceManager/SubscriptionDefinition/": [
+    ".\\src\\ResourceManager\\SubscriptionDefinition\\Commands.SubscriptionDefinition.Test\\bin\\Debug\\Microsoft.Azure.Commands.SubscriptionDefinition.Test.dll"
+  ],
   "src/ResourceManager/Tags/": [],
   "src/ResourceManager/TrafficManager/": [
     ".\\src\\ResourceManager\\TrafficManager\\Commands.TrafficManager2.Test\\bin\\Debug\\Microsoft.Azure.Commands.TrafficManager.Test.ScenarioTests.dll"

src/ResourceManager/SubscriptionDefinition/AzureRM.SubscriptionDefinition.psd1

@@ -51,10 +51,10 @@ CLRVersion = '4.0'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '3.3.2'; })
+RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '4.0.0'; })
 
 # Assemblies that must be loaded prior to importing this module
-# RequiredAssemblies = @()
+RequiredAssemblies = '.\Microsoft.Azure.Management.ResourceManager.dll'
 
 # Script files (.ps1) that are run in the caller's environment prior to importing this module.
 # ScriptsToProcess = @()
@@ -98,7 +98,7 @@ PrivateData = @{
         Tags = 'Azure','ResourceManager','ARM','Subscription','SubscriptionDefinition'
 
         # A URL to the license for this module.
-        LicenseUri = 'https://raw.githubusercontent.com/Azure/azure-powershell/preview/LICENSE.txt'
+        LicenseUri = 'https://aka.ms/azps-license'
 
         # A URL to the main website for this project.
         ProjectUri = 'https://github.com/Azure/azure-powershell'

src/ResourceManager/SubscriptionDefinition/ChangeLog.md

@@ -18,3 +18,6 @@
         - Additional information about change #1
 -->
 ## Current Release
+## Version 0.1.0
+* New Cmdlets Get-AzureRmSubscriptionDefinition and New-AzureRmSubscriptionDefinition
+    - Cmdlets to create and list subscription definitions. Creation of a subscription definition results in a subscription.

src/ResourceManager/SubscriptionDefinition/Commands.SubscriptionDefinition.Test/Properties/AssemblyInfo.cs

@@ -45,5 +45,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("0.2.5")]
-[assembly: AssemblyFileVersion("0.2.5")]
+[assembly: AssemblyVersion("0.1.0")]
+[assembly: AssemblyFileVersion("0.1.0")]

src/ResourceManager/SubscriptionDefinition/Commands.SubscriptionDefinition/Cmdlets/GetAzureRmSubscriptionDefinition.cs

@@ -24,6 +24,7 @@ namespace Microsoft.Azure.Commands.SubscriptionDefinition.Cmdlets
     public class GetAzureRmSubscriptionDefinition : AzureSubscriptionDefinitionCmdletBase
     {
         [Parameter(ParameterSetName = ParameterSetNames.Default, Mandatory = false, HelpMessage = "Name of the subscription definition to retrieve.")]
+        [ValidateNotNullOrEmpty]
         public string Name { get; set; }
 
         public override void ExecuteCmdlet()

src/ResourceManager/SubscriptionDefinition/Commands.SubscriptionDefinition/Properties/AssemblyInfo.cs

@@ -19,14 +19,10 @@
 // General Information about an assembly is controlled through the following 
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
-[assembly: AssemblyTitle("Commands.SubscriptionDefinition")]
-[assembly: AssemblyDescription("")]
-[assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("")]
-[assembly: AssemblyProduct("Commands.SubscriptionDefinition")]
-[assembly: AssemblyCopyright("Copyright (c) 2017")]
-[assembly: AssemblyTrademark("")]
-[assembly: AssemblyCulture("")]
+[assembly: AssemblyTitle("Microsoft Azure Powershell - Subscription Definitions")]
+[assembly: AssemblyCompany(Microsoft.WindowsAzure.Commands.Common.AzurePowerShell.AssemblyCompany)]
+[assembly: AssemblyProduct(Microsoft.WindowsAzure.Commands.Common.AzurePowerShell.AssemblyProduct)]
+[assembly: AssemblyCopyright(Microsoft.WindowsAzure.Commands.Common.AzurePowerShell.AssemblyCopyright)]
 
 // Setting ComVisible to false makes the types in this assembly not visible 
 // to COM components.  If you need to access a type in this assembly from 
@@ -46,5 +42,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("0.2.5")]
-[assembly: AssemblyFileVersion("0.2.5")]
+[assembly: AssemblyVersion("0.1.0")]
+[assembly: AssemblyFileVersion("0.1.0")]

src/ResourceManager/SubscriptionDefinition/Commands.SubscriptionDefinition/help/Get-AzureRmSubscriptionDefinition.md

@@ -21,16 +21,31 @@ Get-AzureRmSubscriptionDefinition
 ### Example 1
 ```
 PS C:\> Get-AzureRmSubscriptionDefinition
+
+Name                    : MyProdSubscription1
+SubscriptionId          : 86869d42-1782-4337-98b0-c905fb937d46
+SubscriptionDisplayName : MyProdSubscription1
+OfferType               : MS-AZR-0017P
+
+Name                    : MyProdSubscription2
+SubscriptionId          : 368425df-b536-4f42-b1ba-64613cfcc4b5
+SubscriptionDisplayName : MyProdSubscription2
+OfferType               : MS-AZR-0017P
 ```
 
 Gets all subscription definitions.
 
 ### Example 2
 ```
-PS C:\> Get-AzureRmSubscriptionDefinition -Name MySubDef
+PS C:\> Get-AzureRmSubscriptionDefinition -Name MyProdSubscription2
+
+Name                    : MyProdSubscription2
+SubscriptionId          : 368425df-b536-4f42-b1ba-64613cfcc4b5
+SubscriptionDisplayName : MyProdSubscription2
+OfferType               : MS-AZR-0017P
 ```
 
-Gets a subscription definition with the name MySubDef.
+Gets a subscription definition with the name MyProdSubscription2.
 
 ## PARAMETERS
 

src/ResourceManager/SubscriptionDefinition/Commands.SubscriptionDefinition/help/New-AzureRmSubscriptionDefinition.md

@@ -24,13 +24,23 @@ The **New-AzureRmSubscriptionDefinition** cmdlet creates a subscription definiti
 ### Example 1
 ```
 PS C:\> New-AzureRmSubscriptionDefinition -Name MySubDef -OfferType MS-AZR-0017P
+
+Name                    : MySubDef
+SubscriptionId          : 86869d42-1782-4337-98b0-c905fb937d46
+SubscriptionDisplayName : MySubDef
+OfferType               : MS-AZR-0017P
 ```
 
 Creates a subscription definition with a default subscription display name.
 
 ### Example 2
 ```
 PS C:\> New-AzureRmSubscriptionDefinition -Name MySubDef -OfferType MS-AZR-0017P -SubscriptionDisplayName MyPaygoSub
+
+Name                    : MySubDef
+SubscriptionId          : 86869d42-1782-4337-98b0-c905fb937d46
+SubscriptionDisplayName : MyPaygoSub
+OfferType               : MS-AZR-0017P
 ```
 
 Creates a subscription definition with a custom subscription display name.