Skip to content

Commit 9c0f4e6

Browse files
committed
resolved review comments
1 parent ec0d188 commit 9c0f4e6

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

src/RecoveryServices/RecoveryServices.Backup.CrossRegionRestore.Management.Sdk/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@
2626
[assembly: CLSCompliant(false)]
2727
[assembly: Guid("2330c44a-18bf-46d8-976d-64e1fda5fc16")]
2828

29-
[assembly: AssemblyVersion("6.1.3")]
30-
[assembly: AssemblyFileVersion("6.1.3")]
29+
[assembly: AssemblyVersion("6.1.2")]
30+
[assembly: AssemblyFileVersion("6.1.2")]

src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/RecoveryPointConversions.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -794,6 +794,7 @@ public static RecoveryPointBase GetPSAzureVMRecoveryPointForSecondaryRegion(
794794
}
795795
}
796796

797+
// to uncomment while adding expiry time for CRR RPs
797798
/*if (recoveryPoint.RecoveryPointProperties != null)
798799
{
799800
rpBase.RecoveryPointExpiryTime = (recoveryPoint.RecoveryPointProperties.ExpiryTime != null) ? DateTime.Parse(recoveryPoint.RecoveryPointProperties.ExpiryTime): (DateTime?)null;

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@
2626
[assembly: CLSCompliant(false)]
2727
[assembly: Guid("d87b76bd-aa06-49ba-bfd7-f0f4984f65c3")]
2828

29-
[assembly: AssemblyVersion("6.1.3")]
30-
[assembly: AssemblyFileVersion("6.1.3")]
29+
[assembly: AssemblyVersion("6.1.2")]
30+
[assembly: AssemblyFileVersion("6.1.2")]

src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Item/DisableAzureRmRecoveryServicesBackupProtection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
using System.Management.Automation;
2525
using Microsoft.Rest.Azure.OData;
2626
using System;
27+
using Microsoft.Azure.Commands.Common.Exceptions;
2728

2829
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
2930
{
@@ -58,8 +59,7 @@ public SwitchParameter RemoveRecoveryPoints
5859
/// If this option is used, all the data backed up for this item will
5960
/// expire as per the protection policy retention settings
6061
/// </summary>
61-
[Parameter(Mandatory = false, HelpMessage = ParamHelpMsgs.Item.SuspendBackupOption)]
62-
[ValidateNotNullOrEmpty]
62+
[Parameter(Mandatory = false, HelpMessage = ParamHelpMsgs.Item.SuspendBackupOption)]
6363
public SwitchParameter RetainRecoveryPointsAsPerPolicy { get; set; }
6464

6565
/// <summary>
@@ -100,7 +100,7 @@ public override void ExecuteCmdlet()
100100

101101
if(DeleteBackupData && RetainRecoveryPointsAsPerPolicy.IsPresent)
102102
{
103-
throw new ArgumentException(String.Format(Resources.CantRemoveAndRetainRPsSimultaneously));
103+
throw new AzPSArgumentException(String.Format(Resources.CantRemoveAndRetainRPsSimultaneously), "RetainRecoveryPointsAsPerPolicy");
104104
}
105105

106106
PsBackupProviderManager providerManager =

src/RecoveryServices/RecoveryServices.Management.Sdk/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@
2626
[assembly: CLSCompliant(false)]
2727
[assembly: Guid("f1393c09-b594-43e7-8987-81393db883d0")]
2828

29-
[assembly: AssemblyVersion("6.1.3")]
30-
[assembly: AssemblyFileVersion("6.1.3")]
29+
[assembly: AssemblyVersion("6.1.2")]
30+
[assembly: AssemblyFileVersion("6.1.2")]

0 commit comments

Comments
 (0)