bugs 1346922, 1346908: spaces in generated file name, naming for a cmdlet

Author: sriramvu

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Commands.RecoveryServices.csproj

@@ -149,7 +149,7 @@
     <Compile Include="Service\GetAzureSiteRecoveryNetwork.cs" />
     <Compile Include="Service\CreateAzureSiteRecoveryRecoveryPlan.cs" />
     <Compile Include="Service\GetAzureSiteRecoveryRecoveryPlanFile.cs" />
-    <Compile Include="Service\GetAzureSiteRecoveryVaultCredential.cs" />
+    <Compile Include="Service\GetAzureSiteRecoveryVaultSettingsFile.cs" />
     <Compile Include="Service\RemoveAzureSiteRecoveryRecoveryPlan.cs" />
     <Compile Include="Service\GetAzureSiteRecoveryProtectionEntity.cs" />
     <Compile Include="Service\RestartAzureSiteRecoveryJob.cs" />

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/PSRecoveryServicesClient/PSRecoveryServicesVaultExtendedInfoClient.cs

@@ -157,7 +157,7 @@ private async Task<string> GetChannelIntegrityKey()
                 {
                     // In case this condition is true that means the credential was first generated in portal
                     // and hence can not be fetched here.
-                    throw new CloudException(Resources.VaultCredentialGenerationUnSupported);
+                    throw new CloudException(Resources.VaultSettingsGenerationUnSupported);
                 }
             }
 

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.Designer.cs

@@ -203,8 +203,8 @@ ClientRequestId: {3}</value>
   <data name="AzureVMNetworkIsNotAssociatedWithTheSubscription" xml:space="preserve">
     <value>AzureVMNetwork {0} is not associated with the Subscription {1}</value>
   </data>
-  <data name="VaultCredentialGenerationUnSupported" xml:space="preserve">
-    <value>Cannot generate vault credentials for this vault. Download it from the Azure Portal.</value>
+  <data name="VaultSettingsGenerationUnSupported" xml:space="preserve">
+    <value>Cannot generate vault settings file for this vault. Download it from the Azure Portal.</value>
   </data>
   <data name="VaultCreationSuccessMessage" xml:space="preserve">
     <value>Vault has been created</value>

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.resx

@@ -28,9 +28,9 @@ namespace Microsoft.Azure.Commands.RecoveryServices
     /// <summary>
     /// Retrieves Azure Site Recovery Server.
     /// </summary>
-    [Cmdlet(VerbsCommon.Get, "AzureSiteRecoveryVaultCredential", DefaultParameterSetName = ASRParameterSets.ByObject)]
-    [OutputType(typeof(VaultCredentialOutput))]
-    public class GetVaultCredentialsFile : RecoveryServicesCmdletBase
+    [Cmdlet(VerbsCommon.Get, "AzureSiteRecoveryVaultSettingsFile", DefaultParameterSetName = ASRParameterSets.ByObject)]
+    [OutputType(typeof(VaultSettingsFilePath))]
+    public class GetAzureSiteRecoveryVaultSettingsFile : RecoveryServicesCmdletBase
     {
         /// <summary>
         /// Expiry in hours for generated certificate.
@@ -158,7 +158,7 @@ private void GetByObject()
             string fileName = this.GenerateFileName();
 
             // write the content to a file.
-            VaultCredentialOutput output = new VaultCredentialOutput()
+            VaultSettingsFilePath output = new VaultSettingsFilePath()
             {
                 FilePath = Utilities.WriteToFile<ASRVaultCreds>(vaultCreds, filePath, fileName)
             };
@@ -174,14 +174,14 @@ private void GetByObject()
         private string GenerateFileName()
         {
             string fileName;
-
+            string format = "yyyy-MM-ddTHH-mm-ss";
             if (string.IsNullOrEmpty(this.Site.Name))
             {
-                fileName = string.Format("{0}_{1}.VaultCredentials", this.Vault.Name, DateTime.UtcNow.ToLongDateString());
+                fileName = string.Format("{0}_{1}.VaultCredentials", this.Vault.Name, DateTime.UtcNow.ToString(format));
             }
             else
             {
-                fileName = string.Format("{0}_{1}_{2}.VaultCredentials", this.Site.Name, this.Vault.Name, DateTime.UtcNow.ToLongDateString());
+                fileName = string.Format("{0}_{1}_{2}.VaultCredentials", this.Site.Name, this.Vault.Name, DateTime.UtcNow.ToString(format));
             }
 
             return fileName;

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/GetAzureSiteRecoveryVaultCredential.cs renamed to src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/GetAzureSiteRecoveryVaultSettingsFile.cs

@@ -1203,16 +1203,16 @@ public ASRServiceError(ServiceError serviceError)
     }
 
     /// <summary>
-    /// Class to define the output of the vault credential generation.
+    /// Class to define the output of the vault settings file generation.
     /// </summary>
-    public class VaultCredentialOutput
+    public class VaultSettingsFilePath
     {
         #region Constructor
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="VaultCredentialOutput" /> class
+        /// Initializes a new instance of the <see cref="VaultSettingsFilePath" /> class
         /// </summary>
-        public VaultCredentialOutput()
+        public VaultSettingsFilePath()
         {
         }