Fix bug with New-AzureBatchTask -Tasks parameter

  - This fixes #9912.

Author: matthchr

src/Batch/Batch.Test/Tasks/NewBatchTaskCommandTests.cs

@@ -178,7 +178,9 @@ public void ApplicationPackageReferencesAreSentOnATask()
             cmdlet.ExecuteCmdlet();
         }
 
-        private void ExitConditionsAreSentToService()
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void ExitConditionsAreSentToService()
         {
             BatchAccountContext context = BatchTestHelpers.CreateBatchContextWithKeys();
             cmdlet.BatchContext = context;
@@ -317,11 +319,65 @@ public void NewBatchTaskCollectionParametersTest()
 
             Assert.Throws<ArgumentNullException>(() => cmdlet.ExecuteCmdlet());
 
-            string[] taskIds = new[] {"simple1", "simple2"};
-            PSCloudTask expected1 = new PSCloudTask(taskIds[0], commandLine);
-            PSCloudTask expected2 = new PSCloudTask(taskIds[1], commandLine);
+            const string pattern = @"**\*.txt";
+            const string containerUrl = "containerUrl";
+            const string path = "path";
+            const OutputFileUploadCondition uploadCondition = OutputFileUploadCondition.TaskCompletion;
 
-            cmdlet.Tasks = new PSCloudTask[] {expected1, expected2};
+            string[] taskIds = new[] { "simple1", "simple2" };
+            PSCloudTask[] tasks = taskIds.Select(
+                id => new PSCloudTask(id, commandLine)
+                {
+                    ResourceFiles = new[]
+                    {
+                         new PSResourceFile(ResourceFile.FromUrl("anotherFile.txt", "https://another.blob"))
+                    },
+                    OutputFiles = new[] 
+                    {
+                        new PSOutputFile(
+                            pattern,
+                            new PSOutputFileDestination(new PSOutputFileBlobContainerDestination(containerUrl, path)),
+                            new PSOutputFileUploadOptions(uploadCondition))
+                    },
+                    ApplicationPackageReferences = new[]
+                    {
+                        new PSApplicationPackageReference
+                        {
+                            ApplicationId = "1",
+                            Version = "foo"
+                        }
+                    },
+                    ExitConditions = new PSExitConditions()
+                    {
+                        ExitCodeRanges = new List<PSExitCodeRangeMapping>
+                        {
+                            new PSExitCodeRangeMapping(
+                                5,
+                                10,
+                                new PSExitOptions
+                                {
+                                    DependencyAction = Azure.Batch.Common.DependencyAction.Block
+                                })
+
+                        },
+                        ExitCodes = new List<PSExitCodeMapping>
+                        {
+                            new PSExitCodeMapping(
+                                11,
+                                new PSExitOptions
+                                {
+                                    DependencyAction = Azure.Batch.Common.DependencyAction.Block
+                                })
+
+                        },
+                        Default = new PSExitOptions
+                        {
+                            DependencyAction = Azure.Batch.Common.DependencyAction.Satisfy
+                        }
+                    }
+                }).ToArray();
+
+            cmdlet.Tasks = tasks;
 
             IList<TaskAddParameter> requestCollection = null;
 
@@ -349,6 +405,18 @@ public void NewBatchTaskCollectionParametersTest()
             foreach (var task in requestCollection)
             {
                 Assert.Contains(task.Id, taskIds);
+                Assert.NotNull(task.ResourceFiles);
+                Assert.NotEmpty(task.ResourceFiles);
+                Assert.NotNull(task.OutputFiles);
+                Assert.NotEmpty(task.OutputFiles);
+                Assert.NotNull(task.ApplicationPackageReferences);
+                Assert.NotEmpty(task.ApplicationPackageReferences);
+
+                Assert.NotNull(task.ExitConditions.ExitCodeRanges);
+                Assert.NotEmpty(task.ExitConditions.ExitCodeRanges);
+                Assert.NotNull(task.ExitConditions.ExitCodes);
+                Assert.NotEmpty(task.ExitConditions.ExitCodes);
+                Assert.NotNull(task.ExitConditions.DefaultProperty);
             }
         }
 

src/Batch/Batch/Utils/Utils.cs

@@ -258,6 +258,9 @@ internal static void CloudTaskSyncCollections(PSCloudTask task)
                     ConvertEnvironmentSetting);
 
                 task.omObject.ResourceFiles = CreateSyncedList(task.ResourceFiles, ConvertResourceFile);
+                task.omObject.OutputFiles = CreateSyncedList(task.OutputFiles, ps => ps.omObject);
+                task.omObject.ApplicationPackageReferences = CreateSyncedList(task.ApplicationPackageReferences, ps => ps.omObject);
+                ExitConditionsSyncCollections(task.ExitConditions);
 
                 MultiInstanceSettingsSyncCollections(task.MultiInstanceSettings);
             }