Skip to content

Commit a4f8dcd

Browse files
committed
Fix for desktop tests in keyvault and network. Testing Travis dotnet version update.
1 parent d917c3e commit a4f8dcd

File tree

7 files changed

+15
-11
lines changed

7 files changed

+15
-11
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
sudo: required
22
language: csharp
33
mono: none
4-
dotnet: 2.1.2
4+
dotnet: 2.1.200
55
dist: trusty
66

77
env:

src/ResourceManager/KeyVault/Commands.KeyVault.Test/Commands.KeyVault.Test.Netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
<None Update="Scripts\ControlPlane\KeyVaultManagementTests.ps1">
5454
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
5555
</None>
56-
<None Update="pshtest.pfx">
56+
<None Update="Resources\pshtest.pfx">
5757
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
5858
</None>
5959
</ItemGroup>

src/ResourceManager/KeyVault/Commands.KeyVault.Test/Commands.KeyVault.Test.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,9 @@
179179
<None Include="packages.config">
180180
<SubType>Designer</SubType>
181181
</None>
182-
<None Include="Resources\pshtest.pfx" />
182+
<None Include="Resources\pshtest.pfx">
183+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
184+
</None>
183185
<None Include="ScenarioTests\Common.ps1">
184186
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
185187
</None>

src/ResourceManager/KeyVault/Commands.KeyVault.Test/Models/UtilitiesTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void GetWebKeyFromByok()
6363
public void GetWebKeyFromCertificate()
6464
{
6565
string password = "123";
66-
string path = "pshtest.pfx";
66+
string path = "Resources/pshtest.pfx";
6767

6868
IWebKeyConverter converters = WebKeyConverterFactory.CreateConverterChain();
6969
var webKey = converters.ConvertKeyFromFile(new FileInfo(path), password.ConvertToSecureString());
Binary file not shown.

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/ApplicationGatewayTests.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ function Test-ApplicationGatewayCRUD
123123
$fp01 = New-AzureRmApplicationGatewayFrontendPort -Name $frontendPort01Name  -Port 80
124124
$fp02 = New-AzureRmApplicationGatewayFrontendPort -Name $frontendPort02Name  -Port 8080
125125

126-
$authCertFilePath = $basedir + "ScenarioTests/Data/ApplicationGatewayAuthCert.cer"
126+
$authCertFilePath = $basedir + "/ScenarioTests/Data/ApplicationGatewayAuthCert.cer"
127127
$authcert01 = New-AzureRmApplicationGatewayAuthenticationCertificate -Name $authCertName -CertificateFile $authCertFilePath
128128

129129
# Create match with undefined statuscode list
@@ -330,7 +330,7 @@ function Test-ApplicationGatewayCRUD2
330330
{
331331
param
332332
(
333-
$basedir = ".\"
333+
$basedir = "./"
334334
)
335335

336336
# Setup
@@ -388,7 +388,7 @@ function Test-ApplicationGatewayCRUD2
388388

389389
# frontend part
390390
$pw01 = ConvertTo-SecureString "P@ssw0rd" -AsPlainText -Force
391-
$sslCert01Path = $basedir + "ScenarioTests/Data/ApplicationGatewaySslCert1.pfx"
391+
$sslCert01Path = $basedir + "/ScenarioTests/Data/ApplicationGatewaySslCert1.pfx"
392392
$sslCert01 = New-AzureRmApplicationGatewaySslCertificate -Name $sslCert01Name -CertificateFile $sslCert01Path -Password $pw01
393393

394394
$fipconfig = New-AzureRmApplicationGatewayFrontendIPConfig -Name $fipconfigName -PublicIPAddress $publicip
@@ -451,7 +451,7 @@ function Test-ApplicationGatewayCRUD2
451451
Assert-NotNull $getgw.SslCertificates[0].Password
452452

453453
$pw02 = ConvertTo-SecureString "P@ssw0rd" -AsPlainText -Force
454-
$sslCert02Path = $basedir + "ScenarioTests/Data/ApplicationGatewaySslCert2.pfx"
454+
$sslCert02Path = $basedir + "/ScenarioTests/Data/ApplicationGatewaySslCert2.pfx"
455455
$getgw = Add-AzureRmApplicationGatewaySslCertificate -ApplicationGateway $getgw -Name $sslCert02Name -CertificateFile $sslCert02Path -Password $pw02
456456

457457
# Modify existing application gateway with new configuration

src/ResourceManager/Profile/Commands.Profile.Test/AzureRMProfileTests.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -658,9 +658,12 @@ public void GetAzureRmSubscriptionByNameMultiplePages()
658658
Assert.Equal(tenants[1], resultSubscription.TenantId);
659659
}
660660

661-
#if !NETSTANDARD
662-
661+
#if NETSTANDARD
662+
[Fact(Skip = "ConcurrentDictionary is not marked as Serializable")]
663+
[Trait(Category.RunType, Category.DesktopOnly)]
664+
#else
663665
[Fact]
666+
#endif
664667
[Trait(Category.AcceptanceType, Category.CheckIn)]
665668
public void ProfileSerializeDeserializeWorks()
666669
{
@@ -723,7 +726,6 @@ public void ProfileSerializeDeserializeWorks()
723726
Assert.Equal("http://contoso.io", deserializedProfile.DefaultContext.Environment.GetProperty(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint));
724727
Assert.Equal("http://insights.contoso.io/", deserializedProfile.DefaultContext.Environment.GetProperty(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpointResourceId));
725728
}
726-
#endif
727729

728730
[Fact]
729731
[Trait(Category.AcceptanceType, Category.CheckIn)]

0 commit comments

Comments
 (0)