Check for empty ValidateSet to fix incorrect failures

Author: cormacpayne

tools/StaticAnalysis/BreakingChangeAnalyzer/ParameterMetadataHelper.cs

@@ -178,6 +178,12 @@ private void CheckParameterValidationSets(
             var oldValidateSet = oldParameter.ValidateSet;
             var newValidateSet = newParameter.ValidateSet;
 
+            // If there is no validate set in the new assembly, return
+            if (newValidateSet.Count == 0)
+            {
+                return;
+            }
+
             // If there was no validate set in the old assembly, but there is
             // one in the new assembly, log an issue
             if (oldValidateSet.Count == 0 && newValidateSet.Count > 0)

tools/StaticAnalysis/SerializedCmdlets/Microsoft.Azure.Commands.AnalysisServices.Dataplane.dll.json

@@ -40,6 +40,8 @@
             "GenericTypeArguments": []
           },
           "ValidateSet": [],
+          "ValidateRangeMin": null,
+          "ValidateRangeMax": null,
           "ValidateNotNullOrEmpty": false
         },
         {
@@ -54,6 +56,8 @@
             "GenericTypeArguments": []
           },
           "ValidateSet": [],
+          "ValidateRangeMin": null,
+          "ValidateRangeMax": null,
           "ValidateNotNullOrEmpty": false
         }
       ],
@@ -74,6 +78,8 @@
                   "GenericTypeArguments": []
                 },
                 "ValidateSet": [],
+                "ValidateRangeMin": null,
+                "ValidateRangeMax": null,
                 "ValidateNotNullOrEmpty": false
               },
               "Mandatory": false,
@@ -94,6 +100,8 @@
                   "GenericTypeArguments": []
                 },
                 "ValidateSet": [],
+                "ValidateRangeMin": null,
+                "ValidateRangeMax": null,
                 "ValidateNotNullOrEmpty": false
               },
               "Mandatory": false,
@@ -145,6 +153,8 @@
             "GenericTypeArguments": []
           },
           "ValidateSet": [],
+          "ValidateRangeMin": null,
+          "ValidateRangeMax": null,
           "ValidateNotNullOrEmpty": true
         },
         {
@@ -159,6 +169,8 @@
             "GenericTypeArguments": []
           },
           "ValidateSet": [],
+          "ValidateRangeMin": null,
+          "ValidateRangeMax": null,
           "ValidateNotNullOrEmpty": false
         }
       ],
@@ -179,6 +191,8 @@
                   "GenericTypeArguments": []
                 },
                 "ValidateSet": [],
+                "ValidateRangeMin": null,
+                "ValidateRangeMax": null,
                 "ValidateNotNullOrEmpty": true
               },
               "Mandatory": true,
@@ -199,6 +213,8 @@
                   "GenericTypeArguments": []
                 },
                 "ValidateSet": [],
+                "ValidateRangeMin": null,
+                "ValidateRangeMax": null,
                 "ValidateNotNullOrEmpty": false
               },
               "Mandatory": false,