Merge pull request #8076 from maddieclayton/operationalinsightsbc

OperationalInsights breaking changes

Author: cormacpayne

src/ResourceManager/OperationalInsights/Commands.OperationalInsights/ChangeLog.md

@@ -17,4 +17,5 @@
     * Overview of change #1
         - Additional information about change #1
 -->
-## Current Release
+## Current Release
+* Default parameter set for Get-AzOperationalInsightsDataSource is removed, and ByWorkspaceNameByKind has become the default parameter set

src/ResourceManager/OperationalInsights/Commands.OperationalInsights/DataSources/GetAzureOperationalInsightsDataSourceCommand.cs

@@ -20,7 +20,7 @@
 
 namespace Microsoft.Azure.Commands.OperationalInsights
 {
-    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "OperationalInsightsDataSource", DefaultParameterSetName = ByWorkspaceName), OutputType(typeof(PSDataSource))]
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "OperationalInsightsDataSource", DefaultParameterSetName = ByWorkspaceNameByKind), OutputType(typeof(PSDataSource))]
     public class GetAzureOperationalInsightsDataSourceCommand : OperationalInsightsBaseCmdlet
     {
         const string ByWorkspaceObjectByName = "ByWorkspaceObjectByName";
@@ -70,11 +70,6 @@ public class GetAzureOperationalInsightsDataSourceCommand : OperationalInsightsB
 
         public override void ExecuteCmdlet()
         {
-            if (ParameterSetName == ByWorkspaceName)
-            {
-                WriteWarning(Properties.Resources.GetWorkspaceDataSourceParameterSetWarning);
-                return;
-            }
             if (ParameterSetName == ByWorkspaceObjectByName || ParameterSetName == ByWorkspaceObjectByKind)
             {
                 ResourceGroupName = Workspace.ResourceGroupName;

src/ResourceManager/OperationalInsights/Commands.OperationalInsights/help/Get-AzOperationalInsightsDataSource.md

@@ -13,9 +13,10 @@ Get datasources under Azure Log Analytics workspace.
 
 ## SYNTAX
 
-### ByWorkspaceName (Default)
+### ByWorkspaceNameByKind (Default)
 ```
-Get-AzOperationalInsightsDataSource [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+Get-AzOperationalInsightsDataSource [[-ResourceGroupName] <String>] [[-WorkspaceName] <String>]
+ [-Kind] <String> [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ### ByWorkspaceObjectByName
@@ -36,12 +37,6 @@ Get-AzOperationalInsightsDataSource [-ResourceGroupName] <String> [-WorkspaceNam
  [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
-### ByWorkspaceNameByKind
-```
-Get-AzOperationalInsightsDataSource [[-ResourceGroupName] <String>] [[-WorkspaceName] <String>]
- [-Kind] <String> [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
-```
-
 ## DESCRIPTION
 The **Get-AzOperationalInsightsDataSource** cmdlet gets data sources.
 You can specify a data source to get.