Skip to content

Commit b0f7b84

Browse files
committed
address pr comments
1 parent 200edf5 commit b0f7b84

File tree

5 files changed

+3
-10
lines changed

5 files changed

+3
-10
lines changed

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/DisableAzureDiskEncryption.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,22 +84,19 @@ public class DisableAzureDiskEncryptionCommand : VirtualMachineExtensionBaseCmdl
8484

8585
[Parameter(
8686
Mandatory = false,
87-
Position = 5,
8887
ValueFromPipelineByPropertyName = true,
8988
HelpMessage = "Disable auto-upgrade of minor version")]
9089
public SwitchParameter DisableAutoUpgradeMinorVersion { get; set; }
9190

9291
[Parameter(
9392
Mandatory = false,
94-
Position = 6,
9593
ValueFromPipelineByPropertyName = true,
9694
HelpMessage = "The extension type. Specify this parameter to override its default value of \"AzureDiskEncryption\" for Windows VMs and \"AzureDiskEncryptionForLinux\" for Linux VMs.")]
9795
[ValidateNotNullOrEmpty]
9896
public string ExtensionType { get; set; }
9997

10098
[Parameter(
10199
Mandatory = false,
102-
Position = 7,
103100
ValueFromPipelineByPropertyName = true,
104101
HelpMessage = "The extension publisher name. Specify this parameter only to override the default value of \"Microsoft.Azure.Security\".")]
105102
[ValidateNotNullOrEmpty]

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/GetAzureDiskEncryptionStatus.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,13 @@ public class GetAzureDiskEncryptionStatusCommand : VirtualMachineExtensionBaseCm
6060

6161
[Parameter(
6262
Mandatory = false,
63-
Position = 3,
6463
ValueFromPipelineByPropertyName = true,
6564
HelpMessage = "The extension type. Specify this parameter to override its default value of \"AzureDiskEncryption\" for Windows VMs and \"AzureDiskEncryptionForLinux\" for Linux VMs.")]
6665
[ValidateNotNullOrEmpty]
6766
public string ExtensionType { get; set; }
6867

6968
[Parameter(
7069
Mandatory = false,
71-
Position = 4,
7270
ValueFromPipelineByPropertyName = true,
7371
HelpMessage = "The extension publisher name. Specify this parameter only to override the default value of \"Microsoft.Azure.Security\".")]
7472
[ValidateNotNullOrEmpty]

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/SetAzureDiskEncryptionExtension.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,15 +179,13 @@ public class SetAzureDiskEncryptionExtensionCommand : VirtualMachineExtensionBas
179179

180180
[Parameter(
181181
Mandatory = false,
182-
Position = 16,
183182
ValueFromPipelineByPropertyName = true,
184183
HelpMessage = "The extension type. Specify this parameter to override its default value of \"AzureDiskEncryption\" for Windows VMs and \"AzureDiskEncryptionForLinux\" for Linux VMs.")]
185184
[ValidateNotNullOrEmpty]
186185
public string ExtensionType { get; set; }
187186

188187
[Parameter(
189188
Mandatory = false,
190-
Position = 17,
191189
ValueFromPipelineByPropertyName = true,
192190
HelpMessage = "The extension publisher name. Specify this parameter only to override the default value of \"Microsoft.Azure.Security\".")]
193191
[ValidateNotNullOrEmpty]
@@ -394,7 +392,7 @@ private Hashtable GetExtensionPublicSettings()
394392
publicSettings.Add(AzureDiskEncryptionExtensionConstants.volumeTypeKey, VolumeType ?? String.Empty);
395393
publicSettings.Add(AzureDiskEncryptionExtensionConstants.sequenceVersionKey, SequenceVersion ?? String.Empty);
396394

397-
if (EncryptFormatAll)
395+
if (EncryptFormatAll.IsPresent)
398396
{
399397
publicSettings.Add(AzureDiskEncryptionExtensionConstants.encryptionOperationKey, AzureDiskEncryptionExtensionConstants.enableEncryptionFormatAllOperation);
400398
}

src/ResourceManager/Compute/Commands.Compute/help/Disable-AzureRmVMDiskEncryption.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ Parameter Sets: (All)
7272
Aliases:
7373

7474
Required: False
75-
Position: 5
75+
Position: Named
7676
Default value: None
7777
Accept pipeline input: True (ByPropertyName)
7878
Accept wildcard characters: False

src/ResourceManager/Compute/Commands.Compute/help/Set-AzureRmVMDiskEncryptionExtension.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ Aliases:
307307
Required: False
308308
Position: Named
309309
Default value: None
310-
Accept pipeline input: True (ByPropertyName)
310+
Accept pipeline input: False
311311
Accept wildcard characters: False
312312
```
313313

0 commit comments

Comments
 (0)