[Compute] Adding sharing profile to New-AzCapacityReservationGroup and Update-AzCapacityReservationGroup (#24420)

* sharing profile changes

* adding test

* fix help

* Added help message

* Updating test synopsis

Author: haagha

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs

@@ -633,5 +633,13 @@ public void TestVMTLWithGallerySourceImage()
         {
             TestRunner.RunTestScript("Test-VMTLWithGallerySourceImage");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.LiveOnly)]
+        public void TestCapacityReservationSharingProfile()
+        {
+            TestRunner.RunTestScript("Test-CapacityReservationSharingProfile");
+        }
+
     }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1

@@ -7441,3 +7441,51 @@ function Test-VMTLWithGallerySourceImage
         Clean-ResourceGroup $rgname;
     }
 }
+
+
+<#
+.SYNOPSIS
+Testing Capacity Reservation Sharing profile parameter
+Setting Sharing profile with multiple subs
+Then unsharing using empty string as value 
+#>
+function Test-CapacityReservationSharingProfile
+{
+    # Setup
+    $rgname = Get-ComputeTestResourceName;
+    $loc = 'WestEurope';
+
+    try
+    {
+        New-AzResourceGroup -Name $rgname -Location $loc -Force;
+
+        # create a CRG
+        $CRGName = 'CRG' + $rgname
+        New-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName -Location $loc -SharingProfile "/subscriptions/88fd8cb2-8248-499e-9a2d-4929a4b0133c"
+        
+        # try Get-CRG with InstanceView
+        $CRG = Get-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName -InstanceView
+        Assert-AreEqual "/subscriptions/88fd8cb2-8248-499e-9a2d-4929a4b0133c" $crg.SharingProfile.SubscriptionIds.Id
+
+        # Update CRG with new subscription
+        Update-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName -SharingProfile "/subscriptions/88fd8cb2-8248-499e-9a2d-4929a4b0133c", "/subscriptions/24fb23e3-6ba3-41f0-9b6e-e41131d5d61e"
+        $CRG = Get-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName -InstanceView
+        Assert-AreEqual 2 $crg.SharingProfile.SubscriptionIds.Count
+        
+        # Clear Sharing Profile for CapacityReservationGroup
+        Update-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName -SharingProfile ""
+        $CRG = Get-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName -InstanceView
+        Assert-AreEqual $null $crg.SharingProfile
+        
+         # remove CRG
+        Remove-AzCapacityReservationGroup -ResourceGroupName $rgname -Name $CRGName 
+        $CRG = Get-AzCapacityReservationGroup -ResourceGroupName $rgname
+        Assert-AreEqual $null $CRG.count
+
+    }
+    finally 
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname;
+    }
+} 

src/Compute/Compute/ChangeLog.md

@@ -29,6 +29,7 @@
   `New-AzGalleryImageVersion` defaulting to turn on TrustedLaunchSupported and HyperVGeneration to V2.
   `New-AzVM` and `New-AzVmss` will default to the image `Windows Server 2022 Azure Edition` instead of `Windows 2016 Datacenter` by default.
   `Get-AzVmss` will no longer allow empty values to `ResourceGroupName` and `VMScaleSetName` to avoid a bug where it will just return nothing.
+* Added a new parameter `-SharingProfile` to `New-AzCapacityReservationGroup` and `Update-AzCapacityReservationGroup`.
 
 ## Version 7.1.2
 * Fixed `New-AzVM` when a source image is specified to avoid an error on the `Version` value.

src/Compute/Compute/Generated/CapacityReservation/NewAzCapacityReservationGroupCommand.cs

@@ -1,4 +1,4 @@
-//
+//
 // Copyright (c) Microsoft and contributors.  All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
@@ -70,6 +70,11 @@ public class NewAzureCapacityReservationGroup : ComputeAutomationBaseCmdlet
             Mandatory = false)]
         public string[] Zone { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Allows a Capacity Reservation Group to be shared across subscriptions. Pass \"\" to unshare all subscriptions.  It is an array of strings; Contains an array of Arm resource ids of subscriptions\r\neg : \"/subscriptions/{subscriptionId1}\", \"/subscriptions/{subscriptionId2}\"\r\n")]
+        public string[] SharingProfile { get; set; }
+
         public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
@@ -88,11 +93,29 @@ public override void ExecuteCmdlet()
                     {
                         capacityReservationGroup.Zones = this.Zone;
                     }
+                    if (this.IsParameterBound(c => c.SharingProfile))
+                    {
+                        ResourceSharingProfile resourceSharingProfile = new ResourceSharingProfile();
+                        foreach (var item in this.SharingProfile)
+                        {
+                            if (item.Equals("", StringComparison.OrdinalIgnoreCase))
+                                continue;
+                            SubResource subResource = new SubResource(item);
+                            if (resourceSharingProfile.SubscriptionIds == null)
+                            {
+                                resourceSharingProfile.SubscriptionIds = new List<SubResource>();
+                            }
+                            resourceSharingProfile.SubscriptionIds.Add(subResource);
+                        }
+                        capacityReservationGroup.SharingProfile = resourceSharingProfile;
+                    }
 
                     var result = CapacityReservationGroupClient.CreateOrUpdate(this.ResourceGroupName, this.Name, capacityReservationGroup);
                     var psObject = new PSCapacityReservationGroup();
                     ComputeAutomationAutoMapperProfile.Mapper.Map<CapacityReservationGroup, PSCapacityReservationGroup>(result, psObject);
                     WriteObject(psObject);
+
+
                 }
             });
         }

src/Compute/Compute/Generated/CapacityReservation/UpdateAzCapacityReservationGroupCommand.cs

@@ -74,6 +74,10 @@ public class UpdateAzureCapacityReservationGroup : ComputeAutomationBaseCmdlet
         [ResourceIdCompleter("Microsoft.Compute/capacityReservationGroups")]
         public string ResourceId { get; set; }
 
+        [Parameter(
+            Mandatory = false)]
+        public string[] SharingProfile { get; set; }
+
         [Parameter(Mandatory = false,
             HelpMessage = "Run cmdlet in the background")]
         public SwitchParameter AsJob { get; set; }
@@ -117,8 +121,23 @@ public override void ExecuteCmdlet()
                     capacityReservationGroupUpdate.Tags = tags;
                 }
 
-                result = CapacityReservationGroupClient.Update(resourceGroupName, name, capacityReservationGroupUpdate);
+                if (this.IsParameterBound(c => c.SharingProfile))
+                {
+                    ResourceSharingProfile resourceSharingProfile = new ResourceSharingProfile();
+                    foreach (var item in this.SharingProfile)
+                    {
+                        SubResource subResource = new SubResource(item);
+                        if (resourceSharingProfile.SubscriptionIds == null)
+                        {
+                            resourceSharingProfile.SubscriptionIds = new List<SubResource>();
+                        }
+                        resourceSharingProfile.SubscriptionIds.Add(subResource);
+                    }
+                    capacityReservationGroupUpdate.SharingProfile = resourceSharingProfile;
+                }
+
 
+                result = CapacityReservationGroupClient.Update(resourceGroupName, name, capacityReservationGroupUpdate);
 
                 var psObject = new PSCapacityReservationGroup();
                 ComputeAutomationAutoMapperProfile.Mapper.Map<CapacityReservationGroup, PSCapacityReservationGroup>(result, psObject);

src/Compute/Compute/Generated/Models/PSCapacityReservationGroup.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Text.RegularExpressions;
 using Microsoft.Azure.Management.Compute.Models;
@@ -16,5 +16,6 @@ public class PSCapacityReservationGroup
         public IList<SubResourceReadOnly> VirtualMachinesAssociated { get; set; }
         public CapacityReservationGroupInstanceView InstanceView { get; set; }
         public IList<string> Zones { get; set; }
+        public ResourceSharingProfile SharingProfile { get; set; }
     }
-}
+}

src/Compute/Compute/help/New-AzCapacityReservationGroup.md

@@ -14,8 +14,8 @@ Creates a Capacity Reservation Group
 
 ```
 New-AzCapacityReservationGroup -ResourceGroupName <String> -Name <String> -Location <String> [-AsJob]
- [-Tag <Hashtable>] [-Zone <String[]>] [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-Tag <Hashtable>] [-Zone <String[]>] [-SharingProfile <String[]>] [-DefaultProfile <IAzureContextContainer>]
+ [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -92,6 +92,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -ProgressAction
+{{ Fill ProgressAction Description }}
+
+```yaml
+Type: System.Management.Automation.ActionPreference
+Parameter Sets: (All)
+Aliases: proga
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -ResourceGroupName
 Specifies the name of a resource group.
 
@@ -107,6 +122,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -SharingProfile
+Allows a Capacity Reservation Group to be shared across subscriptions. Pass "" to unshare all subscriptions.  It is an array of strings; Contains an array of Arm resource ids of subscriptions eg : "/subscriptions/{subscriptionId1}", "/subscriptions/{subscriptionId2}"
+
+```yaml
+Type: System.String[]
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -Tag
 Specifies that resources and resource groups can be tagged with a set of name-value pairs. Adding tags to resources enables you to group resources together across resource groups and to create your own views. Each resource or resource group can have a maximum of 15 tags.
 

src/Compute/Compute/help/Update-AzCapacityReservationGroup.md

@@ -14,28 +14,29 @@ Update the Capacity Reservation Group.
 
 ### DefaultParameter (Default)
 ```
-Update-AzCapacityReservationGroup [-AsJob] [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+Update-AzCapacityReservationGroup [-SharingProfile <String[]>] [-AsJob] [-Tag <Hashtable>]
+ [-DefaultProfile <IAzureContextContainer>] [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm]
+ [<CommonParameters>]
 ```
 
 ### DefaultParameterSet
 ```
-Update-AzCapacityReservationGroup -ResourceGroupName <String> -Name <String> [-AsJob] [-Tag <Hashtable>]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
- [<CommonParameters>]
+Update-AzCapacityReservationGroup -ResourceGroupName <String> -Name <String> [-SharingProfile <String[]>]
+ [-AsJob] [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>] [-ProgressAction <ActionPreference>]
+ [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ### InputObjectParameterSet
 ```
-Update-AzCapacityReservationGroup -CapacityReservationGroup <PSCapacityReservationGroup> [-AsJob]
- [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
- [-Confirm] [<CommonParameters>]
+Update-AzCapacityReservationGroup -CapacityReservationGroup <PSCapacityReservationGroup>
+ [-SharingProfile <String[]>] [-AsJob] [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>]
+ [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ### ResourceIDParameterSet
 ```
-Update-AzCapacityReservationGroup -ResourceId <String> [-AsJob] [-Tag <Hashtable>]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
+Update-AzCapacityReservationGroup -ResourceId <String> [-SharingProfile <String[]>] [-AsJob] [-Tag <Hashtable>]
+ [-DefaultProfile <IAzureContextContainer>] [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm]
  [<CommonParameters>]
 ```
 
@@ -120,6 +121,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -ProgressAction
+{{ Fill ProgressAction Description }}
+
+```yaml
+Type: System.Management.Automation.ActionPreference
+Parameter Sets: (All)
+Aliases: proga
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -ResourceGroupName
 Specifies the name of a resource group.
 
@@ -150,6 +166,22 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -SharingProfile
+Allows a Capacity Reservation Group to be shared across subscriptions. Pass "" to unshare all subscriptions.  It is an array of strings; Contains an array of Arm resource ids of subscriptions
+eg : "/subscriptions/{subscriptionId1}", "/subscriptions/{subscriptionId2}"
+
+```yaml
+Type: System.String[]
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -Tag
 Resource tags.