Skip to content

Commit b96f37f

Browse files
Issues:
1) Azure RDFE service model now reports "ReferenceName" property as fully qualified extension name "Microsoft.SqlServer.Management.SqlIaaSAgent" 2) Status message's name was updated from "Automatic to Automated. This change was not reflected in powershell Fixes: 1) remove code that was concatenating publisher and extension name and just rely on "ReferenceName" when we look for Extension Status in powershell cmdlet 2) fix up constants AutoPatchingStatusMessageName & AutoBackupStatusMessageName ( rename Automatic to Automated )
1 parent 3cbb7ff commit b96f37f

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/GetAzureVMSqlServerExtension.cs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS.Extensions
4040
public class GetAzureVMSqlServerExtensionCommand : VirtualMachineSqlServerExtensionCmdletBase
4141
{
4242
protected const string GetSqlServerExtensionParamSetName = "GetSqlServerExtension";
43-
protected const string AutoPatchingStatusMessageName = "Automatic Patching";
44-
protected const string AutoBackupStatusMessageName = "Automatic Backup";
43+
protected const string AutoPatchingStatusMessageName = "Automated Patching";
44+
protected const string AutoBackupStatusMessageName = "Automated Backup";
4545

4646
internal void ExecuteCommand()
4747
{
@@ -89,18 +89,15 @@ private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExte
8989
// Note: valid reference to an extension status list is returned by GetResourceExtensionStatusList()
9090
foreach (NSM.ResourceExtensionStatus res in extensionStatusList)
9191
{
92-
// Extension handler name in format publisher.ReferenceName
93-
string extensionHandlerName = string.Format(CultureInfo.InvariantCulture,
94-
"{0}.{1}",
95-
r.Publisher,
96-
r.ReferenceName);
97-
98-
// skip all non-sql extensions
99-
if (!res.HandlerName.Equals(extensionHandlerName, System.StringComparison.InvariantCulture))
92+
// Expected ReferenceName = "Microsoft.SqlServer.Management.SqlIaaSAgent"
93+
if (!res.HandlerName.Equals(r.ReferenceName, System.StringComparison.InvariantCulture))
10094
{
95+
// skip all non-sql extensions
10196
continue;
10297
}
10398

99+
WriteVerboseWithTimestamp("Found SQL Extension:" + r.ReferenceName);
100+
104101
if (null != res.ExtensionSettingStatus)
105102
{
106103
context.SubStatusList = res.ExtensionSettingStatus.SubStatusList;

0 commit comments

Comments
 (0)