Domain name label with randomness.

Author: sergey-shandar

src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj

@@ -60,6 +60,7 @@
     <Compile Include="IResourceStrategy.cs" />
     <Compile Include="IShouldProcess.cs" />
     <Compile Include="ITaskProgress.cs" />
+    <Compile Include="Mutable.cs" />
     <Compile Include="ProgressMap.cs" />
     <Compile Include="TimeSlot.cs" />
     <Compile Include="StateOperationContext.cs" />

src/ResourceManager/Common/Commands.Common.Strategies/Mutable.cs

@@ -0,0 +1,13 @@
+namespace Microsoft.Azure.Commands.Common.Strategies
+{
+    public sealed class Mutable<T>
+    {
+        public T Value { get; set; }
+    }
+
+    public static class Mutable
+    {
+        public static Mutable<T> Create<T>(T value)
+            => new Mutable<T> { Value = value };
+    }
+}

src/ResourceManager/Compute/Commands.Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetCreateOrUpdateMethod.cs

@@ -160,7 +160,6 @@ async Task SimpleParameterSetExecuteCmdlet(IAsyncCmdlet asyncCmdlet)
             VirtualNetworkName = VirtualNetworkName ?? VMScaleSetName;
             SubnetName = SubnetName ?? VMScaleSetName;
             PublicIpAddressName = PublicIpAddressName ?? VMScaleSetName;
-            DomainNameLabel = DomainNameLabel ?? (VMScaleSetName + ResourceGroupName).ToLower();
             SecurityGroupName = SecurityGroupName ?? VMScaleSetName;
             LoadBalancerName = LoadBalancerName ?? VMScaleSetName;
             FrontendPoolName = FrontendPoolName ?? VMScaleSetName;
@@ -204,12 +203,14 @@ async Task SimpleParameterSetExecuteCmdlet(IAsyncCmdlet asyncCmdlet)
             }
 
             BackendPort = BackendPort ?? (isWindows ? new[] { 3389, 5985 } : new[] { 22 });
-            
+
+            var domainNameLabel = Mutable.Create(DomainNameLabel);
+
             var resourceGroup = ResourceGroupStrategy.CreateResourceGroupConfig(ResourceGroupName);
 
             var publicIpAddress = resourceGroup.CreatePublicIPAddressConfig(
                 name: PublicIpAddressName,
-                domainNameLabel: DomainNameLabel,
+                domainNameLabel: domainNameLabel,
                 allocationMethod: AllocationMethod);
 
             var virtualNetwork = resourceGroup.CreateVirtualNetworkConfig(
@@ -245,7 +246,9 @@ async Task SimpleParameterSetExecuteCmdlet(IAsyncCmdlet asyncCmdlet)
                 image: image,
                 vmSize: VmSize,
                 instanceCount: InstanceCount,
-                upgradeMode: (MyInvocation.BoundParameters.ContainsKey("UpgradePolicyMode") == true ) ? UpgradePolicyMode : (UpgradeMode?) null);
+                upgradeMode: (MyInvocation.BoundParameters.ContainsKey("UpgradePolicyMode") == true ) 
+                    ? UpgradePolicyMode 
+                    : (UpgradeMode?) null);
 
             var client = new Client(DefaultProfile.DefaultContext);
 
@@ -261,6 +264,10 @@ async Task SimpleParameterSetExecuteCmdlet(IAsyncCmdlet asyncCmdlet)
                 }
             }
 
+            // generate a domain name label if it's not specified.
+            await PublicIPAddressStrategy.FindDomainNameLabelAsync(
+                domainNameLabel: domainNameLabel, name: VMScaleSetName, location: Location, client: client);
+
             var target = virtualMachineScaleSet.GetTargetState(current, client.SubscriptionId, Location);
 
             var newState = await virtualMachineScaleSet
@@ -269,7 +276,7 @@ async Task SimpleParameterSetExecuteCmdlet(IAsyncCmdlet asyncCmdlet)
                    target,
                    new CancellationToken(),
                    new ShouldProcess(asyncCmdlet),
-                    asyncCmdlet.ReportTaskProgress);
+                   asyncCmdlet.ReportTaskProgress);
 
             var result = newState.Get(virtualMachineScaleSet);
             if(result == null)
@@ -280,7 +287,7 @@ async Task SimpleParameterSetExecuteCmdlet(IAsyncCmdlet asyncCmdlet)
             if (result != null)
             {
                 var psObject = new PSVirtualMachineScaleSet();
-                ComputeAutomationAutoMapperProfile.Mapper.Map<VirtualMachineScaleSet, PSVirtualMachineScaleSet>(result, psObject);
+                ComputeAutomationAutoMapperProfile.Mapper.Map(result, psObject);
                 asyncCmdlet.WriteObject(psObject);
             }
         }

src/ResourceManager/Compute/Commands.Compute/Strategies/Network/PublicIPAddressStrategy.cs

@@ -16,6 +16,8 @@
 using Microsoft.Azure.Management.Internal.Network.Version2017_10_01;
 using Microsoft.Azure.Management.Internal.Network.Version2017_10_01.Models;
 using Microsoft.Azure.Management.Internal.Resources.Models;
+using System;
+using System.Threading.Tasks;
 
 namespace Microsoft.Azure.Commands.Common.Strategies.Network
 {
@@ -35,7 +37,7 @@ static class PublicIPAddressStrategy
         public static ResourceConfig<PublicIPAddress> CreatePublicIPAddressConfig(
             this ResourceConfig<ResourceGroup> resourceGroup,
             string name,
-            string domainNameLabel,
+            Mutable<string> domainNameLabel,
             string allocationMethod)
             => Strategy.CreateResourceConfig(
                 resourceGroup: resourceGroup,
@@ -45,8 +47,24 @@ public static ResourceConfig<PublicIPAddress> CreatePublicIPAddressConfig(
                     PublicIPAllocationMethod = allocationMethod,
                     DnsSettings = new PublicIPAddressDnsSettings
                     {
-                        DomainNameLabel = domainNameLabel,                       
+                        DomainNameLabel = domainNameLabel.Value,                       
                     }
                 });
+
+        public static async Task FindDomainNameLabelAsync(
+            Mutable<string> domainNameLabel,
+            string name,
+            string location,
+            IClient client)
+        {
+            if (domainNameLabel.Value == null)
+            {
+                var networkClient = client.GetClient<NetworkManagementClient>();
+                do
+                {
+                    domainNameLabel.Value = (name + '-' + Guid.NewGuid().ToString().Substring(0, 6)).ToLower();
+                } while ((await networkClient.CheckDnsNameAvailabilityAsync(location, domainNameLabel.Value)).Available != true);
+            }
+        }
     }
 }

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

@@ -26,6 +26,8 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.Compute;
 using Microsoft.Azure.Management.Compute.Models;
+using Microsoft.Azure.Management.Internal.Network.Version2017_10_01;
+using Microsoft.Azure.Management.Internal.Resources;
 using Microsoft.Azure.Management.Storage;
 using Microsoft.Azure.Management.Storage.Models;
 using Microsoft.WindowsAzure.Commands.Sync.Download;
@@ -226,7 +228,6 @@ async Task StrategyExecuteCmdletAsync(IAsyncCmdlet asyncCmdlet)
             VirtualNetworkName = VirtualNetworkName ?? Name;
             SubnetName = SubnetName ?? Name;
             PublicIpAddressName = PublicIpAddressName ?? Name;
-            DomainNameLabel = DomainNameLabel ?? (Name + '-' + ResourceGroupName).ToLower();
             SecurityGroupName = SecurityGroupName ?? Name;
 
             bool isWindows;
@@ -269,6 +270,8 @@ async Task StrategyExecuteCmdletAsync(IAsyncCmdlet asyncCmdlet)
                 image = osTypeAndImage.Image;
                 isWindows = osTypeAndImage.OsType == "Windows";
             }
+
+            var domainNameLabel = Mutable.Create(DomainNameLabel);
 
             OpenPorts = OpenPorts ?? (isWindows ? new[] { 3389, 5985 } : new[] { 22 });
 
@@ -278,7 +281,7 @@ async Task StrategyExecuteCmdletAsync(IAsyncCmdlet asyncCmdlet)
             var subnet = virtualNetwork.CreateSubnet(SubnetName, SubnetAddressPrefix);
             var publicIpAddress = resourceGroup.CreatePublicIPAddressConfig(
                 name: PublicIpAddressName,
-                domainNameLabel: DomainNameLabel,
+                domainNameLabel: domainNameLabel,
                 allocationMethod: AllocationMethod);
             var networkSecurityGroup = resourceGroup.CreateNetworkSecurityGroupConfig(
                 name: SecurityGroupName,
@@ -372,7 +375,14 @@ async Task StrategyExecuteCmdletAsync(IAsyncCmdlet asyncCmdlet)
                 }
             }
 
-            var fqdn = DomainNameLabel + "." + Location + ".cloudapp.azure.com";
+            // generate a domain name label if it's not specified.
+            await PublicIPAddressStrategy.FindDomainNameLabelAsync(
+                domainNameLabel: domainNameLabel,
+                name: Name,
+                location: Location,
+                client: client);
+
+            var fqdn = domainNameLabel.Value + "." + Location + ".cloudapp.azure.com";
 
             // create target state
             var target = virtualMachine.GetTargetState(current, client.SubscriptionId, Location);