Skip to content

Commit be0c203

Browse files
author
Samuel Anudeep
committed
Merge pull request #125 from MabOneSdk/revert-124-dev1
Revert "FI from dev1 into release". Revert since this breaks the release
2 parents a61e2d2 + e354b2d commit be0c203

File tree

4 files changed

+6
-37
lines changed

4 files changed

+6
-37
lines changed

src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/AzureBackupJobHelper.cs

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
using System.Xml;
1919
using System.Linq;
2020
using Mgmt = Microsoft.Azure.Management.BackupServices.Models;
21-
using Microsoft.Azure.Commands.AzureBackup.Models;
2221

2322

2423
namespace Microsoft.Azure.Commands.AzureBackup.Cmdlets
@@ -63,30 +62,6 @@ public static class AzureBackupJobHelper
6362
{
6463
public static DateTime MinimumAllowedDate = new DateTime(DateTime.MinValue.Year, DateTime.MinValue.Month, DateTime.MinValue.Day, DateTime.MinValue.Hour, DateTime.MinValue.Minute, DateTime.MinValue.Second, DateTimeKind.Utc);
6564

66-
public static string GetTypeForPS(string itemType)
67-
{
68-
AzureBackupItemType managedContainerType = (AzureBackupItemType)Enum.Parse(typeof(AzureBackupItemType), itemType, true);
69-
70-
string returnType = string.Empty;
71-
72-
switch (managedContainerType)
73-
{
74-
case AzureBackupItemType.IaasVM:
75-
returnType = "AzureVM";
76-
break;
77-
}
78-
79-
return returnType;
80-
}
81-
82-
public static string GetTypeForService(string itemType)
83-
{
84-
if (itemType.CompareTo("AzureVM") == 0)
85-
return AzureBackupItemType.IaasVM.ToString();
86-
throw new ArgumentException("Invalid value", "itemType");
87-
}
88-
89-
9065
public static bool IsValidStatus(string inputStatus)
9166
{
9267
JobStatus status;

src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/GetAzureRMBackupJob.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public class GetAzureRMBackupJob : AzureBackupCmdletBase
5656
public string Status { get; set; }
5757

5858
[Parameter(Mandatory = false, HelpMessage = AzureBackupCmdletHelpMessage.JobFilterTypeHelpMessage, ParameterSetName = "FiltersSet")]
59-
[ValidateSet("AzureVM")]
59+
[ValidateSet("IaasVM")]
6060
public string Type { get; set; }
6161

6262
[Parameter(Mandatory = false, HelpMessage = AzureBackupCmdletHelpMessage.JobFilterOperationHelpMessage, ParameterSetName = "FiltersSet")]
@@ -79,11 +79,6 @@ public override void ExecuteCmdlet()
7979
JobId = Job.InstanceId;
8080
}
8181

82-
if (Type != null)
83-
{
84-
Type = AzureBackupJobHelper.GetTypeForService(Type);
85-
}
86-
8782
// validations
8883
if (!From.HasValue)
8984
{

src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/GetAzureRMBackupJobDetails.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class GetAzureRMBackupJobDetils : AzureBackupCmdletBase
3535

3636
[Parameter(Mandatory = true, HelpMessage = AzureBackupCmdletHelpMessage.JobDetailsFilterJobIdHelpMessage, ParameterSetName = "IdFiltersSet")]
3737
[ValidateNotNullOrEmpty]
38-
public string JobId { get; set; }
38+
public string JobID { get; set; }
3939

4040
[Parameter(Mandatory = true, HelpMessage = AzureBackupCmdletHelpMessage.JobDetailsFilterJobHelpMessage, ParameterSetName = "JobsFiltersSet", ValueFromPipeline = true)]
4141
[ValidateNotNull]
@@ -53,12 +53,12 @@ public override void ExecuteCmdlet()
5353
{
5454
if (Job != null)
5555
{
56-
JobId = Job.InstanceId;
56+
JobID = Job.InstanceId;
5757
}
5858

59-
WriteDebug(String.Format(Resources.JobIdFilter, JobId));
59+
WriteDebug(String.Format(Resources.JobIdFilter, JobID));
6060

61-
Mgmt.CSMJobDetailsResponse serviceJobProperties = AzureBackupClient.GetJobDetails(Vault.ResourceGroupName, Vault.Name, JobId);
61+
Mgmt.CSMJobDetailsResponse serviceJobProperties = AzureBackupClient.GetJobDetails(Vault.ResourceGroupName, Vault.Name, JobID);
6262
AzureRMBackupJobDetails jobDetails = new AzureRMBackupJobDetails(Vault, serviceJobProperties.JobDetailedProperties, serviceJobProperties.Name);
6363

6464
WriteDebug(Resources.JobResponse);

src/ResourceManager/AzureBackup/Commands.AzureBackup/Models/JobObjects.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
using Microsoft.Azure.Management.BackupServices;
2222
using Microsoft.Azure.Management.BackupServices;
2323
using Mgmt = Microsoft.Azure.Management.BackupServices.Models;
24-
using Microsoft.Azure.Commands.AzureBackup.Cmdlets;
2524

2625
namespace Microsoft.Azure.Commands.AzureBackup.Models
2726
{
@@ -53,7 +52,7 @@ public AzureRMBackupJob(AzureRMBackupVault vault, Mgmt.CSMJobProperties serviceJ
5352
: base(vault)
5453
{
5554
this.InstanceId = jobName;
56-
this.WorkloadType = AzureBackupJobHelper.GetTypeForPS(serviceJob.WorkloadType);
55+
this.WorkloadType = serviceJob.WorkloadType;
5756
this.WorkloadName = serviceJob.EntityFriendlyName;
5857
this.Operation = serviceJob.Operation;
5958
this.Status = serviceJob.Status;

0 commit comments

Comments
 (0)