Skip to content

Commit be2afbb

Browse files
yoavfryoavfr
committed
more test and documentation fixes
1 parent 1625b60 commit be2afbb

15 files changed

+73
-76
lines changed

‎src/Sql/Sql.Test/ScenarioTests/AdvancedDataSecurityManagedInstanceTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function Test-AdvancedDataSecurityPolicyManagedInstanceTest
6262
Assert-True { $policy.IsEnabled }
6363

6464
# Validate the VA policy
65-
$settings = Get-AzSqlInstanceVulnerabilityAssessmentSettings -ResourceGroupName $params.rgname -InstanceName $params.serverName
65+
$settings = Get-AzSqlInstanceVulnerabilityAssessmentSetting -ResourceGroupName $params.rgname -InstanceName $params.serverName
6666
Assert-AreEqual $params.rgname $settings.ResourceGroupName
6767
Assert-AreEqual $params.serverName $settings.InstanceName
6868
Assert-AreEqual "vulnerability-assessment" $settings.ScanResultsContainerName

‎src/Sql/Sql.Test/ScenarioTests/AdvancedDataSecurityTests.ps1

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ function Test-AdvancedDataSecurityPolicyTest
5252
Assert-False { $policy.IsEnabled }
5353

5454
# See that ATP cmdlets don't mess up the Threat Detection policy - with enabling VA off
55-
Update-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability
55+
Update-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability
5656

5757
Disable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName
5858

5959
# Assert
60-
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
60+
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
6161
Assert-AreEqual $policy.ThreatDetectionState "Disabled"
6262
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
6363
Assert-False {$policy.EmailAdmins}
@@ -67,7 +67,7 @@ function Test-AdvancedDataSecurityPolicyTest
6767
Enable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName -DoNotConfigureVulnerabilityAssessment
6868

6969
# Assert
70-
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
70+
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
7171
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
7272
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
7373
Assert-False {$policy.EmailAdmins}
@@ -85,7 +85,7 @@ function Test-AdvancedDataSecurityPolicyTest
8585
Assert-True { $policy.IsEnabled }
8686

8787
# Validate the VA policy
88-
$settings = Get-AzSqlServerVulnerabilityAssessmentSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
88+
$settings = Get-AzSqlServerVulnerabilityAssessmentSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
8989
Assert-AreEqual $params.rgname $settings.ResourceGroupName
9090
Assert-AreEqual $params.serverName $settings.ServerName
9191
Assert-AreEqual "vulnerability-assessment" $settings.ScanResultsContainerName
@@ -95,12 +95,12 @@ function Test-AdvancedDataSecurityPolicyTest
9595
Assert-AreEqualArray @() $settings.NotificationEmail
9696

9797
# See that ATP cmdlets don't mess up the Threat Detection policy - with enabling VA on
98-
Update-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability
98+
Update-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability
9999

100100
Disable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName
101101

102102
# Assert
103-
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
103+
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
104104
Assert-AreEqual $policy.ThreatDetectionState "Disabled"
105105
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
106106
Assert-False {$policy.EmailAdmins}
@@ -110,7 +110,7 @@ function Test-AdvancedDataSecurityPolicyTest
110110
Enable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName -DeploymentName "EnableVA_sql-ads-cmdlet-test-srv2"
111111

112112
# Assert
113-
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
113+
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
114114
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
115115
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
116116
Assert-False {$policy.EmailAdmins}

‎src/Sql/Sql.Test/ScenarioTests/ThreatDetectionClassicStorageTests.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ function Test-ThreatDetectionUpdatePolicyWithClassicStorage
2626
try
2727
{
2828
# Test - database policy
29-
Set-AzSqlDatabaseThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType "Sql_Injection_Vulnerability" -StorageAccountName $params.storageAccount
30-
$policy = Get-AzSqlDatabaseThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
29+
Set-AzSqlDatabaseThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType "Sql_Injection_Vulnerability" -StorageAccountName $params.storageAccount
30+
$policy = Get-AzSqlDatabaseThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
3131

3232
# Assert
3333
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
@@ -39,8 +39,8 @@ function Test-ThreatDetectionUpdatePolicyWithClassicStorage
3939

4040

4141
# Test - server policy
42-
Set-AzSqlServerThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability -StorageAccountName $params.storageAccount
43-
$policy = Get-AzSqlServerThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName
42+
Set-AzSqlServerThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability -StorageAccountName $params.storageAccount
43+
$policy = Get-AzSqlServerThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
4444

4545
# Assert
4646
Assert-AreEqual $policy.ThreatDetectionState "Enabled"

0 commit comments

Comments
 (0)