Merge branch 'dev' of https://github.com/Azure/azure-powershell into tiano-d2

Author: Tiano2017

src/ResourceManager/Automation/Commands.Automation.Test/UnitTests/RegisterAzureAutomationScheduledRunbookTest.cs

@@ -50,9 +50,10 @@ public void RegisterAzureAutomationScheduledRunbookSuccessfull()
             string accountName = "automation";
             string runbookName = "runbook";
             string scheduleName = "schedule";
+            string runOn = "hybridWorkerGroup";
 
             this.mockAutomationClient.Setup(
-                f => f.RegisterScheduledRunbook(resourceGroupName, accountName, runbookName, scheduleName, null));
+                f => f.RegisterScheduledRunbook(resourceGroupName, accountName, runbookName, scheduleName, null, runOn));
 
             // Test
             this.cmdlet.ResourceGroupName = resourceGroupName;
@@ -62,7 +63,7 @@ public void RegisterAzureAutomationScheduledRunbookSuccessfull()
             this.cmdlet.ExecuteCmdlet();
 
             // Assert
-            this.mockAutomationClient.Verify(f => f.RegisterScheduledRunbook(resourceGroupName, accountName, runbookName, scheduleName, null), Times.Once());
+            this.mockAutomationClient.Verify(f => f.RegisterScheduledRunbook(resourceGroupName, accountName, runbookName, scheduleName, null, runOn), Times.Once());
         }
     }
 }

src/ResourceManager/Automation/Commands.Automation/Cmdlet/RegisterAzureAutomationScheduledRunbook.cs

@@ -51,17 +51,23 @@ public class RegisterAzureAutomationScheduledRunbook : AzureAutomationBaseCmdlet
             HelpMessage = "The runbook parameters.")]
         public IDictionary Parameters { get; set; }
 
+        /// <summary>
+        /// Gets or sets the optional hybrid agent friendly name upon which the runbook should be executed.
+        /// </summary>
+        [Alias("HybridWorker")]
+        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByRunbookNameAndScheduleName, Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The name of the hybrid runbook worker group.")]
+        public string RunOn { get; set; }
+
         /// <summary>
         /// Execute this cmdlet.
         /// </summary>
         [PermissionSet(SecurityAction.Demand, Name = "FullTrust")]
         protected override void AutomationProcessRecord()
-        {
-            JobSchedule jobSchedule;
-
-            jobSchedule = this.AutomationClient.RegisterScheduledRunbook(
-                    this.ResourceGroupName, this.AutomationAccountName, this.RunbookName, this.ScheduleName, this.Parameters);
-
+        {            
+            var jobSchedule = this.AutomationClient.RegisterScheduledRunbook(
+                    this.ResourceGroupName, this.AutomationAccountName, this.RunbookName, this.ScheduleName, this.Parameters, this.RunOn);
+          
             this.WriteObject(jobSchedule);
         }
     }

src/ResourceManager/Automation/Commands.Automation/Common/AutomationClient.cs

@@ -1507,7 +1507,7 @@ public IEnumerable<JobSchedule> ListJobSchedulesByScheduleName(string resourceGr
         }
 
         public JobSchedule RegisterScheduledRunbook(string resourceGroupName, string automationAccountName, string runbookName,
-            string scheduleName, IDictionary parameters)
+            string scheduleName, IDictionary parameters, string runOn)
         {
             var processedParameters = this.ProcessRunbookParameters(resourceGroupName, automationAccountName, runbookName, parameters);
             var sdkJobSchedule = this.automationManagementClient.JobSchedules.Create(
@@ -1519,7 +1519,8 @@ public JobSchedule RegisterScheduledRunbook(string resourceGroupName, string aut
                     {
                         Schedule = new ScheduleAssociationProperty { Name = scheduleName },
                         Runbook = new RunbookAssociationProperty { Name = runbookName },
-                        Parameters = processedParameters
+                        Parameters = processedParameters,
+                        RunOn = runOn
                     }
                 }).JobSchedule;
 

src/ResourceManager/Automation/Commands.Automation/Common/IAutomationClient.cs

@@ -291,8 +291,8 @@ IEnumerable<JobStream> GetJobStream(string resourceGroupName, string automationA
         IEnumerable<JobSchedule> ListJobSchedulesByRunbookName(string resourceGroupName, string automationAccountName, string runbookName);
 
         IEnumerable<JobSchedule> ListJobSchedulesByScheduleName(string resourceGroupName, string automationAccountName, string scheduleName);
-
-        JobSchedule RegisterScheduledRunbook(string resourceGroupName, string automationAccountName, string runbookName, string scheduleName, IDictionary parameters);
+                
+        JobSchedule RegisterScheduledRunbook(string resourceGroupName, string automationAccountName, string runbookName, string scheduleName, IDictionary parameters, string RunOn);
 
         void UnregisterScheduledRunbook(string resourceGroupName, string automationAccountName, Guid jobScheduleId);
 

src/ResourceManager/Automation/Commands.Automation/Model/JobSchedule.cs

@@ -46,6 +46,7 @@ public JobSchedule(string resourceGroupName, string automationAccountName, Azure
             this.RunbookName = jobSchedule.Properties.Runbook.Name;
             this.ScheduleName = jobSchedule.Properties.Schedule.Name;
             this.Parameters = new Hashtable(StringComparer.InvariantCultureIgnoreCase);
+            this.RunOn = jobSchedule.Properties.RunOn;
             foreach (var kvp in jobSchedule.Properties.Parameters.Where(kvp => 0 != String.Compare(kvp.Key, Constants.JobStartedByParameterName, CultureInfo.InvariantCulture,
                 CompareOptions.IgnoreCase)))
             {
@@ -65,6 +66,8 @@ public JobSchedule()
         /// </summary>
         public string ResourceGroupName { get; set; }
 
+        public string RunOn { get; set; }
+
         /// <summary>
         /// Gets or sets the automation account name.
         /// </summary>

src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.csproj

@@ -398,7 +398,7 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestVirtualMachineSingleNetworkInterface.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestVirtualMachineSingleNetworkInterfaceWithAcceleratedNetworking.json">
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestSingleNetworkInterfaceWithAcceleratedNetworking.json">
 	<CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
 	<None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestVMNicWithAcceleratedNetworkingValidations.json">

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineNetworkInterfaceTests.cs

@@ -62,7 +62,7 @@ public void TestEffectiveRoutesAndNsg()
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestVirtualMachineSingleNetworkInterfaceWithAcceleratedNetworking()
+        public void TestSingleNetworkInterfaceWithAcceleratedNetworking()
         {
             ComputeTestController.NewInstance.RunPsTest("Test-SingleNetworkInterfaceWithAcceleratedNetworking");
         }

src/ResourceManager/Compute/Commands.Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests/TestVirtualMachineSingleNetworkInterfaceWithAcceleratedNetworking.json renamed to src/ResourceManager/Compute/Commands.Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests/TestSingleNetworkInterfaceWithAcceleratedNetworking.json

@@ -15,4 +15,4 @@
 $scriptFolder = Split-Path -Path $MyInvocation.MyCommand.Definition -Parent
 . ($scriptFolder + '.\SetupEnv.ps1')
 
-msbuild "$env:AzurePSRoot\build.proj" /t:Build
+msbuild "$env:AzurePSRoot\build.proj" /t:Build

tools/Build.ps1

@@ -38,7 +38,7 @@ public SignatureVerifierTests()
         /// <summary>
         /// 
         /// </summary>
-        [Fact]
+        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
         public void AddVerbWithoutSupportsShouldProcessParameter()
         {
             cmdletSignatureVerifier.Analyze(
@@ -68,7 +68,7 @@ public void AddVerbWithSupportsShouldProcessParameter()
 
         #region ForceSwitch and SupportsShouldProcess
 
-        [Fact]
+        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
         public void ForceParameterWithoutSupportsShouldProcess()
         {
             cmdletSignatureVerifier.Analyze(
@@ -108,7 +108,7 @@ public void ConfirmImpactWithSupportsShouldProcess()
             Assert.True(testReport.ProblemIdList.Count == 0);
         }
 
-        [Fact]
+        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
         public void ConfirmImpactWithoutSupportsShouldProcess()
         {
             cmdletSignatureVerifier.Analyze(
@@ -136,7 +136,7 @@ public void ShouldContinueVerbWithForceSwitch()
             Assert.True(testReport.ProblemIdList.Count == 0);
         }
 
-        [Fact]
+        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
         public void ShouldContinueVerbWithoutForceSwitch()
         {
             cmdletSignatureVerifier.Analyze(