Skip to content

Commit c16aae6

Browse files
hyonholeehyonholee
committed
ProximityPlacementGroupId Update feature
1 parent 70fcabe commit c16aae6

36 files changed

+2758
-1273
lines changed

‎src/Compute/Compute.Test/Compute.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<ItemGroup>
1414
<PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
15-
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="30.1.0" />
15+
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="30.2.0" />
1616
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="2.4.2" />
1717
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.17.0-preview" />
1818
</ItemGroup>

‎src/Compute/Compute.Test/ScenarioTests/DiagnosticsExtensionTests.ps1

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ function Test-VmssDiagnosticsExtension
273273
$vmss = Add-AzVmssDiagnosticsExtension -VirtualMachineScaleSet $vmss -Name $extname -SettingFilePath $publicSettingFilePath `
274274
-ProtectedSettingFilePath $privateSettingFilePath -TypeHandlerVersion $version -AutoUpgradeMinorVersion $false -Force;
275275

276-
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type -eq $diagExtType};
276+
[array] $vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type1 -eq $diagExtType};
277277
Assert-AreEqual 1 $vmssDiagExtensions.Count;
278278
$vmssDiagExtension = $vmssDiagExtensions | Select-Object -first 1;
279279

@@ -288,7 +288,7 @@ function Test-VmssDiagnosticsExtension
288288

289289
# Remove without specifying extension name, diagnostic extension is expected to be removed.
290290
$vmss = Remove-AzVmssDiagnosticsExtension -VirtualMachineScaleSet $vmss;
291-
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type -eq $diagExtType};
291+
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type1 -eq $diagExtType};
292292

293293
Assert-Null $vmssDiagExtensions;
294294

@@ -297,7 +297,7 @@ function Test-VmssDiagnosticsExtension
297297

298298
$vmss = Get-AzVmss -ResourceGroupName $rgname -VMScaleSetName $vmssName;
299299

300-
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type -eq $diagExtType};
300+
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type1 -eq $diagExtType};
301301
Assert-AreEqual 1 $vmssDiagExtensions.Count;
302302

303303
$vmssDiagExtension = $vmssDiagExtensions | Select-Object -first 1;
@@ -307,13 +307,13 @@ function Test-VmssDiagnosticsExtension
307307
Assert-AreEqual $storagename $settings.storageAccount.Value;
308308

309309
$vmss = Remove-AzVmssDiagnosticsExtension -VirtualMachineScaleSet $vmss -Name $extname;
310-
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type -eq $diagExtType};
310+
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type1 -eq $diagExtType};
311311
Assert-Null $vmssDiagExtensions;
312312

313313
Update-AzVmss -ResourceGroupName $rgname -Name $vmssName -VirtualMachineScaleSet $vmss;
314314

315315
$vmss = Get-AzVmss -ResourceGroupName $rgname -VMScaleSetName $vmssName;
316-
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type -eq $diagExtType};
316+
$vmssDiagExtensions = $vmss.VirtualMachineProfile.ExtensionProfile.Extensions | Where-Object {$_.Publisher -eq $diagExtPublisher -and $_.Type1 -eq $diagExtType};
317317

318318
Assert-Null $vmssDiagExtensions;
319319
}

‎src/Compute/Compute.Test/ScenarioTests/PPGTests.ps1

Lines changed: 45 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -80,31 +80,45 @@ function Test-ProximityPlacementGroupAvSet
8080
New-AzResourceGroup -Name $rgname -Location $loc -Force;
8181

8282
# Create a VM first
83-
$ppgname = $rgname + 'ppg'
84-
New-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname -Location $loc -ProximityPlacementGroupType "Standard" -Tag @{key1 = "val1"};
83+
$ppgname1 = $rgname + 'ppg'
84+
New-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname1 -Location $loc -ProximityPlacementGroupType "Standard" -Tag @{key1 = "val1"};
8585

86-
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname;
86+
$ppg1 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname1;
8787

88-
Assert-AreEqual $rgname $ppg.ResourceGroupName;
89-
Assert-AreEqual $ppgname $ppg.Name;
90-
Assert-AreEqual $loc $ppg.Location;
91-
Assert-AreEqual "Standard" $ppg.ProximityPlacementGroupType;
92-
Assert-True { $ppg.Tags.Keys.Contains("key1") };
93-
Assert-AreEqual "val1" $ppg.Tags["key1"];
88+
Assert-AreEqual $rgname $ppg1.ResourceGroupName;
89+
Assert-AreEqual $ppgname1 $ppg1.Name;
90+
Assert-AreEqual $loc $ppg1.Location;
91+
Assert-AreEqual "Standard" $ppg1.ProximityPlacementGroupType;
92+
Assert-True { $ppg1.Tags.Keys.Contains("key1") };
93+
Assert-AreEqual "val1" $ppg1.Tags["key1"];
9494

9595
$asetName = $rgname + 'as';
9696
New-AzAvailabilitySet -ResourceGroupName $rgname -Name $asetName -Location $loc -ProximityPlacementGroupId $ppg.Id -Sku 'Classic';
9797
$av = Get-AzAvailabilitySet -ResourceGroupName $rgname -Name $asetName;
98-
Assert-AreEqual $ppg.Id $av.ProximityPlacementGroup.Id;
98+
Assert-AreEqual $ppg1.Id $av.ProximityPlacementGroup.Id;
9999

100-
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname;
100+
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname1;
101101
Assert-AreEqual $av.Id $ppg.AvailabilitySets[0].Id;
102102

103+
# Create another PPG
104+
$ppgname2 = $rgname + 'ppg2'
105+
New-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2 -Location $loc -ProximityPlacementGroupType "Standard" -Tag @{key2 = "val2"};
106+
$ppg2 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2;
107+
108+
# Update AvSet to another PPG
109+
Update-AzAvailabilitySet -AvailabilitySet $av -ProximityPlacementGroupId $ppg2.Id;
110+
111+
$av = Get-AzAvailabilitySet -ResourceGroupName $rgname -Name $asetName;
112+
Assert-AreEqual $ppg2.Id $av.ProximityPlacementGroup.Id;
113+
103114
Remove-AzAvailabilitySet -ResourceGroupName $rgname -Name $asetName -Force;
104-
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname;
105-
Assert-Null $ppg.AvailabilitySets;
115+
$ppg1 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname1;
116+
Assert-Null $ppg1.AvailabilitySets;
117+
$ppg2 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2;
118+
Assert-Null $ppg2.AvailabilitySets;
106119

107-
Remove-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname -Force;
120+
Remove-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname1 -Force;
121+
Remove-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2 -Force;
108122
}
109123
finally
110124
{
@@ -182,11 +196,28 @@ function Test-ProximityPlacementGroupVM
182196
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname;
183197
Assert-AreEqual $vm.Id $ppg.VirtualMachines[0].Id;
184198

199+
Stop-AzVM -ResourceGroupName $rgname -Name $vmName -Force;
200+
201+
$ppgname2 = $rgname + 'ppg2'
202+
New-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2 -Location $loc -ProximityPlacementGroupType "Standard" -Tag @{key2 = "val2"};
203+
$ppg2 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2;
204+
205+
Update-AzVM -ResourceGroupName $rgname -VM $vm -ProximityPlacementGroupId $ppg2.Id;
206+
$vm = Get-AzVM -ResourceGroupName $rgname -Name $vmName;
207+
Assert-AreEqual $ppg2.Id $vm.ProximityPlacementGroup.Id;
208+
209+
$ppg2 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2;
210+
Assert-AreEqual $vm.Id $ppg2.VirtualMachines[0].Id;
211+
185212
Remove-AzVM -ResourceGroupName $rgname -Name $vmName -Force;
186213
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname;
187214
Assert-Null $ppg.VirtualMachines;
188215

216+
$ppg2 = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2;
217+
Assert-Null $ppg2.VirtualMachines;
218+
189219
Remove-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname -Force;
220+
Remove-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname2 -Force;
190221
}
191222
finally
192223
{

‎src/Compute/Compute.Test/ScenarioTests/StrategiesVirtualMachineTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ function Test-SimpleNewVmPpgId
558558
-ResourceGroupName $rgname `
559559
-Name $ppgname `
560560
-Location "eastus"
561-
$vm = New-AzVM -Name $vmname -Credential $cred -DomainNameLabel $domainNameLabel -ProximityPlacementGroup $ppg.Id
561+
$vm = New-AzVM -Name $vmname -Credential $cred -DomainNameLabel $domainNameLabel -ProximityPlacementGroupId $ppg.Id
562562

563563
Assert-AreEqual $vm.ProximityPlacementGroup.Id $ppg.Id
564564
}

‎src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ function Test-SimpleNewVmssPpg
394394
-ResourceGroupName $rgname `
395395
-Name $ppgname `
396396
-Location "eastus"
397-
$vmss = New-AzVmss -Name $vmssname -ResourceGroup $rgname -Credential $cred -DomainNameLabel $domainNameLabel -LoadBalancerName $lbName -ProximityPlacementGroup $ppgname
397+
$vmss = New-AzVmss -Name $vmssname -ResourceGroup $rgname -Credential $cred -DomainNameLabel $domainNameLabel -LoadBalancerName $lbName -ProximityPlacementGroupId $ppgname
398398

399399
Assert-AreEqual $vmss.ProximityPlacementGroup.Id $ppg.Id
400400
}

‎src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetProfileTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ function Test-VirtualMachineScaleSetProfile
115115
# Extension profile
116116
Assert-AreEqual $extname $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
117117
Assert-AreEqual $publisher $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
118-
Assert-AreEqual $exttype $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
118+
Assert-AreEqual $exttype $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
119119
Assert-AreEqual $extver $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
120120
Assert-True { $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion };
121121
Assert-Null $vmss.VirtualMachineProfile.ExtensionProfile.Extensions[0].ProvisionAfterExtensions;

‎src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ function Test-VirtualMachineScaleSetUpdate
456456
# Validate Extension Profile
457457
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
458458
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
459-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
459+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
460460
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
461461
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
462462

@@ -589,7 +589,7 @@ function Test-VirtualMachineScaleSetReimageUpdate
589589
# Validate Extension Profile
590590
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
591591
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
592-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
592+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
593593
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
594594
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
595595

@@ -1047,7 +1047,7 @@ function Test-VirtualMachineScaleSetBootDiagnostics
10471047
# Validate Extension Profile
10481048
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
10491049
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
1050-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
1050+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
10511051
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
10521052
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
10531053

@@ -1158,7 +1158,7 @@ function Test-VirtualMachineScaleSetIdentity
11581158
# Validate Extension Profile
11591159
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
11601160
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
1161-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
1161+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
11621162
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
11631163
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
11641164

@@ -1603,7 +1603,7 @@ function Test-VirtualMachineScaleSetWriteAcceleratorUpdate
16031603
# Validate Extension Profile
16041604
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
16051605
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
1606-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
1606+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
16071607
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
16081608
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
16091609

@@ -1717,7 +1717,7 @@ function Test-VirtualMachineScaleSetForceUDWalk
17171717
# Validate Extension Profile
17181718
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
17191719
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
1720-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
1720+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
17211721
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
17221722
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
17231723

@@ -2121,7 +2121,7 @@ function Test-VirtualMachineScaleSetAutoRollback
21212121
# Validate Extension Profile
21222122
Assert-AreEqual $extname $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Name;
21232123
Assert-AreEqual $publisher $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Publisher;
2124-
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type;
2124+
Assert-AreEqual $exttype $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].Type1;
21252125
Assert-AreEqual $extver $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].TypeHandlerVersion;
21262126
Assert-AreEqual $true $result.VirtualMachineProfile.ExtensionProfile.Extensions[0].AutoUpgradeMinorVersion;
21272127

‎src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.PPGTests/TestPPGAvSet.json

Lines changed: 589 additions & 178 deletions
Large diffs are not rendered by default.

‎src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.PPGTests/TestPPGVM.json

Lines changed: 1930 additions & 1004 deletions
Large diffs are not rendered by default.

‎src/Compute/Compute/AvailabilitySets/UpdateAzureAvailabilitySetCommand.cs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
using Microsoft.Azure.Commands.Compute.Common;
1919
using Microsoft.Azure.Commands.Compute.Models;
2020
using Microsoft.Azure.Management.Compute.Models;
21+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
2122

2223
namespace Microsoft.Azure.Commands.Compute
2324
{
@@ -37,13 +38,18 @@ public class UpdateAzureAvailabilitySetCommand : AvailabilitySetBaseCmdlet
3738
public PSAvailabilitySet AvailabilitySet { get; set; }
3839

3940
[Parameter(
40-
Mandatory = true,
41+
Mandatory = false,
4142
Position = 1,
4243
ParameterSetName = SkuParameterSetName,
4344
ValueFromPipelineByPropertyName = false,
4445
HelpMessage = "The Name of Sku")]
4546
public string Sku { get; set; }
4647

48+
[Parameter(
49+
Mandatory = false)]
50+
[ValidateNotNullOrEmpty]
51+
public string ProximityPlacementGroupId { get; set; }
52+
4753
[Parameter(
4854
Mandatory = false,
4955
HelpMessage = "Key-value pairs in the form of a hash table."
@@ -67,7 +73,10 @@ public override void ExecuteCmdlet()
6773
PlatformUpdateDomainCount = this.AvailabilitySet.PlatformUpdateDomainCount,
6874
PlatformFaultDomainCount = this.AvailabilitySet.PlatformFaultDomainCount,
6975
Tags = Tag == null ? null : Tag.Cast<DictionaryEntry>().ToDictionary(d => (string)d.Key, d => (string)d.Value),
70-
Sku = new Sku(this.Sku, null, null)
76+
Sku = new Sku(this.IsParameterBound(c => c.Sku) ? this.Sku : this.AvailabilitySet.Sku, null, null),
77+
ProximityPlacementGroup = this.IsParameterBound(c => c.ProximityPlacementGroupId)
78+
? new SubResource(this.ProximityPlacementGroupId)
79+
: this.AvailabilitySet.ProximityPlacementGroup
7180
};
7281

7382
var result = this.AvailabilitySetClient.CreateOrUpdateWithHttpMessagesAsync(

‎src/Compute/Compute/ChangeLog.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@
1919
- Additional information about change #1
2020
-->
2121
## Upcoming Release
22+
* Add ProximityPlacementGroupId parameter to the following cmdlets:
23+
- Update-AzAvailabilitySet, Update-AzVM, Update-AzVmss
24+
* Change ProximityPlacementGroup parameter to ProximityPlacementGroupId parameter in New-AzVM and New-AzVmss.
25+
(ProximityPlacementGroup parameter is still supported as an alias)
26+
* Update help message for VM and VMSS priority.
2227
* Update references in .psd1 to use relative path
2328

2429
## Version 3.1.0

‎src/Compute/Compute/Common/DiagnosticsHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ public static Tuple<Hashtable, Hashtable> GetConfigurationsFromFiles(string publ
742742
public static bool IsDiagnosticsExtension(VirtualMachineScaleSetExtension extension)
743743
{
744744
return extension.Publisher.Equals(DiagnosticsExtensionConstants.ExtensionPublisher, StringComparison.InvariantCultureIgnoreCase) &&
745-
extension.Type.Equals(DiagnosticsExtensionConstants.ExtensionType, StringComparison.InvariantCultureIgnoreCase);
745+
extension.Type1.Equals(DiagnosticsExtensionConstants.ExtensionType, StringComparison.InvariantCultureIgnoreCase);
746746
}
747747
}
748748
}

‎src/Compute/Compute/Compute.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<ItemGroup>
1515
<PackageReference Include="AutoMapper" Version="6.2.2" />
16-
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="30.1.0" />
16+
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="30.2.0" />
1717
<PackageReference Include="System.Security.Permissions" Version="4.5.0" />
1818
<PackageReference Include="System.ServiceModel.Primitives" Version="4.4.1" />
1919
<PackageReference Include="WindowsAzure.Storage" Version="9.3.0" />

‎src/Compute/Compute/Extension/Diagnostics/AddAzureRmVmssDiagnosticsExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ protected override void ProcessRecord()
166166

167167
newDiagnosticsExtension.Name = this.Name;
168168
newDiagnosticsExtension.Publisher = DiagnosticsExtensionConstants.ExtensionPublisher;
169-
newDiagnosticsExtension.Type = DiagnosticsExtensionConstants.ExtensionType;
169+
newDiagnosticsExtension.Type1 = DiagnosticsExtensionConstants.ExtensionType;
170170
newDiagnosticsExtension.TypeHandlerVersion = this.TypeHandlerVersion;
171171
newDiagnosticsExtension.AutoUpgradeMinorVersion = this.AutoUpgradeMinorVersion;
172172
newDiagnosticsExtension.Settings = settings.Item1;

0 commit comments

Comments
 (0)