Skip to content

Commit c200843

Browse files
committed
Merge pull request #1056 from vivsriaus/DeploymentId
Add Id to deployment cmdlets
2 parents 61ea799 + 1446ace commit c200843

File tree

14 files changed

+1502
-323
lines changed

14 files changed

+1502
-323
lines changed

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Commands.Resources.Rest.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,6 @@
168168
<Compile Include="Extensions\JTokenExtensions.cs" />
169169
<Compile Include="Implementation\ResourceManagerCmdletBase.cs" />
170170
<Compile Include="Implementation\Lock\SetAzureResourceLockCmdlet.cs" />
171-
<Compile Include="Implementation\Resource\TestAzureResourceCmdlet.cs" />
172-
<Compile Include="Implementation\TestAzureResourceGroupCmdlet.cs" />
173171
<Compile Include="Json\CamelCasePropertyNamesWithOverridesContractResolver.cs" />
174172
<Compile Include="Json\JsonPreserveCaseDictionaryAttribute.cs" />
175173
<Compile Include="Json\TimeSpanConverter.cs" />

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Resource/TestAzureResourceCmdlet.cs

Lines changed: 0 additions & 189 deletions
This file was deleted.

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/TestAzureResourceGroupCmdlet.cs

Lines changed: 0 additions & 109 deletions
This file was deleted.

src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,9 @@
319319
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests\TestGetADUserWithMail.json">
320320
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
321321
</None>
322+
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentTests\TestNewDeploymentFromTemplateFile.json">
323+
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
324+
</None>
322325
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.MoveResourceTest\TestMoveAzureResource.json">
323326
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
324327
</None>
@@ -530,6 +533,12 @@
530533
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleDefinitionTests\RoleDefinitionCreateTests.json">
531534
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
532535
</None>
536+
<None Include="sampleTemplate.json">
537+
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
538+
</None>
539+
<None Include="sampleTemplateParams.json">
540+
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
541+
</None>
533542
</ItemGroup>
534543
<ItemGroup>
535544
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />

src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/DeploymentTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public void TestValidateDeployment()
2424
ResourcesController.NewInstance.RunPsTest("Test-ValidateDeployment");
2525
}
2626

27-
[Fact (Skip = "Need to implement storage client mock.")]
27+
[Fact]
2828
public void TestNewDeploymentFromTemplateFile()
2929
{
3030
ResourcesController.NewInstance.RunPsTest("Test-NewDeploymentFromTemplateFile");

src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/DeploymentTests.ps1

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,25 @@ function Test-NewDeploymentFromTemplateFile
4545
$rglocation = Get-ProviderLocation ResourceManagement
4646
$location = Get-ProviderLocation "Microsoft.Web/sites"
4747

48-
# Test
49-
New-AzureRmResourceGroup -Name $rgname -Location $rglocation
48+
try
49+
{
50+
# Test
51+
New-AzureRmResourceGroup -Name $rgname -Location $rglocation
5052

51-
$deployment = New-AzureRmResourceGroupDeployment -ResourceGroupName $rgname -TemplateFile Build2014_Website_App.json -siteName $rname -hostingPlanName $rname -siteLocation $location -sku Free -workerSize 0
53+
$deployment = New-AzureRmResourceGroupDeployment -Name $rname -ResourceGroupName $rgname -TemplateFile sampleTemplate.json -TemplateParameterFile sampleTemplateParams.json
5254

53-
# Assert
54-
Assert-AreEqual Succeeded $deployment.ProvisioningStatelean-ResourceGroup $rgname
55+
# Assert
56+
Assert-AreEqual Succeeded $deployment.ProvisioningState
57+
58+
$subId = (Get-AzureRmContext).Subscription.SubscriptionId
59+
$deploymentId = "/subscriptions/$subId/resourcegroups/$rgname/providers/Microsoft.Resources/deployments/$rname"
60+
$getById = Get-AzureRmResourceGroupDeployment -Id $deploymentId
61+
Assert-AreEqual $getById.DeploymentName $deployment.DeploymentName
62+
}
63+
64+
finally
65+
{
66+
# Cleanup
67+
Clean-ResourceGroup $rgname
68+
}
5569
}

src/ResourceManager/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentTests/TestNewDeploymentFromTemplateFile.json

Lines changed: 1335 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)