Addressed PR comments

- clean up commented logic.
- remove irrelavent comments.

Author: nivimsft

src/Sql/Sql.Test/ScenarioTests/Common.ps1

@@ -305,6 +305,7 @@ Gets the values of the parameters used in the Server Key Vault Key tests
 #>
 function Get-SqlServerKeyVaultKeyTestEnvironmentParameters ()
 {
+	# Create a key vault with soft delete.configured
 	return @{ rgName = Get-ResourceGroupName;
 			  serverName = Get-ServerName;
 			  databaseName = Get-DatabaseName;
@@ -363,11 +364,6 @@ function Get-ManagedInstanceForTdeTest ($params)
 	$managedInstance = Create-ManagedInstanceForTest $rg $subnetId
 	Set-AzKeyVaultAccessPolicy -VaultName $params.vaultName -ObjectId $managedInstance.Identity.PrincipalId -PermissionsToKeys get, list, wrapKey, unwrapKey
 
-	# $mangedInstanceRg = "BenjinResourceGroup"
-	# $managedInstanceName = "benjinmitest"
-	# 
-	# $managedInstance = Get-AzSqlInstance -Name $managedInstanceName -ResourceGroupName $mangedInstanceRg
-
 	return $managedInstance
 }
 

src/Sql/Sql.Test/ScenarioTests/ManagedInstanceKeyVaultKeyTests.cs

@@ -50,9 +50,6 @@ public void TestManagedInstanceKeyVaultKey()
             RunPowerShellTest("Test-ManagedInstanceKeyVaultKey");
         }
 
-        //Commenting out these tests because automated checks are failing when there 
-        //is [fact] tag even when there is no trait tag
-
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestManagedInstanceKeyVaultKeyInputObject()

src/Sql/Sql.Test/ScenarioTests/ManagedInstanceProtectorTests.cs

@@ -50,9 +50,6 @@ public void TestSetGetManagedInstanceEncryptionProtectorByokFailsWithoutKeyId()
             RunPowerShellTest("Test-SetGetManagedInstanceEncryptionProtectorByokFailsWithoutKeyId");
         }
 
-        // Commenting out these tests because automated checks are failing when there 
-        //is [fact] tag even when there is no trait tag 
-
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestSetGetManagedInstanceEncryptionProtectorServiceManaged()

src/Sql/Sql.Test/ScenarioTests/ServerKeyVaultKeyTests.ps1

@@ -82,12 +82,9 @@ function Test-RemoveServerKeyVaultKey
 		Assert-AreEqual $params.keyId $keyGet.Uri
 		Assert-AreEqual $params.serverKeyName $keyGet.ServerKeyName
 
-		
-		$keyRemove = Remove-AzSqlServerKeyVaultKey -ServerName $params.serverName -ResourceGroupName $params.rgName -KeyId $params.keyId
-
-		# $job = Remove-AzSqlServerKeyVaultKey -ServerName $params.serverName -ResourceGroupName $params.rgName -KeyId $params.keyId -AsJob
-		# $job | Wait-Job
-		# $keyRemove = $job.Output
+		$job = Remove-AzSqlServerKeyVaultKey -ServerName $params.serverName -ResourceGroupName $params.rgName -KeyId $params.keyId -AsJob
+		$job | Wait-Job
+		$keyRemove = $job.Output
 
 		Assert-AreEqual $params.serverKeyName $keyRemove.ServerKeyName
 		Assert-AreEqual $params.keyId $keyRemove.Uri