Incorporate review feedback

Author: jasper-schneider

src/ResourceManager/AzureBatch/Commands.Batch.Test/BatchTestHelpers.cs

@@ -630,8 +630,7 @@ public static RequestInterceptor CreateFakeGetFileAndPropertiesFromComputeNodeRe
 
             foreach (string id in jobIds)
             {
-                ProxyModels.CloudJob job = new ProxyModels.CloudJob();
-                job.Id = id;
+                ProxyModels.CloudJob job = new ProxyModels.CloudJob(id: id);
                 jobs.Add(job);
             }
 

src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/BatchAccountTests.ps1

@@ -96,15 +96,15 @@ Tests getting a list of Batch node agent skus
 #>
 function Test-GetBatchNodeAgentSkus
 {
-	$context = New-Object Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestContext
+    $context = New-Object Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestContext
 
-	# Get the node agent skus
-	$nodeAgentSkus = Get-AzureBatchNodeAgentSku -BatchContext $context
+    # Get the node agent skus
+    $nodeAgentSkus = Get-AzureBatchNodeAgentSku -BatchContext $context
 
-	foreach($nodeAgentSku in $nodeAgentSkus)
+    foreach($nodeAgentSku in $nodeAgentSkus)
     {
         Assert-True { $nodeAgentSku.Id.StartsWith("batch.node") }
-		Assert-True { $nodeAgentSku.OSType -in "linux","windows" }
-		Assert-AreNotEqual 0 $nodeAgentSku.VerifiedImageReferences.Count
+        Assert-True { $nodeAgentSku.OSType -in "linux","windows" }
+        Assert-AreNotEqual 0 $nodeAgentSku.VerifiedImageReferences.Count
     }
 }

src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/ComputeNodeTests.ps1

@@ -99,12 +99,12 @@ Tests getting remote login settings from compute node
 #>
 function Test-GetRemoteLoginSettings
 {
-	param([string]$poolId, [string]$computeNodeId)
-	
-	$context = New-Object Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestContext
-	$remoteLoginSettings = Get-AzureBatchComputeNode $poolId $computeNodeId -BatchContext $context | Get-AzureBatchRemoteLoginSettings -BatchContext $context
+    param([string]$poolId, [string]$computeNodeId)
+    
+    $context = New-Object Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestContext
+    $remoteLoginSettings = Get-AzureBatchComputeNode $poolId $computeNodeId -BatchContext $context | Get-AzureBatchRemoteLoginSettings -BatchContext $context
 
-	Assert-AreNotEqual $null $remoteLoginSettings.IPAddress
-	Assert-AreNotEqual $null $remoteLoginSettings.Port
+    Assert-AreNotEqual $null $remoteLoginSettings.IPAddress
+    Assert-AreNotEqual $null $remoteLoginSettings.Port
 }
 

src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/PoolTests.ps1

@@ -30,7 +30,7 @@ function Test-PoolCRUD
         $targetOSVersion = "*"
         $targetDedicated = 0
         $vmSize = "small"
-		$paasConfiguration = New-Object Microsoft.Azure.Commands.Batch.Models.PSCloudServiceConfiguration -ArgumentList @($osFamily, $targetOSVersion)
+        $paasConfiguration = New-Object Microsoft.Azure.Commands.Batch.Models.PSCloudServiceConfiguration -ArgumentList @($osFamily, $targetOSVersion)
         New-AzureBatchPool $poolId1 -CloudServiceConfiguration $paasConfiguration -TargetDedicated $targetDedicated -VirtualMachineSize $vmSize -BatchContext $context
 
         $vmSize = "standard_a1"
@@ -39,7 +39,7 @@ function Test-PoolCRUD
         $osSKU = "16.04.0-LTS"
         $nodeAgent = "batch.node.ubuntu 16.04"
         $imageRef = New-Object Microsoft.Azure.Commands.Batch.Models.PSImageReference -ArgumentList @($offer, $publisher, $osSKU)
-		$iaasConfiguration = New-Object Microsoft.Azure.Commands.Batch.Models.PSVirtualMachineConfiguration -ArgumentList @($imageRef, $nodeAgent)
+        $iaasConfiguration = New-Object Microsoft.Azure.Commands.Batch.Models.PSVirtualMachineConfiguration -ArgumentList @($imageRef, $nodeAgent)
         New-AzureBatchPool $poolId2 -VirtualMachineConfiguration $iaasConfiguration -TargetDedicated $targetDedicated -VirtualMachineSize $vmSize -BatchContext $context
 
         # List the pools to ensure they were created