Skip to content

Commit c94afe2

Browse files
authored
Merge pull request #7164 from Azure/reservations
Reservations RP 2018-06-01: Add CosmosDb in reserved resource enum type. Add name property in PatchProperties
2 parents 802d53b + fb55009 commit c94afe2

File tree

11 files changed

+147
-46
lines changed

11 files changed

+147
-46
lines changed

src/ResourceManager/Reservations/Commands.Reservations.Test/Commands.Reservations.Test.Netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</PropertyGroup>
2525

2626
<ItemGroup>
27-
<PackageReference Include="Microsoft.Azure.Management.Reservations" Version="1.8.0-preview" />
27+
<PackageReference Include="Microsoft.Azure.Management.Reservations" Version="1.9.0-preview" />
2828
</ItemGroup>
2929

3030
<ItemGroup>

src/ResourceManager/Reservations/Commands.Reservations.Test/Commands.Reservations.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
</PropertyGroup>
3333
<ItemGroup>
3434
<Reference Include="Microsoft.Azure.Management.Reservations">
35-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Reservations.1.8.0-preview\lib\net452\Microsoft.Azure.Management.Reservations.dll</HintPath>
35+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Reservations.1.9.0-preview\lib\net452\Microsoft.Azure.Management.Reservations.dll</HintPath>
3636
</Reference>
3737
</ItemGroup>
3838
<ItemGroup>

src/ResourceManager/Reservations/Commands.Reservations.Test/ScenarioTests/ReservationTests.ps1

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,16 @@ function Test-GetCatalog
5555
Assert-True { $item.Terms.Count -gt 0 }
5656
Assert-True { $item.Locations.Count -gt 0 }
5757
}
58+
59+
# Get CosmosDb catalog
60+
$catalog = Get-AzureRmReservationCatalog -SubscriptionId $subscriptionId -ReservedResourceType CosmosDb
61+
Foreach ($item in $catalog)
62+
{
63+
Assert-NotNull $item.ResourceType
64+
Assert-NotNull $item.Name
65+
Assert-True { $item.Terms.Count -gt 0 }
66+
Assert-Null $item.Locations
67+
}
5868
}
5969

6070
<#

src/ResourceManager/Reservations/Commands.Reservations.Test/SessionRecords/Microsoft.Azure.Commands.Reservations.Test.ScenarioTests.ReservationTests/TestGetCatalog.json

Lines changed: 104 additions & 35 deletions
Large diffs are not rendered by default.

src/ResourceManager/Reservations/Commands.Reservations/ChangeLog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
- Additional information about change #1
2020
-->
2121
## Current Release
22+
* Update to the latest .NET SDK version 1.9.0-preview.
23+
* Add CosmosDb type in reserved resource enum type.
24+
* Add name property in PatchProperties.
2225

2326
## Version 0.1.6
2427
* Updated to the latest version of the Azure ClientRuntime.

src/ResourceManager/Reservations/Commands.Reservations/Cmdlets/GetCatalog.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class GetCatalog : AzureReservationsCmdletBase
1717
public Guid SubscriptionId { get; set; }
1818

1919
[Parameter(Mandatory = true)]
20-
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux")]
20+
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb")]
2121
[ValidateNotNullOrEmpty]
2222
public string ReservedResourceType { get; set; }
2323

src/ResourceManager/Reservations/Commands.Reservations/Cmdlets/PatchReservation.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ public class PatchReservation : AzureReservationsCmdletBase
4949
[ValidateNotNull]
5050
public PSReservation Reservation { get; set; }
5151

52+
[Parameter(Mandatory = false, HelpMessage = "Name of Reservation")]
53+
[ValidateNotNull]
54+
public string Name { get; set; }
55+
5256
public override void ExecuteCmdlet()
5357
{
5458
if (ParameterSetName.Equals(Constants.ParameterSetNames.ObjectParameterSet))
@@ -68,11 +72,11 @@ public override void ExecuteCmdlet()
6872
string subscriptionId = ValidateAndGetAppliedSubscription();
6973
PreRegister(subscriptionId);
7074

71-
Patch = new Patch(AppliedScopeType, new List<string>() { AppliedScope }, InstanceFlexibility);
75+
Patch = new Patch(AppliedScopeType, new List<string>() { AppliedScope }, InstanceFlexibility, Name);
7276
}
7377
else
7478
{
75-
Patch = new Patch(AppliedScopeType, instanceFlexibility: InstanceFlexibility);
79+
Patch = new Patch(AppliedScopeType, instanceFlexibility: InstanceFlexibility, name: Name);
7680
}
7781
var response = new PSReservation(AzureReservationAPIClient.Reservation.Update(ReservationOrderId.ToString(), ReservationId.ToString(), Patch));
7882
WriteObject(response);

src/ResourceManager/Reservations/Commands.Reservations/Commands.Reservations.Netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</PropertyGroup>
2929

3030
<ItemGroup>
31-
<PackageReference Include="Microsoft.Azure.Management.Reservations" Version="1.8.0-preview" />
31+
<PackageReference Include="Microsoft.Azure.Management.Reservations" Version="1.9.0-preview" />
3232
</ItemGroup>
3333

3434
<ItemGroup>

src/ResourceManager/Reservations/Commands.Reservations/Commands.Reservations.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</PropertyGroup>
3838
<ItemGroup>
3939
<Reference Include="Microsoft.Azure.Management.Reservations">
40-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Reservations.1.8.0-preview\lib\net452\Microsoft.Azure.Management.Reservations.dll</HintPath>
40+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Reservations.1.9.0-preview\lib\net452\Microsoft.Azure.Management.Reservations.dll</HintPath>
4141
</Reference>
4242
<Reference Include="System" />
4343
<Reference Include="System.Configuration.Install" />

src/ResourceManager/Reservations/Commands.Reservations/help/Update-AzureRmReservation.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ Update a `Reservation`.
1515
### CommandLine (Default)
1616
```
1717
Update-AzureRmReservation -ReservationOrderId <Guid> -ReservationId <Guid> -AppliedScopeType <String>
18-
[-AppliedScope <String>] [-InstanceFlexibility <String>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
19-
[-Confirm] [<CommonParameters>]
18+
[-AppliedScope <String>] [-InstanceFlexibility <String>] [-Name <String>]
19+
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2020
```
2121

2222
### PipeObject
2323
```
2424
Update-AzureRmReservation -AppliedScopeType <String> [-AppliedScope <String>] [-InstanceFlexibility <String>]
25-
-Reservation <PSReservation> [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
25+
-Reservation <PSReservation> [-Name <String>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
2626
[<CommonParameters>]
2727
```
2828

@@ -107,6 +107,21 @@ Accept pipeline input: False
107107
Accept wildcard characters: False
108108
```
109109

110+
### -Name
111+
Name of Reservation
112+
113+
```yaml
114+
Type: System.String
115+
Parameter Sets: (All)
116+
Aliases:
117+
118+
Required: False
119+
Position: Named
120+
Default value: None
121+
Accept pipeline input: False
122+
Accept wildcard characters: False
123+
```
124+
110125
### -Reservation
111126
Pipe object parameter for `Reservation`
112127

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="Microsoft.Azure.Management.Reservations" version="1.8.0-preview" targetFramework="net452" />
3+
<package id="Microsoft.Azure.Management.Reservations" version="1.9.0-preview" targetFramework="net452" />
44
</packages>

0 commit comments

Comments
 (0)