Fix for bug "Change filter param from status to ProtectionState in get-item cmdlet"

Author: dragonfly91

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/AzureVmModels/AzureRmRecoveryServicesAzureVmItem.cs

@@ -36,7 +36,7 @@ public class AzureRmRecoveryServicesBackupIaasVmItem : AzureRmRecoveryServicesBa
         /// <summary>
         /// Protection State of the item
         /// </summary>
-        public ItemStatus ProtectionState { get; set; }
+        public ItemProtectionState ProtectionState { get; set; }
 
         /// <summary>
         /// Last Backup Status for the item
@@ -60,7 +60,7 @@ public AzureRmRecoveryServicesBackupIaasVmItem(ProtectedItemResource protectedIt
             AzureIaaSVMProtectedItem protectedItem = (AzureIaaSVMProtectedItem)protectedItemResource.Properties;
             LastBackupStatus = protectedItem.LastBackupStatus;
             ProtectionPolicyName = policyName;
-            ProtectionState = EnumUtils.GetEnum<ItemStatus>(protectedItem.ProtectionState);
+            ProtectionState = EnumUtils.GetEnum<ItemProtectionState>(protectedItem.ProtectionState);
             ProtectionStatus = EnumUtils.GetEnum<ItemProtectionStatus>(protectedItem.ProtectionStatus);
             VirtualMachineId = protectedItem.VirtualMachineId;
         }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/CmdletParamEnums.cs

@@ -71,7 +71,7 @@ public enum ItemParams
         ParameterSetName,
         Container,
         ProtectionStatus,
-        Status,
+        ProtectionState,
         DeleteBackupData,
         ExpiryDate,
     }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/CommonModels/Enums.cs

@@ -72,7 +72,7 @@ public enum ItemProtectionStatus
         Unhealthy,
     }
 
-    public enum ItemStatus
+    public enum ItemProtectionState
     {
         IRPending = 1,
         ProtectionError,

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs

@@ -162,7 +162,7 @@ public BaseRecoveryServicesJobResponse DisableProtection()
                 }
 
                 properties.PolicyId = string.Empty;
-                properties.ProtectionState = ItemStatus.ProtectionStopped.ToString();
+                properties.ProtectionState = ItemProtectionState.ProtectionStopped.ToString();
 
                 ProtectedItemCreateOrUpdateRequest hydraRequest = new ProtectedItemCreateOrUpdateRequest()
                 {
@@ -418,7 +418,7 @@ public List<AzureRmRecoveryServicesBackupItemBase> ListProtectedItems()
             string name = (string)this.ProviderData.ProviderParameters[ItemParams.AzureVMName];
             ItemProtectionStatus protectionStatus =
                 (ItemProtectionStatus)this.ProviderData.ProviderParameters[ItemParams.ProtectionStatus];
-            ItemStatus status = (ItemStatus)this.ProviderData.ProviderParameters[ItemParams.Status];
+            ItemProtectionState status = (ItemProtectionState)this.ProviderData.ProviderParameters[ItemParams.ProtectionState];
             Models.WorkloadType workloadType =
                 (Models.WorkloadType)this.ProviderData.ProviderParameters[ItemParams.WorkloadType];
 

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1

@@ -37,23 +37,23 @@ function Test-GetItemScenario
 	Assert-AreEqual $item.Name "iaasvmcontainerv2;mkheranirmvm1;mkheranirmvm1";
 
 	# VAR-4: Get items for container with Status filter
-	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Status "IRPending";
+	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -ProtectionState "IRPending";
 	Assert-AreEqual $item.Name "iaasvmcontainerv2;mkheranirmvm1;mkheranirmvm1";
 
 	# VAR-5: Get items for container with friendly name and ProtectionStatus filters
 	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Name "mkheraniRMVM1" -ProtectionStatus "Healthy";
 	Assert-AreEqual $item.Name "iaasvmcontainerv2;mkheranirmvm1;mkheranirmvm1";
 
 	# VAR-6: Get items for container with friendly name and Status filters
-	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Name "mkheraniRMVM1" -Status "IRPending";
+	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Name "mkheraniRMVM1" -ProtectionState "IRPending";
 	Assert-AreEqual $item.Name "iaasvmcontainerv2;mkheranirmvm1;mkheranirmvm1";
 
 	# VAR-7: Get items for container with Status and ProtectionStatus filters
-	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Status "IRPending" -ProtectionStatus "Healthy";
+	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -ProtectionState "IRPending" -ProtectionStatus "Healthy";
 	Assert-AreEqual $item.Name "iaasvmcontainerv2;mkheranirmvm1;mkheranirmvm1";
 
 	# VAR-8: Get items for container with friendly name, Status and ProtectionStatus filters
-	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Name "mkheraniRMVM1" -Status "IRPending" -ProtectionStatus "Healthy";
+	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM" -Name "mkheraniRMVM1" -ProtectionState "IRPending" -ProtectionStatus "Healthy";
 	Assert-AreEqual $item.Name "iaasvmcontainerv2;mkheranirmvm1;mkheranirmvm1";
 }
 

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup/Cmdlets/Item/GetAzureRmRecoveryServicesItem.cs

@@ -43,7 +43,7 @@ public class GetAzureRmRecoveryServicesBackupItem : RecoveryServicesBackupCmdlet
 
         [Parameter(Mandatory = false, HelpMessage = ParamHelpMsg.Item.Status)]
         [ValidateNotNullOrEmpty]
-        public ItemStatus Status { get; set; }
+        public ItemProtectionState ProtectionState { get; set; }
 
         [Parameter(Mandatory = true, HelpMessage = ParamHelpMsg.Common.WorkloadType)]
         [ValidateNotNullOrEmpty]
@@ -60,7 +60,7 @@ public override void ExecuteCmdlet()
                     {ItemParams.Container, Container},
                     {ItemParams.AzureVMName, Name},
                     {ItemParams.ProtectionStatus, ProtectionStatus},
-                    {ItemParams.Status, Status},
+                    {ItemParams.ProtectionState, ProtectionState},
                     {ItemParams.WorkloadType, WorkloadType},
                 }, HydraAdapter);