Skip to content

Commit cce228d

Browse files
authored
Merge pull request #9028 from MabOneSdk/sqlRestoreFix
[RecoveryServices] Made some attributes read only for get restore config cmdlet
2 parents ed669a0 + 9d0c4de commit cce228d

File tree

6 files changed

+126253
-135764
lines changed

6 files changed

+126253
-135764
lines changed

src/RecoveryServices/RecoveryServices.Backup.Models/AzureVmWorkloadModels/AzureWorkloadRecoveryConfig.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
// ----------------------------------------------------------------------------------
1414

1515
using Microsoft.Azure.Management.RecoveryServices.Backup.Models;
16+
using System;
1617
using System.Collections.Generic;
1718

1819
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models
@@ -25,12 +26,12 @@ public class AzureWorkloadRecoveryConfig : RecoveryConfigBase
2526
/// <summary>
2627
/// Target Server
2728
/// </summary>
28-
public string TargetServer { get; set; }
29+
public string TargetServer { get; }
2930

3031
/// <summary>
3132
/// Target Instance
3233
/// </summary>
33-
public string TargetInstance { get; set; }
34+
public string TargetInstance { get; }
3435

3536
/// <summary>
3637
/// Restored DB Name
@@ -54,8 +55,12 @@ public class AzureWorkloadRecoveryConfig : RecoveryConfigBase
5455

5556
public string ContainerId { get; set; }
5657

57-
public AzureWorkloadRecoveryConfig()
58+
public AzureWorkloadRecoveryConfig(string targetServer, string targetInstance, string restoreRequestType,
59+
RecoveryPointBase recoveryPoint, DateTime pointInTime)
60+
: base(restoreRequestType, recoveryPoint, pointInTime)
5861
{
62+
TargetServer = targetServer;
63+
TargetInstance = targetInstance;
5964
}
6065
}
6166
}

src/RecoveryServices/RecoveryServices.Backup.Models/BaseObjects.cs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -492,16 +492,23 @@ public class RecoveryConfigBase
492492
/// <summary>
493493
/// Original WL Restore, Alternate WL restore, Alternate WL restore to diff item.
494494
/// </summary>
495-
public string RestoreRequestType { get; set; }
495+
public string RestoreRequestType { get; }
496496

497497
/// <summary>
498498
/// Recovery point for full/differential backup.
499499
/// </summary>
500-
public RecoveryPointBase RecoveryPoint { get; set; }
500+
public RecoveryPointBase RecoveryPoint { get; }
501501

502502
/// <summary>
503503
/// PointInTime for Log backup.
504504
/// </summary>
505-
public DateTime PointInTime { get; set; }
505+
public DateTime PointInTime { get; }
506+
507+
public RecoveryConfigBase(string restoreRequestType, RecoveryPointBase recoveryPoint, DateTime pointInTime)
508+
{
509+
RestoreRequestType = restoreRequestType;
510+
RecoveryPoint = recoveryPoint;
511+
PointInTime = pointInTime;
512+
}
506513
}
507514
}

src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureWorkloadPsBackupProvider.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ public RestAzureNS.AzureOperationResponse TriggerRestore()
391391
{
392392
OverwriteOption = string.Compare(wLRecoveryConfig.OverwriteWLIfpresent, "No") == 0 ?
393393
OverwriteOptions.FailOnConflict : OverwriteOptions.Overwrite,
394-
DatabaseName = wLRecoveryConfig.RestoredDBName,
394+
DatabaseName = wLRecoveryConfig.TargetInstance + "/" + wLRecoveryConfig.RestoredDBName,
395395
ContainerId = wLRecoveryConfig.ContainerId
396396
};
397397
azureWorkloadSQLRestoreRequest.AlternateDirectoryPaths = wLRecoveryConfig.targetPhysicalPath;
@@ -417,7 +417,7 @@ public RestAzureNS.AzureOperationResponse TriggerRestore()
417417
{
418418
OverwriteOption = string.Compare(wLRecoveryConfig.OverwriteWLIfpresent, "No") == 0 ?
419419
OverwriteOptions.FailOnConflict : OverwriteOptions.Overwrite,
420-
DatabaseName = wLRecoveryConfig.RestoredDBName,
420+
DatabaseName = wLRecoveryConfig.TargetInstance + "/" + wLRecoveryConfig.RestoredDBName,
421421
ContainerId = wLRecoveryConfig.ContainerId
422422
};
423423
azureWorkloadSQLPointInTimeRestoreRequest.AlternateDirectoryPaths = wLRecoveryConfig.targetPhysicalPath;

0 commit comments

Comments
 (0)