Skip to content

Commit cfcb178

Browse files
author
maddieclayton
committed
more tests
1 parent 223c09f commit cfcb178

File tree

12 files changed

+3468
-2159
lines changed

12 files changed

+3468
-2159
lines changed

‎src/ResourceManager/KeyVault/Commands.KeyVault.Test/Commands.KeyVault.Test.csproj

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -212,25 +212,10 @@
212212
<None Include="Scripts\VaultManagementTests.ps1" />
213213
<None Include="Scripts\VaultSecretTests.ps1" />
214214
<None Include="Scripts\VaultUITests.ps1" />
215-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestCreateDeleteVaultWithPiping.json">
216-
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
217-
</None>
218-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestCreateNewPremiumVaultEnabledForDeployment.json">
219-
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
220-
</None>
221215
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestCreateNewVault.json">
222216
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
223217
</None>
224-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestCreateVaultInUnknownResGrpFails.json">
225-
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
226-
</None>
227-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestCreateVaultPositionalParams.json">
228-
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
229-
</None>
230-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestDeleteUnknownVaultFails.json">
231-
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
232-
</None>
233-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestDeleteVaultByName.json">
218+
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestDeleteVault.json">
234219
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
235220
</None>
236221
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestGetVault.json">
@@ -251,9 +236,6 @@
251236
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestModifyAccessPolicyEnabledForTemplateDeployment.json">
252237
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
253238
</None>
254-
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestRecreateVaultFails.json">
255-
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
256-
</None>
257239
<None Include="SessionRecords\Microsoft.Azure.Commands.KeyVault.Test.ScenarioTests.KeyVaultManagementTests\TestRemoveAccessPolicyWithCompoundIdPolicies.json">
258240
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
259241
</None>

‎src/ResourceManager/KeyVault/Commands.KeyVault.Test/ScenarioTests/KeyVaultManagementTests.cs

Lines changed: 2 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -70,60 +70,6 @@ public void TestCreateNewVault()
7070
);
7171
}
7272

73-
[Fact(Skip = "Graph authentication blocks test passes")]
74-
[Trait(Category.AcceptanceType, Category.CheckIn)]
75-
public void TestCreateNewPremiumVaultEnabledForDeployment()
76-
{
77-
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
78-
() => { return new[] { string.Format("{0} {1} {2}", "Test-CreateNewPremiumVaultEnabledForDeployment", _data.resourceGroupName, _data.location) }; },
79-
(env) => Initialize(),
80-
null,
81-
TestUtilities.GetCallingClass(),
82-
TestUtilities.GetCurrentMethodName()
83-
);
84-
}
85-
86-
[Fact]
87-
[Trait(Category.AcceptanceType, Category.CheckIn)]
88-
public void TestRecreateVaultFails()
89-
{
90-
91-
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
92-
() => { return new[] { string.Format("{0} {1} {2} {3}", "Test-RecreateVaultFails", _data.preCreatedVault, _data.resourceGroupName, _data.location) }; },
93-
(env) => Initialize(),
94-
null,
95-
TestUtilities.GetCallingClass(),
96-
TestUtilities.GetCurrentMethodName()
97-
);
98-
}
99-
100-
[Fact]
101-
[Trait(Category.AcceptanceType, Category.CheckIn)]
102-
public void TestCreateVaultInUnknownResGrpFails()
103-
{
104-
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
105-
() => { return new[] { string.Format("{0} {1}", "Test-CreateVaultInUnknownResGrpFails", _data.location) }; },
106-
(env) => Initialize(),
107-
null,
108-
TestUtilities.GetCallingClass(),
109-
TestUtilities.GetCurrentMethodName()
110-
);
111-
}
112-
113-
[Fact(Skip = "Graph authentication blocks test passes")]
114-
[Trait(Category.AcceptanceType, Category.CheckIn)]
115-
public void TestCreateVaultPositionalParams()
116-
{
117-
118-
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
119-
() => { return new[] { string.Format("{0} {1} {2}", "Test-CreateVaultPositionalParams", _data.resourceGroupName, _data.location) }; },
120-
(env) => Initialize(),
121-
null,
122-
TestUtilities.GetCallingClass(),
123-
TestUtilities.GetCurrentMethodName()
124-
);
125-
}
126-
12773
#endregion
12874

12975
#region Get-AzureRmKeyVault
@@ -163,25 +109,12 @@ public void TestListVaults()
163109

164110
#region Remove-AzureRmKeyVault
165111

166-
[Fact(Skip = "Graph authentication blocks test passes")]
167-
[Trait(Category.AcceptanceType, Category.CheckIn)]
168-
public void TestDeleteVaultByName()
169-
{
170-
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
171-
() => { return new[] { string.Format("{0} {1} {2}", "Test-DeleteVaultByName", _data.resourceGroupName, _data.location) }; },
172-
(env) => Initialize(),
173-
null,
174-
TestUtilities.GetCallingClass(),
175-
TestUtilities.GetCurrentMethodName()
176-
);
177-
}
178-
179112
[Fact]
180113
[Trait(Category.AcceptanceType, Category.CheckIn)]
181-
public void TestDeleteUnknownVaultFails()
114+
public void TestDeleteVault()
182115
{
183116
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
184-
() => { return new[] { string.Format("{0} ", "Test-DeleteUnknownVaultFails") }; },
117+
() => { return new[] { string.Format("{0} {1} {2}", "Test-DeleteVaultByName", _data.resourceGroupName, _data.location) }; },
185118
(env) => Initialize(),
186119
null,
187120
TestUtilities.GetCallingClass(),
@@ -508,22 +441,6 @@ public void TestRemoveNonExistentAccessPolicyDoesNotThrow()
508441

509442
#endregion
510443

511-
#region Piping
512-
[Fact(Skip = "Graph authentication blocks test passes")]
513-
[Trait(Category.AcceptanceType, Category.CheckIn)]
514-
public void TestCreateDeleteVaultWithPiping()
515-
{
516-
KeyVaultManagementController.NewInstance.RunPsTestWorkflow(
517-
() => { return new[] { string.Format("{0} {1} {2}", "Test-CreateDeleteVaultWithPiping", _data.resourceGroupName, _data.location) }; },
518-
(env) => Initialize(),
519-
null,
520-
TestUtilities.GetCallingClass(),
521-
TestUtilities.GetCurrentMethodName()
522-
);
523-
}
524-
525-
#endregion
526-
527444
#region Helper Methods
528445
private string GetUser(TestEnvironment environment)
529446
{

0 commit comments

Comments
 (0)