Skip to content

Commit d2d10fa

Browse files
unknownunknown
authored andcommitted
WORK:3387747 Code review comments incorporation
1 parent 68d1283 commit d2d10fa

25 files changed

+76
-76
lines changed

src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureLocalNetworkGateway.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ public class GetAzureLocalNetworkGateway : NetworkCmdletBase
2323
[Parameter(Position = 0, Mandatory = false, HelpMessage = "Local network gateway Id.")]
2424
[ValidateGuid]
2525
[ValidateNotNullOrEmpty]
26-
public string gatewayId
26+
public string GatewayId
2727
{
2828
get;
2929
set;
3030
}
3131

3232
public override void ExecuteCmdlet()
3333
{
34-
if (!string.IsNullOrEmpty(gatewayId))
34+
if (!string.IsNullOrEmpty(GatewayId))
3535
{
36-
WriteObject(Client.GetLocalNetworkGateway(gatewayId));
36+
WriteObject(Client.GetLocalNetworkGateway(GatewayId));
3737
}
3838
else
3939
{

src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureVirtualNetworkGateway.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ public class GetAzureVirtualNetworkGateway : NetworkCmdletBase
2323
[Parameter(Position = 0, Mandatory = false, HelpMessage = "Virtual network gateway Id.")]
2424
[ValidateGuid]
2525
[ValidateNotNullOrEmpty]
26-
public string gatewayId
26+
public string GatewayId
2727
{
2828
get;
2929
set;
3030
}
3131

3232
public override void ExecuteCmdlet()
3333
{
34-
if (!string.IsNullOrEmpty(gatewayId))
34+
if (!string.IsNullOrEmpty(GatewayId))
3535
{
36-
WriteObject(Client.GetVirtualNetworkGateway(gatewayId));
36+
WriteObject(Client.GetVirtualNetworkGateway(GatewayId));
3737
}
3838
else
3939
{

src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureVirtualNetworkGatewayConnection.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class GetAzureVirtualNetworkConnectionGateway : NetworkCmdletBase
2323
[Parameter(Position = 0, Mandatory = false, HelpMessage = "Virtual network gateway Id.")]
2424
[ValidateGuid]
2525
[ValidateNotNullOrEmpty]
26-
public string gatewayId
26+
public string GatewayId
2727
{
2828
get;
2929
set;
@@ -32,17 +32,17 @@ public string gatewayId
3232
[Parameter(Position = 1, Mandatory = false, HelpMessage = "Virtual network gateway Connected entityId.")]
3333
[ValidateGuid]
3434
[ValidateNotNullOrEmpty]
35-
public string connectedentityId
35+
public string ConnectedEntityId
3636
{
3737
get;
3838
set;
3939
}
4040

4141
public override void ExecuteCmdlet()
4242
{
43-
if (!string.IsNullOrEmpty(gatewayId) && !string.IsNullOrEmpty(connectedentityId))
43+
if (!string.IsNullOrEmpty(GatewayId) && !string.IsNullOrEmpty(ConnectedEntityId))
4444
{
45-
WriteObject(Client.GetVirtualNetworkGatewayConnection(gatewayId, connectedentityId));
45+
WriteObject(Client.GetVirtualNetworkGatewayConnection(GatewayId, ConnectedEntityId));
4646
}
4747
else
4848
{

src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureVirtualNetworkGatewayDiagnosticsV2.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ public class GetAzureVirtualNetworkGatewayDiagnosticsV2 : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "The virtual network gateway id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get;
3030
set;
3131
}
3232

3333
public override void ExecuteCmdlet()
3434
{
35-
WriteObject(Client.GetDiagnosticsV2(gatewayId));
35+
WriteObject(Client.GetDiagnosticsV2(GatewayId));
3636
}
3737
}
3838
}

src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureVirtualNetworkGatewayIPsecParametersV2.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class GetAzureVirtualNetworkGatewayIPsecParametersV2 : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "The virtual network gateway id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get;
3030
set;
@@ -33,15 +33,15 @@ public string gatewayId
3333
[Parameter(Position = 1, Mandatory = true, HelpMessage = "The virtual network gateway connected entityId.")]
3434
[ValidateGuid]
3535
[ValidateNotNullOrEmpty]
36-
public string connectedentityId
36+
public string ConnectedEntityId
3737
{
3838
get;
3939
set;
4040
}
4141

4242
public override void ExecuteCmdlet()
4343
{
44-
WriteObject(Client.GetIPsecParametersV2(gatewayId, connectedentityId));
44+
WriteObject(Client.GetIPsecParametersV2(GatewayId, ConnectedEntityId));
4545
}
4646
}
4747
}

src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureVirtualNetworkGatewayKeyV2.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class GetAzureVirtualNetworkGatewayKeyV2 : NetworkCmdletBase
2323
[Parameter(Position = 0, Mandatory = true, HelpMessage = "The virtual network gateway id.")]
2424
[ValidateGuid]
2525
[ValidateNotNullOrEmpty]
26-
public string gatewayId
26+
public string GatewayId
2727
{
2828
get;
2929
set;
@@ -32,15 +32,15 @@ public string gatewayId
3232
[Parameter(Position = 1, Mandatory = true, HelpMessage = "The virtual network gateway connected entityId.")]
3333
[ValidateGuid]
3434
[ValidateNotNullOrEmpty]
35-
public string connectedentityId
35+
public string ConnectedEntityId
3636
{
3737
get;
3838
set;
3939
}
4040

4141
public override void ExecuteCmdlet()
4242
{
43-
WriteObject(Client.GetSharedKeyV2(gatewayId, connectedentityId));
43+
WriteObject(Client.GetSharedKeyV2(GatewayId, ConnectedEntityId));
4444
}
4545
}
4646
}

src/ServiceManagement/Network/Commands.Network/Gateway/Model/GetLocalNetworkGatewayContext.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
16+
using System;
17+
using System.Collections.Generic;
18+
1519
namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Network
1620
{
17-
using System;
18-
using System.Collections.Generic;
19-
using WindowsAzure.Commands.Utilities.Common;
20-
2121
public class GetLocalNetworkGatewayContext : ManagementOperationContext
2222
{
2323
public string GatewayId { get; set; }

src/ServiceManagement/Network/Commands.Network/Gateway/Model/GetVirtualNetworkGatewayConnectionContext.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
16+
using Microsoft.WindowsAzure.Management.Network.Models;
17+
using System;
18+
1519
namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Network
1620
{
17-
using Microsoft.WindowsAzure.Management.Network.Models;
18-
using System;
19-
using WindowsAzure.Commands.Utilities.Common;
20-
2121
public class GetVirtualNetworkGatewayConnectionContext : ManagementOperationContext
2222
{
2323
public string GatewayConnectionName { get; set; }

src/ServiceManagement/Network/Commands.Network/Gateway/Model/GetVirtualNetworkGatewayContext.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
16+
using System;
17+
1518
namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Network
1619
{
17-
using System;
18-
using WindowsAzure.Commands.Utilities.Common;
19-
2020
public class GetVirtualNetworkGatewayContext : ManagementOperationContext
2121
{
2222
public string GatewayId { get; set; }

src/ServiceManagement/Network/Commands.Network/Gateway/Model/LocalNetwrokGatewayContext.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
16+
1517
namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Gateway.Model
1618
{
17-
using WindowsAzure.Commands.Utilities.Common;
18-
1919
public class LocalNetwrokGatewayContext : ManagementOperationContext
2020
{
2121
public string LocalNetworkGatewayId { get; set; }

src/ServiceManagement/Network/Commands.Network/Gateway/Model/VirtualNetworkDiagnosticsContext.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
16+
using Microsoft.WindowsAzure.Management.Network.Models;
17+
1518
namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Gateway.Model
1619
{
17-
using WindowsAzure.Commands.Utilities.Common;
18-
using WindowsAzure.Management.Network.Models;
19-
2020
public class VirtualNetworkDiagnosticsContext : ManagementOperationContext
2121
{
2222
public string DiagnosticsUrl { get; set; }

src/ServiceManagement/Network/Commands.Network/Gateway/Model/VirtualNetworkGatewayContext.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.WindowsAzure.Commands.Utilities.Common;
16+
using System;
17+
1518
namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Network
1619
{
17-
using System;
18-
using WindowsAzure.Commands.Utilities.Common;
19-
2020
public class VirtualNetworkGatewayContext : ManagementOperationContext
2121
{
2222
public string LastEventData { get; set; }

src/ServiceManagement/Network/Commands.Network/Gateway/NewAzureVirtualNetworkGatewayConnection.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,30 +26,30 @@ public class NewAzureVirtualNetworkGatewayConnectionCommand : NetworkCmdletBase
2626
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Service Key / Local network gateway Id / Vnet Network Gateway Id")]
2727
[ValidateGuid]
2828
[ValidateNotNullOrEmpty]
29-
public string connectedEntityId { get; set; }
29+
public string ConnectedEntityId { get; set; }
3030

3131
[Parameter(Position = 1, Mandatory = true, HelpMessage = "The virtual network gateway connection name.")]
3232
[ValidateNotNullOrEmpty]
33-
public string gatewayConnectionName { get; set; }
33+
public string GatewayConnectionName { get; set; }
3434

3535
[Parameter(Position = 2, Mandatory = true, HelpMessage = "Gateway connection type: Ipsec/Dedicated/VpnClient/Vnet2Vnet")]
3636
[ValidateNotNullOrEmpty]
37-
public string gatewayConnectionType { get; set; }
37+
public string GatewayConnectionType { get; set; }
3838

3939
[Parameter(Position = 3, Mandatory = false, HelpMessage = "The Routing Weight.")]
40-
public int routingWeight { get; set; }
40+
public int RoutingWeight { get; set; }
4141

4242
[Parameter(Position = 4, Mandatory = false, HelpMessage = "Ipsec share key.")]
43-
public string sharedKey { get; set; }
43+
public string SharedKey { get; set; }
4444

4545
[Parameter(Position = 5, Mandatory = true, HelpMessage = "Virtual network gateway Id.")]
4646
[ValidateGuid]
4747
[ValidateNotNullOrEmpty]
48-
public string virtualNetworkGatewayId { get; set; }
48+
public string VirtualNetworkGatewayId { get; set; }
4949

5050
public override void ExecuteCmdlet()
5151
{
52-
WriteObject(Client.CreateVirtualNetworkGatewayConnection(connectedEntityId, gatewayConnectionName, gatewayConnectionType, routingWeight, sharedKey, Guid.Parse(virtualNetworkGatewayId)));
52+
WriteObject(Client.CreateVirtualNetworkGatewayConnection(ConnectedEntityId, GatewayConnectionName, GatewayConnectionType, RoutingWeight, SharedKey, Guid.Parse(VirtualNetworkGatewayId)));
5353
}
5454
}
5555
}

src/ServiceManagement/Network/Commands.Network/Gateway/RemoveAzureLocalNetworkGateway.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ public class RemoveAzureLocalNetworkGateway : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Local network gateway Id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get;
3030
set;
3131
}
3232

3333
public override void ExecuteCmdlet()
3434
{
35-
WriteObject(Client.DeleteLocalNetworkGateway(gatewayId));
35+
WriteObject(Client.DeleteLocalNetworkGateway(GatewayId));
3636
}
3737
}
3838
}

src/ServiceManagement/Network/Commands.Network/Gateway/RemoveAzureVirtualNetworkGateway.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ public class RemoveAzureVirtualNetworkGateway : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Virtual network gateway Id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get;
3030
set;
3131
}
3232

3333
public override void ExecuteCmdlet()
3434
{
35-
WriteObject(Client.DeleteVirtualNetworkGateway(gatewayId));
35+
WriteObject(Client.DeleteVirtualNetworkGateway(GatewayId));
3636
}
3737
}
3838
}

src/ServiceManagement/Network/Commands.Network/Gateway/RemoveAzureVirtualNetworkGatewayConnection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class RemoveAzureVirtualNetworkGatewayConnection : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Virtual network gateway Id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get;
3030
set;
@@ -33,15 +33,15 @@ public string gatewayId
3333
[Parameter(Position = 1, Mandatory = true, HelpMessage = "Virtual network gateway connected EntityId.")]
3434
[ValidateGuid]
3535
[ValidateNotNullOrEmpty]
36-
public string connectedEntityId
36+
public string ConnectedEntityId
3737
{
3838
get;
3939
set;
4040
}
4141

4242
public override void ExecuteCmdlet()
4343
{
44-
WriteObject(Client.DeleteVirtualNetworkGatewayConnection(gatewayId, connectedEntityId));
44+
WriteObject(Client.DeleteVirtualNetworkGatewayConnection(GatewayId, ConnectedEntityId));
4545
}
4646
}
4747
}

src/ServiceManagement/Network/Commands.Network/Gateway/ResetAzureVirtualNetworkGateway.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ public class ResetAzureVirtualNetworkGateway : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Virtual network gateway Id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get; set;
3030
}
3131

3232
public override void ExecuteCmdlet()
3333
{
34-
WriteObject(Client.ResetVirtualNetworkGateway(gatewayId));
34+
WriteObject(Client.ResetVirtualNetworkGateway(GatewayId));
3535
}
3636
}
3737
}

src/ServiceManagement/Network/Commands.Network/Gateway/ResetAzureVirtualNetworkGatewayKeyV2.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class ResetAzureVirtualNetworkGatewayKeyV2 : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Virtual network gateway Id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get;
3030
set;
@@ -33,7 +33,7 @@ public string gatewayId
3333
[Parameter(Position = 1, Mandatory = true, HelpMessage = "The virtual network gateway connected entityId.")]
3434
[ValidateGuid]
3535
[ValidateNotNullOrEmpty]
36-
public string connectedentityId
36+
public string ConnectedEntityId
3737
{
3838
get;
3939
set;
@@ -50,7 +50,7 @@ public int keyLength
5050

5151
public override void ExecuteCmdlet()
5252
{
53-
WriteObject(Client.ResetSharedKeyV2(gatewayId, connectedentityId, keyLength));
53+
WriteObject(Client.ResetSharedKeyV2(GatewayId, ConnectedEntityId, keyLength));
5454
}
5555
}
5656
}

src/ServiceManagement/Network/Commands.Network/Gateway/ResizeAzureVirtualNetworkGateway.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class ResizeAzureVirtualNetworkGateway : NetworkCmdletBase
2424
[Parameter(Position = 0, Mandatory = true, HelpMessage = "Virtual network gateway Id.")]
2525
[ValidateGuid]
2626
[ValidateNotNullOrEmpty]
27-
public string gatewayId
27+
public string GatewayId
2828
{
2929
get; set;
3030
}
@@ -38,7 +38,7 @@ public string GatewaySKU
3838

3939
public override void ExecuteCmdlet()
4040
{
41-
WriteObject(Client.ResizeVirtualNetworkGateway(gatewayId, GatewaySKU));
41+
WriteObject(Client.ResizeVirtualNetworkGateway(GatewayId, GatewaySKU));
4242
}
4343
}
4444
}

0 commit comments

Comments
 (0)