Skip to content

Commit d9d94d7

Browse files
authored
[Storage] Support AllowBlobPublicAccess, MinimumTlsVersion (#12252)
1 parent fdb706a commit d9d94d7

File tree

15 files changed

+1209
-14
lines changed

15 files changed

+1209
-14
lines changed

src/ApplicationInsights/ApplicationInsights.Test/ApplicationInsights.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<ItemGroup>
1414
<PackageReference Include="Microsoft.Azure.Management.ApplicationInsights" Version="0.3.0-preview" />
15-
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.0.0" />
15+
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.1.0" />
1616
</ItemGroup>
1717

1818
</Project>

src/EventGrid/EventGrid.Test/EventGrid.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<PackageReference Include="Microsoft.Azure.Management.EventHub" Version="2.7.0" />
1616
<PackageReference Include="Microsoft.Azure.Management.Relay" Version="2.0.2" />
1717
<PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="2.1.0" />
18-
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.0.0" />
18+
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.1.0" />
1919
</ItemGroup>
2020

2121
</Project>

src/OperationalInsights/OperationalInsights.Test/OperationalInsights.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<ItemGroup>
1414
<PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.21.0-preview" />
1515
<PackageReference Include="Microsoft.Azure.OperationalInsights" Version="0.10.0-preview" />
16-
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.0.0" />
16+
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="17.1.0" />
1717
</ItemGroup>
1818

1919
</Project>

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,5 +204,12 @@ public void TestNewSetAzureStorageAccountRAGZRS()
204204
{
205205
TestRunner.RunTestScript("Test-NewSetAzureStorageAccount_RAGZRS");
206206
}
207+
208+
[Fact]
209+
[Trait(Category.AcceptanceType, Category.CheckIn)]
210+
public void TestNewSetAzureStorageAccountTLSveresionBlobPublicAccess()
211+
{
212+
TestRunner.RunTestScript("Test-NewSetAzureStorageAccountTLSveresionBlobPublicAccess");
213+
}
207214
}
208215
}

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.ps1

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,4 +1334,59 @@ function Test-NewSetAzureStorageAccount_RAGZRS
13341334
# Cleanup
13351335
Clean-ResourceGroup $rgname
13361336
}
1337+
}
1338+
1339+
1340+
1341+
<#
1342+
.SYNOPSIS
1343+
Test Test-NewAzureStorageAccount_TLSveresionBlobPublicAccess
1344+
.DESCRIPTION
1345+
SmokeTest
1346+
#>
1347+
function Test-NewSetAzureStorageAccountTLSveresionBlobPublicAccess
1348+
{
1349+
# Setup
1350+
$rgname = Get-StorageManagementTestResourceName;
1351+
1352+
try
1353+
{
1354+
# Test
1355+
$stoname = 'sto' + $rgname;
1356+
$stotype = 'Standard_LRS';
1357+
$loc = Get-ProviderLocation_Canary ResourceManagement;
1358+
$kind = 'StorageV2'
1359+
$tlsVersion = "TLS1_2"
1360+
1361+
New-AzResourceGroup -Name $rgname -Location $loc;
1362+
Write-Output ("Resource Group created")
1363+
1364+
New-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -SkuName $stotype -MinimumTlsVersion $tlsVersion -AllowBlobPublicAccess $false;
1365+
1366+
Retry-IfException { $global:sto = Get-AzStorageAccount -ResourceGroupName $rgname -Name $stoname; }
1367+
Assert-AreEqual $stoname $sto.StorageAccountName;
1368+
Assert-AreEqual $stotype $sto.Sku.Name;
1369+
Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
1370+
Assert-AreEqual $kind $sto.Kind;
1371+
Assert-AreEqual $tlsVersion $sto.MinimumTlsVersion
1372+
Assert-AreEqual $false $sto.AllowBlobPublicAccess
1373+
1374+
$tlsVersion = "TLS1_1"
1375+
Set-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -SkuName $stotype -MinimumTlsVersion $tlsVersion -AllowBlobPublicAccess $true ;
1376+
1377+
Retry-IfException { $global:sto = Get-AzStorageAccount -ResourceGroupName $rgname -Name $stoname; }
1378+
Assert-AreEqual $stoname $sto.StorageAccountName;
1379+
Assert-AreEqual $stotype $sto.Sku.Name;
1380+
Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
1381+
Assert-AreEqual $kind $sto.Kind;
1382+
Assert-AreEqual $tlsVersion $sto.MinimumTlsVersion
1383+
Assert-AreEqual $true $sto.AllowBlobPublicAccess
1384+
1385+
Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $stoname;
1386+
}
1387+
finally
1388+
{
1389+
# Cleanup
1390+
Clean-ResourceGroup $rgname
1391+
}
13371392
}

0 commit comments

Comments
 (0)