Skip to content

Commit de3e782

Browse files
author
begoldsm
committed
Add should process due to static analysis find.
1 parent 8142d9f commit de3e782

File tree

6 files changed

+122
-6
lines changed

6 files changed

+122
-6
lines changed

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/NewAzureRmDataLakeAnalyticsComputePolicy.cs

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
namespace Microsoft.Azure.Commands.DataLakeAnalytics
2424
{
25-
[Cmdlet(VerbsCommon.New, "AzureRmDataLakeAnalyticsComputePolicy"), OutputType(typeof(PSDataLakeAnalyticsComputePolicy))]
25+
[Cmdlet(VerbsCommon.New, "AzureRmDataLakeAnalyticsComputePolicy", SupportsShouldProcess = true), OutputType(typeof(PSDataLakeAnalyticsComputePolicy))]
2626
[Alias("New-AdlAnalyticsComputePolicy")]
2727
public class NewAzureDataLakeAnalyticsComputePolicy : DataLakeAnalyticsCmdletBase
2828
{
@@ -73,7 +73,24 @@ public override void ExecuteCmdlet()
7373
throw new ArgumentException(Resources.MissingComputePolicyField);
7474
}
7575

76-
WriteObject(this.DataLakeAnalyticsClient.CreateComputePolicy(ResourceGroupName, Account, Name, ObjectId, ObjectType, MaxDegreeOfParallelismPerJob, MinPriorityPerJob));
76+
ConfirmAction(
77+
string.Format(
78+
Resources.NewDataLakeComputePolicy,
79+
Name,
80+
MinPriorityPerJob.HasValue ? "\r\nMinPriorityPerJob: " + MinPriorityPerJob.Value : string.Empty,
81+
MaxDegreeOfParallelismPerJob.HasValue ? "\r\nMaxDegreeOfParallelismPerJob: " + MaxDegreeOfParallelismPerJob.Value : string.Empty),
82+
Name, () =>
83+
{
84+
WriteObject(
85+
this.DataLakeAnalyticsClient.CreateComputePolicy(
86+
ResourceGroupName,
87+
Account,
88+
Name,
89+
ObjectId,
90+
ObjectType,
91+
MaxDegreeOfParallelismPerJob,
92+
MinPriorityPerJob));
93+
});
7794
}
7895
}
7996
}

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/UpdateAzureRmDataLakeAnalyticsComputePolicy.cs

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
namespace Microsoft.Azure.Commands.DataLakeAnalytics
2424
{
25-
[Cmdlet(VerbsData.Update, "AzureRmDataLakeAnalyticsComputePolicy"), OutputType(typeof(PSDataLakeAnalyticsComputePolicy))]
25+
[Cmdlet(VerbsData.Update, "AzureRmDataLakeAnalyticsComputePolicy", SupportsShouldProcess = true), OutputType(typeof(PSDataLakeAnalyticsComputePolicy))]
2626
[Alias("Update-AdlAnalyticsComputePolicy")]
2727
public class UpdateAzureDataLakeAnalyticsComputePolicy : DataLakeAnalyticsCmdletBase
2828
{
@@ -62,7 +62,22 @@ public override void ExecuteCmdlet()
6262
throw new ArgumentException(Resources.MissingComputePolicyField);
6363
}
6464

65-
WriteObject(this.DataLakeAnalyticsClient.UpdateComputePolicy(ResourceGroupName, Account, Name, MaxDegreeOfParallelismPerJob, MinPriorityPerJob));
65+
ConfirmAction(
66+
string.Format(
67+
Resources.UpdateDataLakeComputePolicy,
68+
Name,
69+
MinPriorityPerJob.HasValue ? "\r\nMinPriorityPerJob: " + MinPriorityPerJob.Value : string.Empty,
70+
MaxDegreeOfParallelismPerJob.HasValue ? "\r\nMaxDegreeOfParallelismPerJob: " + MaxDegreeOfParallelismPerJob.Value : string.Empty),
71+
Name, () =>
72+
{
73+
WriteObject(
74+
this.DataLakeAnalyticsClient.UpdateComputePolicy(
75+
ResourceGroupName,
76+
Account,
77+
Name,
78+
MaxDegreeOfParallelismPerJob,
79+
MinPriorityPerJob));
80+
});
6681
}
6782
}
6883
}

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Properties/Resources.Designer.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Properties/Resources.resx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,4 +267,10 @@
267267
<data name="InvalidDegreeOfParallelism" xml:space="preserve">
268268
<value>Zero and negative values will no longer be defaulted to one, nor will they be accepted, in a future release for -DegreeOfParallelism. Please adjust your scripts to pass in a value greater than zero</value>
269269
</data>
270+
<data name="NewDataLakeComputePolicy" xml:space="preserve">
271+
<value>Creating Data Lake Analytics compute policy '{0}' with the following rules: {1}{2}...</value>
272+
</data>
273+
<data name="UpdateDataLakeComputePolicy" xml:space="preserve">
274+
<value>Update Data Lake Analytics compute policy '{0}' with the following rules: {1}{2}...</value>
275+
</data>
270276
</root>

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/help/New-AzureRmDataLakeAnalyticsComputePolicy.md

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Creates a Data Lake Analytics compute policy rule for a specific AAD entity.
1414
```
1515
New-AzureRmDataLakeAnalyticsComputePolicy [-ResourceGroupName <String>] [-Account] <String> [-Name] <String>
1616
[-ObjectId] <Guid> [-ObjectType] <String> [-MaxDegreeOfParallelismPerJob <Int32>] [-MinPriorityPerJob <Int32>]
17-
[<CommonParameters>]
17+
[-WhatIf] [-Confirm] [<CommonParameters>]
1818
```
1919

2020
## DESCRIPTION
@@ -143,6 +143,36 @@ Accept pipeline input: True (ByPropertyName)
143143
Accept wildcard characters: False
144144
```
145145
146+
### -Confirm
147+
Prompts you for confirmation before running the cmdlet.
148+
149+
```yaml
150+
Type: SwitchParameter
151+
Parameter Sets: (All)
152+
Aliases: cf
153+
154+
Required: False
155+
Position: Named
156+
Default value: None
157+
Accept pipeline input: False
158+
Accept wildcard characters: False
159+
```
160+
161+
### -WhatIf
162+
Shows what would happen if the cmdlet runs. The cmdlet is not run.
163+
164+
```yaml
165+
Type: SwitchParameter
166+
Parameter Sets: (All)
167+
Aliases: wi
168+
169+
Required: False
170+
Position: Named
171+
Default value: None
172+
Accept pipeline input: False
173+
Accept wildcard characters: False
174+
```
175+
146176
### CommonParameters
147177
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
148178

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/help/Update-AzureRmDataLakeAnalyticsComputePolicy.md

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Updates a Data Lake Analytics compute policy rule for a specific AAD entity.
1313

1414
```
1515
Update-AzureRmDataLakeAnalyticsComputePolicy [-ResourceGroupName <String>] [-Account] <String> [-Name] <String>
16-
[-MaxDegreeOfParallelismPerJob <Int32>] [-MinPriorityPerJob <Int32>] [<CommonParameters>]
16+
[-MaxDegreeOfParallelismPerJob <Int32>] [-MinPriorityPerJob <Int32>] [-WhatIf] [-Confirm] [<CommonParameters>]
1717
```
1818

1919
## DESCRIPTION
@@ -113,6 +113,36 @@ Accept pipeline input: True (ByPropertyName)
113113
Accept wildcard characters: False
114114
```
115115
116+
### -Confirm
117+
Prompts you for confirmation before running the cmdlet.
118+
119+
```yaml
120+
Type: SwitchParameter
121+
Parameter Sets: (All)
122+
Aliases: cf
123+
124+
Required: False
125+
Position: Named
126+
Default value: None
127+
Accept pipeline input: False
128+
Accept wildcard characters: False
129+
```
130+
131+
### -WhatIf
132+
Shows what would happen if the cmdlet runs. The cmdlet is not run.
133+
134+
```yaml
135+
Type: SwitchParameter
136+
Parameter Sets: (All)
137+
Aliases: wi
138+
139+
Required: False
140+
Position: Named
141+
Default value: None
142+
Accept pipeline input: False
143+
Accept wildcard characters: False
144+
```
145+
116146
### CommonParameters
117147
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
118148

0 commit comments

Comments
 (0)