Remove switch parameters

Author: Rachid Cesin Gorostieta

src/ResourceManager/Resources/Commands.Resources.Test/ResourceGroups/GetAzureResourceGroupCommandTests.cs

@@ -58,7 +58,7 @@ public void GetsResourcesGroups()
                 Resources = new List<PSResource>() { new PSResource() { Name = "resource1" } }
             };
             result.Add(expected);
-            resourcesClientMock.Setup(f => f.FilterResourceGroups(resourceGroupName, null, true, null)).Returns(result);
+            resourcesClientMock.Setup(f => f.FilterResourceGroups(resourceGroupName, null, false, null)).Returns(result);
 
             cmdlet.Name = resourceGroupName;
 

src/ResourceManager/Resources/Commands.Resources.Test/ResourceGroups/RemoveAzureResourceGroupCommandTests.cs

@@ -51,13 +51,11 @@ public void RemovesResourceGroup()
             resourcesClientMock.Setup(f => f.DeleteResourceGroup(resourceGroupName));
 
             cmdlet.Name = resourceGroupName;
-            cmdlet.PassThru = true;
             cmdlet.Force = true;
 
             cmdlet.ExecuteCmdlet();
 
             resourcesClientMock.Verify(f => f.DeleteResourceGroup(resourceGroupName), Times.Once());
-            commandRuntimeMock.Verify(f => f.WriteObject(true), Times.Once());
         }
 
         [Fact]
@@ -68,13 +66,11 @@ public void RemovesResourceGroupFromId()
             resourcesClientMock.Setup(f => f.DeleteResourceGroup(resourceGroupName));
 
             cmdlet.Id = resourceGroupId;
-            cmdlet.PassThru = true;
             cmdlet.Force = true;
 
             cmdlet.ExecuteCmdlet();
 
             resourcesClientMock.Verify(f => f.DeleteResourceGroup(resourceGroupName), Times.Once());
-            commandRuntimeMock.Verify(f => f.WriteObject(true), Times.Once());
         }
     }
 }

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/GetAzureResourceGroupCommand.cs

@@ -27,7 +27,7 @@ namespace Microsoft.Azure.Commands.Resources
     public class GetAzureResourceGroupCommand : ResourcesBaseCmdlet
     {
         [Alias("ResourceGroupName")]
-        [Parameter(Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = "GetSingle")]
+        [Parameter(Position = 0, Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = "GetSingle")]
         [ValidateNotNullOrEmpty]
         public string Name { get; set; }
 
@@ -39,24 +39,16 @@ public class GetAzureResourceGroupCommand : ResourcesBaseCmdlet
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The resource group Id.")]
         [ValidateNotNullOrEmpty]
         public string Id { get; set; }
-
-        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = "GetMultiple")]
-        public SwitchParameter Detailed { get; set; }
 
         protected override void ProcessRecord()
         {
-            if(this.Detailed.IsPresent)
-            {
-                WriteWarning("The Detailed switch parameter is being deprecated and will be removed in a future release.");
-            }
             WriteWarning("The output object of this cmdlet will be modified in a future release.");
-            var detailed = Detailed.IsPresent || !string.IsNullOrEmpty(Name);
             Name = string.IsNullOrEmpty(Name) && !string.IsNullOrEmpty(Id)
                 ? Id.Split('/').Last()
                 : Name;
 
             this.WriteObject(
-                ResourcesClient.FilterResourceGroups(name: this.Name, tag: null, detailed: detailed, location: this.Location),
+                ResourcesClient.FilterResourceGroups(name: this.Name, tag: null, detailed: false, location: this.Location),
                 true);
         }
     }

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/RemoveAzureResourceGroupCommand.cs

@@ -38,9 +38,6 @@ public class RemoveAzureResourceGroupCommand : ResourcesBaseCmdlet
 
         [Parameter(Mandatory = false, HelpMessage = "Do not ask for confirmation.")]
         public SwitchParameter Force { get; set; }
-
-        [Parameter(Mandatory = false)]
-        public SwitchParameter PassThru { get; set; }
 
         protected override void ProcessRecord()
         {
@@ -54,12 +51,6 @@ protected override void ProcessRecord()
                 ProjectResources.RemoveResourceGroupMessage,
                 Name,
                 () => ResourcesClient.DeleteResourceGroup(Name));
-
-            if (PassThru)
-            {
-                WriteWarning("The PassThru switch parameter is being deprecated and will be removed in a future release.");
-                WriteObject(true);
-            }
         }
     }
 }