Skip to content

Commit df75309

Browse files
authored
Fix the issue of wrong format of csv (#20765)
* Fix the issue of wrong format of csv * Fix the issue of wrong format of csv * Suppress Az.Compute
1 parent 12e4910 commit df75309

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,7 @@
2222
"Az.Compute","Get-AzVmssVMRunCommand","Get-AzVmssVMRunCommand","0","1050","The parameter set 'GetViaIdentity' for cmdlet 'Get-AzVmssVMRunCommand' has been removed.","Add parameter set 'GetViaIdentity' back to cmdlet 'Get-AzVmssVMRunCommand'."
2323
"Az.Compute","Get-AzVmssVMRunCommand","Get-AzVmssVMRunCommand","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzVmssVMRunCommand' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzVmssVMRunCommand'."
2424
"Az.Compute","Get-AzVmssVMRunCommand","Get-AzVmssVMRunCommand","0","1000","The cmdlet 'Get-AzVmssVMRunCommand' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'Get-AzVmssVMRunCommand' back to the module, or add an alias to the original cmdlet name."
25+
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmGalleryImageVersion","Get-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryImageVersionStorageProfile' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionFullSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
26+
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmGalleryImageVersion","Get-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryOSDiskImage' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryDiskImageSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
27+
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmGalleryImageVersion","Get-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryDataDiskImage' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryDiskImageSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
28+
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmGalleryImageVersion","New-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryOSDiskImage' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryDiskImageSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
2-
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.CopyAzureStorageBlob","Copy-AzStorageBlob","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Copy-AzStorageBlob'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
3-
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.SetAzureBlobContentCommand","Set-AzStorageBlobContent","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Set-AzStorageBlobContent'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
4-
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.StartAzureStorageBlobCopy","Start-AzStorageBlobCopy","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Start-AzStorageBlobCopy'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
5-
1+
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
2+
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.CopyAzureStorageBlob","Copy-AzStorageBlob","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Copy-AzStorageBlob'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
3+
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.SetAzureBlobContentCommand","Set-AzStorageBlobContent","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Set-AzStorageBlobContent'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
4+
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.StartAzureStorageBlobCopy","Start-AzStorageBlobCopy","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Start-AzStorageBlobCopy'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."

tools/Tools.Common/Loggers/ReportLogger.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,13 @@ public ReportLogger(string fileName, string exceptionsFileName, AnalysisLogger l
8282
var records = File.ReadAllLines(exceptionsFileName);
8383
for (int i = 1; i < records.Length; ++i)
8484
{
85+
string recordContent = records[i].Trim();
86+
if (recordContent == "")
87+
{
88+
continue;
89+
}
8590
var record = new T();
86-
_exceptionRecords.Add(record.Parse(records[i]) as T);
91+
_exceptionRecords.Add(record.Parse(recordContent) as T);
8792
}
8893
}
8994
}

0 commit comments

Comments
 (0)