Add new tests for legacy mode

Author: dihan0604

src/ServiceManagement/ExpressRoute/Commands.ExpressRoute/BgpPeerings/GetAzureBGPPeering.cs

@@ -43,10 +43,4 @@ public override void ExecuteCmdlet()
             WriteObject(peer);
         }
     }
-
-    private enum LegacyMode
-    {
-        False = 0,
-        True = 1
-    }
 }

src/ServiceManagement/ExpressRoute/Commands.ExpressRoute/BgpPeerings/NewAzureBGPPeering.cs

@@ -32,8 +32,7 @@ public class NewAzureBGPPeeringCommand : ExpressRouteBaseCmdlet
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Customer AS number")]
         public UInt32 CustomerAsn { get; set; }
 
-        [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true,
-            HelpMessage = "Peer Asn")]
+        [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Peer Asn")]
         public UInt32 PeerAsn { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Legacy Mode")]

src/ServiceManagement/Services/Commands.Test/Commands.Test.csproj

@@ -133,7 +133,7 @@
       <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Compute.13.0.0\lib\net40\Microsoft.WindowsAzure.Management.Compute.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Management.ExpressRoute">
-      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.ExpressRoute.0.20.0-preview\lib\net40\Microsoft.WindowsAzure.Management.ExpressRoute.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.ExpressRoute.0.21.0-preview\lib\net40\Microsoft.WindowsAzure.Management.ExpressRoute.dll</HintPath>
       <Private>True</Private>
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Management.MediaServices">

src/ServiceManagement/Services/Commands.Test/ExpressRoute/AzureBgpPeeringTests.cs

@@ -135,6 +135,102 @@ public void NewAzureBgpPeeringSuccessful()
             Assert.Equal(expectedBgp.BgpPeering.PrimaryAzurePort, actual.PrimaryAzurePort);
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void NewAzureMicrosoftBgpPeeringSuccessful()
+        {
+            // Setup
+            string serviceKey = "aa28cd19-b10a-41ff-981b-53c6bbf15ead";
+            UInt32 peerAsn = 64496;
+            string primaryPeerSubnet = "aaa";
+            string secondayPeerSubnet = "bbb";
+            UInt32 azureAsn = 64494;
+            string primaryAzurePort = "8081";
+            string secondaryAzurePort = "8082";
+            var state = BgpPeeringState.Enabled;
+            uint vlanId = 2;
+            var accessType = BgpPeeringAccessType.Microsoft;
+            uint legacyMode = 0;
+            string prefix = "12.2.3.4/30";
+
+            MockCommandRuntime mockCommandRuntime = new MockCommandRuntime();
+            Mock<ExpressRouteManagementClient> client = InitExpressRouteManagementClient();
+            var bgpMock = new Mock<IBorderGatewayProtocolPeeringOperations>();
+
+            BorderGatewayProtocolPeeringGetResponse expectedBgp =
+                new BorderGatewayProtocolPeeringGetResponse
+                {
+                    BgpPeering = new AzureBgpPeering()
+                    {
+                        AzureAsn = azureAsn,
+                        PeerAsn = peerAsn,
+                        PrimaryAzurePort = primaryAzurePort,
+                        PrimaryPeerSubnet = primaryPeerSubnet,
+                        SecondaryAzurePort = secondaryAzurePort,
+                        SecondaryPeerSubnet = secondayPeerSubnet,
+                        State = state,
+                        VlanId = vlanId,
+                        LegacyMode = legacyMode,
+                        AdvertisedPublicPrefixes = prefix
+                    },
+                    RequestId = "",
+                    StatusCode = new HttpStatusCode()
+                };
+
+            ExpressRouteOperationStatusResponse expectedStatus = new ExpressRouteOperationStatusResponse()
+            {
+                HttpStatusCode = HttpStatusCode.OK
+            };
+
+            var tGet = new Task<BorderGatewayProtocolPeeringGetResponse>(() => expectedBgp);
+            tGet.Start();
+
+            var tNew = new Task<ExpressRouteOperationStatusResponse>(() => expectedStatus);
+            tNew.Start();
+
+            bgpMock.Setup(
+                f =>
+                    f.NewAsync(It.Is<string>(x => x == serviceKey),
+                        It.Is<BgpPeeringAccessType>(
+                            y => y == accessType),
+                        It.Is<BorderGatewayProtocolPeeringNewParameters>(
+                            z =>
+                                z.PeerAutonomousSystemNumber == peerAsn && z.PrimaryPeerSubnet == primaryPeerSubnet &&
+                                z.SecondaryPeerSubnet == secondayPeerSubnet && z.VirtualLanId == vlanId),
+                        It.IsAny<CancellationToken>()))
+                .Returns((string sKey, BgpPeeringAccessType atype, BorderGatewayProtocolPeeringNewParameters param, CancellationToken cancellation) => tNew);
+            client.SetupGet(f => f.BorderGatewayProtocolPeerings).Returns(bgpMock.Object);
+
+            bgpMock.Setup(
+               f =>
+                   f.GetAsync(It.Is<string>(x => x == serviceKey),
+                       It.Is<BgpPeeringAccessType>(
+                           y => y == accessType),
+                       It.IsAny<CancellationToken>()))
+               .Returns((string sKey, BgpPeeringAccessType atype, CancellationToken cancellation) => tGet);
+            client.SetupGet(f => f.BorderGatewayProtocolPeerings).Returns(bgpMock.Object);
+
+            NewAzureBGPPeeringCommand cmdlet = new NewAzureBGPPeeringCommand()
+            {
+                ServiceKey = Guid.Parse(serviceKey),
+                AccessType = accessType,
+                PeerAsn = peerAsn,
+                PrimaryPeerSubnet = primaryPeerSubnet,
+                SecondaryPeerSubnet = secondayPeerSubnet,
+                SharedKey = null,
+                VlanId = vlanId,
+                CommandRuntime = mockCommandRuntime,
+                ExpressRouteClient = new ExpressRouteClient(client.Object)
+            };
+
+            cmdlet.ExecuteCmdlet();
+
+            // Assert
+            AzureBgpPeering actual = mockCommandRuntime.OutputPipeline[0] as AzureBgpPeering;
+            Assert.Equal(expectedBgp.BgpPeering.State, actual.State);
+            Assert.Equal(expectedBgp.BgpPeering.PrimaryAzurePort, actual.PrimaryAzurePort);
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void GetAzureBgpPeeringSuccessful()

src/ServiceManagement/Services/Commands.Test/packages.config

@@ -20,7 +20,7 @@
   <package id="Microsoft.WindowsAzure.ConfigurationManager" version="3.2.0" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management" version="4.1.1" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.Compute" version="13.0.0" targetFramework="net45" />
-  <package id="Microsoft.WindowsAzure.Management.ExpressRoute" version="0.20.0-preview" targetFramework="net45" />
+  <package id="Microsoft.WindowsAzure.Management.ExpressRoute" version="0.21.0-preview" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.MediaServices" version="4.0.0" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.ServiceBus" version="0.18.0-preview" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.Storage" version="6.0.1" targetFramework="net45" />