ASR:BugFix: Updating the disk type input while creating disk configuration (#12083)

* updating the disk type

* updated help file

* updated as per comments

Author: ayfathim

src/RecoveryServices/RecoveryServices.SiteRecovery/DiskReplicationConfiguration/AzureRmAsrAzureToAzureDiskReplicationConfig.cs

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using System.Management.Automation;
+using Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.Properties;
 
 namespace Microsoft.Azure.Commands.RecoveryServices.SiteRecovery
 {
@@ -84,7 +85,8 @@ public class AzureRmAsrAzureToAzureDiskReplicationConfig : SiteRecoveryCmdletBas
         [ValidateSet(
             Constants.Premium_LRS,
             Constants.Standard_LRS,
-            Constants.Standard_SSD)]
+            Constants.Standard_SSD,
+            Constants.StandardSSD_LRS)]
         public string RecoveryReplicaDiskAccountType { get; set; }
 
         /// <summary>
@@ -95,7 +97,8 @@ public class AzureRmAsrAzureToAzureDiskReplicationConfig : SiteRecoveryCmdletBas
         [ValidateSet(
             Constants.Premium_LRS,
             Constants.Standard_LRS,
-            Constants.Standard_SSD)]
+            Constants.Standard_SSD,
+            Constants.StandardSSD_LRS)]
         public string RecoveryTargetDiskAccountType { get; set; }
 
         /// <summary>
@@ -174,6 +177,23 @@ public override void ExecuteSiteRecoveryCmdlet()
                         };
                         break;
                     case ASRParameterSets.AzureToAzureManagedDisk:
+
+                        if (this.RecoveryReplicaDiskAccountType == Constants.Standard_SSD  ||
+                            this.RecoveryTargetDiskAccountType == Constants.Standard_SSD)
+                        {
+                            this.WriteWarning(Resources.RecoveryDiskTypeUnSupported);
+
+                            if (this.RecoveryReplicaDiskAccountType == Constants.Standard_SSD)
+                            {
+                                this.RecoveryReplicaDiskAccountType = Constants.StandardSSD_LRS;
+                            }
+
+                            if (this.RecoveryTargetDiskAccountType == Constants.StandardSSD_LRS)
+                            {
+                                this.RecoveryTargetDiskAccountType = Constants.StandardSSD_LRS;
+                            }
+                        }
+
                         diskRelicationConfig = new ASRAzuretoAzureDiskReplicationConfig()
                         {
                             DiskId = this.DiskId,

src/RecoveryServices/RecoveryServices.SiteRecovery/Models/PSConstants.cs

@@ -467,6 +467,11 @@ public static class Constants
         /// </summary>
         public const string Standard_LRS = "Standard_LRS";
 
+        /// <summary>
+        ///     Represents StandardSSD_LRS storage account.
+        /// </summary>
+        public const string StandardSSD_LRS = "StandardSSD_LRS";
+
         /// <summary>
         ///     Represents Standard_SSD storage account.
         /// </summary>

src/RecoveryServices/RecoveryServices.SiteRecovery/Properties/Resources.Designer.cs

@@ -507,4 +507,7 @@ Recommended Action: To cleanup the resources created by Test failover run the Te
   <data name="UnsupportedReplicationProvidedForNetworkingResources" xml:space="preserve">
     <value>Unsupported replication provider for network security group, public IP address, and/or backend address pool related updates.</value>
   </data>
+  <data name="RecoveryDiskTypeUnSupported" xml:space="preserve">
+    <value>Recovery manged disk type "Standard_SSD" is not supported. Converting it to "StandardSSD_LRS".</value>
+  </data>
 </root>

src/RecoveryServices/RecoveryServices.SiteRecovery/Properties/Resources.resx

@@ -19,6 +19,7 @@
 -->
 ## Upcoming Release
 * Azure Backup added support for fetching MAB items.
+* Azure Site Recovery supports disk type :StandardSSD_LRS
 
 ## Version 2.9.1
 * Azure Site Recovery support for creating recovery plan for zone to zone replication from xml input.

src/RecoveryServices/RecoveryServices/ChangeLog.md

@@ -240,7 +240,7 @@ Specifies the account type of replicated managed disk.
 Type: System.String
 Parameter Sets: AzureToAzureManagedDisk
 Aliases:
-Accepted values: Premium_LRS, Standard_LRS, Standard_SSD
+Accepted values: Premium_LRS, Standard_LRS, StandardSSD_LRS
 
 Required: True
 Position: Named
@@ -271,7 +271,7 @@ Specifies the recovery target disk for replicated managed disk.
 Type: System.String
 Parameter Sets: AzureToAzureManagedDisk
 Aliases:
-Accepted values: Premium_LRS, Standard_LRS, Standard_SSD
+Accepted values: Premium_LRS, Standard_LRS, StandardSSD_LRS
 
 Required: True
 Position: Named