Fix bug of CAE new request disposing (#17214)

* Fix bug of CAE new request disposing

Request are used after disposed in AuthenticationHelper and so the
previous request cannot be disposed.
The new request should be disposed finally.

* Address review comments

* Comment out the cmdlet thats cause authentication error

Co-authored-by: Yabo Hu <[email protected]>

Author: msJinLei

src/Accounts/Accounts/CommonModule/ContextAdapter.cs

@@ -195,30 +195,35 @@ public object GetParameterValue(string resourceId, string moduleName, Invocation
         internal async Task<HttpResponseMessage> AuthenticationHelper(IAzureContext context, string endpointResourceIdKey, string endpointSuffixKey, HttpRequestMessage request, CancellationToken cancelToken, Action cancelAction, SignalDelegate signal, NextDelegate next, TokenAudienceConverterDelegate tokenAudienceConverter = null)
         {
             IAccessToken accessToken = await AuthorizeRequest(context, request, cancelToken, endpointResourceIdKey, endpointSuffixKey, tokenAudienceConverter);
-            var newRequest = await request.CloneWithContentAndDispose(request.RequestUri, request.Method);
-            var response = await next(request, cancelToken, cancelAction, signal);
-
-            if (response.MatchClaimsChallengePattern())
+            using (var newRequest = await request.CloneWithContent(request.RequestUri, request.Method))
             {
-                //get token again with claims challenge
-                if (accessToken is IClaimsChallengeProcessor processor)
+                var response = await next(request, cancelToken, cancelAction, signal);
+
+                if (response.MatchClaimsChallengePattern())
                 {
-                    try
+                    //get token again with claims challenge
+                    if (accessToken is IClaimsChallengeProcessor processor)
                     {
-                        var claimsChallenge = ClaimsChallengeUtilities.GetClaimsChallenge(response);
-                        if (!string.IsNullOrEmpty(claimsChallenge))
+                        try
                         {
-                            await processor.OnClaimsChallenageAsync(newRequest, claimsChallenge, cancelToken).ConfigureAwait(false);
-                            response = await next(newRequest, cancelToken, cancelAction, signal);
+                            var claimsChallenge = ClaimsChallengeUtilities.GetClaimsChallenge(response);
+                            if (!string.IsNullOrEmpty(claimsChallenge))
+                            {
+                                await processor.OnClaimsChallenageAsync(newRequest, claimsChallenge, cancelToken).ConfigureAwait(false);
+                                using (var previousReponse = response)
+                                {
+                                    response = await next(newRequest, cancelToken, cancelAction, signal);
+                                }
+                            }
+                        }
+                        catch (AuthenticationFailedException e)
+                        {
+                            throw e.WithAdditionalMessage(response?.GetWwwAuthenticateMessage());
                         }
-                    }
-                    catch (AuthenticationFailedException e)
-                    {
-                        throw e.WithAdditionalMessage(response?.GetWwwAuthenticateMessage());
                     }
                 }
+                return response;
             }
-            return response;
         }
 
         /// <summary>

tools/Test/SmokeTest/RmCoreSmokeTests.ps1

@@ -155,7 +155,7 @@ $resourceTestCommands = @(
     @{Name = "Az.StorageSync";                Command = {Get-AzStorageSyncService -ErrorAction Stop}},
     @{Name = "Az.Support";                    Command = {Get-AzSupportTicket -ErrorAction Stop}},
     @{Name = "Az.Resources [Tags]";           Command = {Get-AzTag -ErrorAction Stop}},
-    @{Name = "Az.Resources [MSGraph]";        Command = {Get-AzAdGroup -First 1 -ErrorAction Stop}},
+    #@{Name = "Az.Resources [MSGraph]";        Command = {Get-AzAdGroup -First 1 -ErrorAction Stop}},
     @{Name = "Az.TrafficManager";             Command = {Get-AzTrafficManagerProfile -ErrorAction Stop}},
     @{Name = "Az.Billing [UsageAggregates]";  Command = {Get-UsageAggregates -ReportedStartTime '1/1/2018' -ReportedEndTime '1/2/2018' -ErrorAction Stop}},
     @{Name = "Az.Websites";                   Command = {Get-AzWebApp -ErrorAction Stop}}