Added ValidateNotNullOrEmpty for ResourceGroupName, Modified change logs, Fix ordering of parameters for better help, some minor changes

Siddharth Chatrola · Siddharth Chatrola · commit e5316aa65484 · 2018-01-19T14:01:22.000-08:00
diff --git a/src/ResourceManager/RedisCache/ChangeLog.md b/src/ResourceManager/RedisCache/ChangeLog.md
@@ -20,6 +20,10 @@
 ## Current Release
 * Added Location Completer to -Location parameters allowing tab completion through valid Locations
 * Added ResourceGroup Completer to -ResourceGroup parameters allowing tab completion through resource groups in current subscription
+* Added  3 new cmdlets for firewall rules
+* Added  3 new cmdlets for geo replication
+* Added support for zones and tags
+* Make ResourceGroup as optional whenever possible.
 
 ## Version 4.0.1
 * Fixed assembly loading issue that caused some cmdlets to fail when executing
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/ExportAzureRedisCache.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/ExportAzureRedisCache.cs
@@ -25,6 +25,7 @@ public class ExportAzureRedisCache : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCache.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCache.cs
@@ -28,6 +28,7 @@ public class GetAzureRedisCache : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which want to create cache.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCacheFirewallRule.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCacheFirewallRule.cs
@@ -27,6 +27,7 @@ public class GetAzureRedisCacheFirewallRule : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCacheKey.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCacheKey.cs
@@ -23,6 +23,7 @@ public class GetAzureRedisCacheKey : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCacheLink.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCacheLink.cs
@@ -59,43 +59,37 @@ public override void ExecuteCmdlet()
             if (!string.IsNullOrWhiteSpace(Name))
             {
                 // All links for cache
-                if (!string.IsNullOrWhiteSpace(PrimaryServerName) || !string.IsNullOrWhiteSpace(SecondaryServerName))
-                {
-                    throw new ArgumentException(Resources.LinkServerIncompatibleParameterException);
-                }
                 List<PSRedisLinkedServer> list = GetAllLinks(Name);
                 WriteObject(list, true);
             }
-            else
+            else if (!string.IsNullOrWhiteSpace(PrimaryServerName) && !string.IsNullOrWhiteSpace(SecondaryServerName))
             {
-                if (!string.IsNullOrWhiteSpace(PrimaryServerName) && !string.IsNullOrWhiteSpace(SecondaryServerName))
-                {
-                    // specific link only
-                    string resourceGroupName = CacheClient.GetResourceGroupNameIfNotProvided(null, PrimaryServerName);
-                    RedisLinkedServerWithProperties redisLinkedServer = CacheClient.GetLinkedServer(
-                        resourceGroupName: resourceGroupName,
-                        cacheName: PrimaryServerName,
-                        linkedCacheName: SecondaryServerName);
+                // specific link only
+                string resourceGroupName = CacheClient.GetResourceGroupNameIfNotProvided(null, PrimaryServerName);
+                RedisLinkedServerWithProperties redisLinkedServer = CacheClient.GetLinkedServer(
+                    resourceGroupName: resourceGroupName,
+                    cacheName: PrimaryServerName,
+                    linkedCacheName: SecondaryServerName);
 
-                    if (redisLinkedServer == null || redisLinkedServer.ServerRole != ReplicationRole.Secondary)
-                    {
-                        throw new CloudException(string.Format(Resources.LinkedServerNotFound, PrimaryServerName, SecondaryServerName));
-                    }
-                    WriteObject(new PSRedisLinkedServer(redisLinkedServer));
-                }
-                else if (!string.IsNullOrWhiteSpace(PrimaryServerName))
-                {
-                    // all primary links only
-                    List<PSRedisLinkedServer> list = GetAllLinksByRoleType(PrimaryServerName, ReplicationRole.Primary);
-                    WriteObject(list, true);
-                }
-                else
+                if (redisLinkedServer == null || redisLinkedServer.ServerRole != ReplicationRole.Secondary)
                 {
-                    // all secondary links only
-                    List<PSRedisLinkedServer> list = GetAllLinksByRoleType(SecondaryServerName, ReplicationRole.Secondary);
-                    WriteObject(list, true);
+                    throw new CloudException(string.Format(Resources.LinkedServerNotFound, PrimaryServerName, SecondaryServerName));
                 }
+                WriteObject(new PSRedisLinkedServer(redisLinkedServer));
             }
+            else if (!string.IsNullOrWhiteSpace(PrimaryServerName))
+            {
+                // all primary links only
+                List<PSRedisLinkedServer> list = GetAllLinksByRoleType(PrimaryServerName, ReplicationRole.Primary);
+                WriteObject(list, true);
+            }
+            else
+            {
+                // all secondary links only
+                List<PSRedisLinkedServer> list = GetAllLinksByRoleType(SecondaryServerName, ReplicationRole.Secondary);
+                WriteObject(list, true);
+            }
+
         }
 
         private List<PSRedisLinkedServer> GetAllLinks(string cacheName)
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCachePatchSchedule.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/GetAzureRedisCachePatchSchedule.cs
@@ -29,6 +29,7 @@ public class GetAzureRedisCachePatchSchedule : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/ImportAzureRedisCache.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/ImportAzureRedisCache.cs
@@ -25,6 +25,7 @@ public class ImportAzureRedisCache : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/NewAzureRedisCacheFirewallRule.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/NewAzureRedisCacheFirewallRule.cs
@@ -30,38 +30,33 @@ public class NewAzureRedisCacheFirewallRule : RedisCacheCmdletBase
 
         [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
         [ValidateNotNullOrEmpty]
         public string Name { get; set; }
 
-        [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of firewall rule.")]
-        [Parameter(ParameterSetName = InputObjectParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of firewall rule.")]
-        [Parameter(ParameterSetName = ResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of firewall rule.")]
+        [Parameter(ParameterSetName = InputObjectParameterSet, Mandatory = true, ValueFromPipeline = true, HelpMessage = "Object of type RedisCacheAttributes")]
+        [ValidateNotNull]
+        public RedisCacheAttributes InputObject { get; set; }
+
+        [Parameter(ParameterSetName = ResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "ARM Id of Redis Cache.")]
+        [ValidateNotNullOrEmpty]
+        public string ResourceId { get; set; }
+
+        [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of firewall rule.")]
         [ValidateNotNullOrEmpty]
         public string RuleName { get; set; }
 
-        [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Starting IP address.")]
-        [Parameter(ParameterSetName = InputObjectParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Starting IP address.")]
-        [Parameter(ParameterSetName = ResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Starting IP address.")]
+        [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Starting IP address.")]
         [ValidateNotNullOrEmpty]
         public string StartIP { get; set; }
 
-        [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Ending IP address.")]
-        [Parameter(ParameterSetName = InputObjectParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Ending IP address.")]
-        [Parameter(ParameterSetName = ResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Ending IP address.")]
+        [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Ending IP address.")]
         [ValidateNotNullOrEmpty]
         public string EndIP { get; set; }
 
-        [Parameter(ParameterSetName = InputObjectParameterSet, Mandatory = true, ValueFromPipeline = true, HelpMessage = "object of type RedisCacheAttributes")]
-        [ValidateNotNull]
-        public RedisCacheAttributes InputObject { get; set; }
-
-        [Parameter(ParameterSetName = ResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "ARM Id of Redis Cache.")]
-        [ValidateNotNullOrEmpty]
-        public string ResourceId { get; set; }
-
         public override void ExecuteCmdlet()
         {
             // In case of piped parent object "RedisCacheAttributes" fetch ResourceGroupName and Name from it
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/NewAzureRedisCacheKey.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/NewAzureRedisCacheKey.cs
@@ -25,6 +25,7 @@ public class NewAzureRedisCacheKey : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/NewAzureRedisCachePatchSchedule.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/NewAzureRedisCachePatchSchedule.cs
@@ -28,6 +28,7 @@ public class NewAzureRedisCachePatchSchedule : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCache.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCache.cs
@@ -26,6 +26,7 @@ public class RemoveAzureRedisCache : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache to be removed.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCacheDiagnostics.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCacheDiagnostics.cs
@@ -27,6 +27,7 @@ public class RemoveAzureRedisCacheDiagnostics : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCacheFirewallRule.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCacheFirewallRule.cs
@@ -27,6 +27,7 @@ public class RemoveAzureRedisCacheFirewallRule : RedisCacheCmdletBase
 
         [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ParameterSetName = NormalParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
@@ -37,13 +38,13 @@ public class RemoveAzureRedisCacheFirewallRule : RedisCacheCmdletBase
         [ValidateNotNullOrEmpty]
         public string RuleName { get; set; }
 
-        [Parameter(Mandatory = false)]
-        public SwitchParameter PassThru { get; set; }
-
-        [Parameter(ParameterSetName = InputObjectParameterSet, Mandatory = true, ValueFromPipeline = true, HelpMessage = "object of type PSRedisFirewallRule")]
+        [Parameter(ParameterSetName = InputObjectParameterSet, Mandatory = true, ValueFromPipeline = true, HelpMessage = "Object of type PSRedisFirewallRule")]
         [ValidateNotNull]
         public PSRedisFirewallRule InputObject { get; set; }
 
+        [Parameter(Mandatory = false)]
+        public SwitchParameter PassThru { get; set; }
+
         public override void ExecuteCmdlet()
         {
             if (ParameterSetName.Equals(InputObjectParameterSet))
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCachePatchSchedule.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/RemoveAzureRedisCachePatchSchedule.cs
@@ -28,6 +28,7 @@ public class RemoveAzureRedisCachePatchSchedule : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/ResetAzureRedisCache.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/ResetAzureRedisCache.cs
@@ -27,6 +27,7 @@ public class ResetAzureRedisCache : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/SetAzureRedisCache.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/SetAzureRedisCache.cs
@@ -28,6 +28,7 @@ public class SetAzureRedisCache : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which you want to create cache.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/SetAzureRedisCacheDiagnostics.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Commands/SetAzureRedisCacheDiagnostics.cs
@@ -25,6 +25,7 @@ public class SetAzureRedisCacheDiagnostics : RedisCacheCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]
         [ResourceGroupCompleter]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Properties/Resources.Designer.cs b/src/ResourceManager/RedisCache/Commands.RedisCache/Properties/Resources.Designer.cs
diff --git a/src/ResourceManager/RedisCache/Commands.RedisCache/Properties/Resources.resx b/src/ResourceManager/RedisCache/Commands.RedisCache/Properties/Resources.resx
@@ -195,9 +195,6 @@
   <data name="CacheNotFound" xml:space="preserve">
     <value>Redis Cache with name '{0}' does not exists.</value>
   </data>
-  <data name="LinkServerIncompatibleParameterException" xml:space="preserve">
-    <value>Parameter 'Name' is not compatible with parameters 'PrimaryServerName' and/or 'SecondaryServerName'.</value>
-  </data>
   <data name="CreatePatchSchedule" xml:space="preserve">
     <value>Creating patching schedule on redis cache '{0}'...</value>
   </data>

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public class ExportAzureRedisCache : RedisCacheCmdletBase`
`25`	`25`	`{`
`26`	`26`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]`
`27`	`27`	`[ResourceGroupCompleter]`
	`28`	`+ [ValidateNotNullOrEmpty]`
`28`	`29`	`public string ResourceGroupName { get; set; }`
`29`	`30`
`30`	`31`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public class GetAzureRedisCache : RedisCacheCmdletBase`
`28`	`28`	`{`
`29`	`29`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which want to create cache.")]`
`30`	`30`	`[ResourceGroupCompleter]`
	`31`	`+ [ValidateNotNullOrEmpty]`
`31`	`32`	`public string ResourceGroupName { get; set; }`
`32`	`33`
`33`	`34`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ public class GetAzureRedisCacheFirewallRule : RedisCacheCmdletBase`
`27`	`27`	`{`
`28`	`28`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]`
`29`	`29`	`[ResourceGroupCompleter]`
	`30`	`+ [ValidateNotNullOrEmpty]`
`30`	`31`	`public string ResourceGroupName { get; set; }`
`31`	`32`
`32`	`33`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ public class GetAzureRedisCacheKey : RedisCacheCmdletBase`
`23`	`23`	`{`
`24`	`24`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]`
`25`	`25`	`[ResourceGroupCompleter]`
	`26`	`+ [ValidateNotNullOrEmpty]`
`26`	`27`	`public string ResourceGroupName { get; set; }`
`27`	`28`
`28`	`29`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ public class GetAzureRedisCachePatchSchedule : RedisCacheCmdletBase`
`29`	`29`	`{`
`30`	`30`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]`
`31`	`31`	`[ResourceGroupCompleter]`
	`32`	`+ [ValidateNotNullOrEmpty]`
`32`	`33`	`public string ResourceGroupName { get; set; }`
`33`	`34`
`34`	`35`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public class ImportAzureRedisCache : RedisCacheCmdletBase`
`25`	`25`	`{`
`26`	`26`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]`
`27`	`27`	`[ResourceGroupCompleter]`
	`28`	`+ [ValidateNotNullOrEmpty]`
`28`	`29`	`public string ResourceGroupName { get; set; }`
`29`	`30`
`30`	`31`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public class NewAzureRedisCacheKey : RedisCacheCmdletBase`
`25`	`25`	`{`
`26`	`26`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]`
`27`	`27`	`[ResourceGroupCompleter]`
	`28`	`+ [ValidateNotNullOrEmpty]`
`28`	`29`	`public string ResourceGroupName { get; set; }`
`29`	`30`
`30`	`31`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public class NewAzureRedisCachePatchSchedule : RedisCacheCmdletBase`
`28`	`28`	`{`
`29`	`29`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group in which cache exists.")]`
`30`	`30`	`[ResourceGroupCompleter]`
	`31`	`+ [ValidateNotNullOrEmpty]`
`31`	`32`	`public string ResourceGroupName { get; set; }`
`32`	`33`
`33`	`34`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ public class RemoveAzureRedisCache : RedisCacheCmdletBase`
`26`	`26`	`{`
`27`	`27`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]`
`28`	`28`	`[ResourceGroupCompleter]`
	`29`	`+ [ValidateNotNullOrEmpty]`
`29`	`30`	`public string ResourceGroupName { get; set; }`
`30`	`31`
`31`	`32`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache to be removed.")]`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ public class RemoveAzureRedisCacheDiagnostics : RedisCacheCmdletBase`
`27`	`27`	`{`
`28`	`28`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Name of resource group under which cache exists.")]`
`29`	`29`	`[ResourceGroupCompleter]`
	`30`	`+ [ValidateNotNullOrEmpty]`
`30`	`31`	`public string ResourceGroupName { get; set; }`
`31`	`32`
`32`	`33`	`[Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "Name of redis cache.")]`