Merge pull request #853 from vivsriaus/MoreWarnings

More warning messages for upcoming changes in ARM cmdlets

Author: Jianghao Lu

src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj

@@ -186,7 +186,6 @@
     <Compile Include="Providers\RegisterResourceProviderCmdletTests.cs" />
     <Compile Include="Providers\UnregisterResourceProviderCmdletTests.cs" />
     <Compile Include="ResourceGroupDeployments\RemoveAzureResourceGroupDeploymentCommandTests.cs" />
-    <Compile Include="ResourceGroups\GetAzureResourceGroupLogCommandTests.cs" />
     <Compile Include="ResourceGroups\GetAzureLocationCommandTests.cs" />
     <Compile Include="ResourceGroups\SetAzureResourceGroupCommandTests.cs" />
     <Compile Include="ScenarioTests\ActiveDirectoryTests.cs" />
@@ -474,7 +473,7 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceTests\TestSetAResourceTest.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-	<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleAssignmentTests\RaAuthorizationChangeLog.json">
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleAssignmentTests\RaAuthorizationChangeLog.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleAssignmentTests\RaByResource.json">

src/ResourceManager/Resources/Commands.Resources.Test/ResourceGroups/GetAzureResourceGroupLogCommandTests.cs

@@ -203,7 +203,6 @@
     <Compile Include="Providers\RegisterAzureProviderCmdlet.cs" />
     <Compile Include="Providers\UnregisterAzureProviderCmdlet.cs" />
     <Compile Include="ResourceGroupDeployments\RemoveAzureResourceGroupDeploymentCommand.cs" />
-    <Compile Include="ResourceGroups\GetAzureResourceGroupLogCommand.cs" />
     <Compile Include="ResourceGroups\GetAzureLocationCommand.cs" />
     <Compile Include="ResourceGroups\SetAzureResourceGroupCommand.cs" />
     <Compile Include="RoleAssignments\RemoveAzureRoleAssignmentCommand.cs" />

src/ResourceManager/Resources/Commands.Resources/Commands.Resources.csproj

@@ -47,11 +47,10 @@ public override void ExecuteCmdlet()
                     new List<string>() { ProvisioningState }
             };
 
-            if(!string.IsNullOrEmpty(Name))
+            if(!string.IsNullOrEmpty(ProvisioningState))
             {
-                WriteWarning("The parameter 'Name' in Get-AzureResourceGroupDeployment cmdlet is being renamed to DeploymentName and will be updated in a future release.");
+                WriteWarning("The ProvisioningState parameter is being deprecated and will be removed in a future release.");
             }
-
             WriteObject(ResourcesClient.FilterResourceGroupDeployments(options), true);
         }
     }

src/ResourceManager/Resources/Commands.Resources/ResourceGroupDeployments/GetAzureResourceGroupDeploymentCommand.cs

@@ -61,9 +61,9 @@ public override void ExecuteCmdlet()
                 StorageAccountName = StorageAccountName
             };
 
-            if(!string.IsNullOrEmpty(TemplateVersion) || !string.IsNullOrEmpty(StorageAccountName))
+            if (!string.IsNullOrEmpty(TemplateVersion) || !string.IsNullOrEmpty(StorageAccountName) || !string.IsNullOrEmpty(GalleryTemplateIdentity))
             {
-                WriteWarning("The TemplateVersion and StorageAccountName parameters in New-AzureResourceGroupDeployment cmdlet is being deprecated and will be removed in a future release.");
+                WriteWarning("The GalleryTemplateIdentity, TemplateVersion and StorageAccountName parameters in New-AzureResourceGroupDeployment cmdlet is being deprecated and will be removed in a future release.");
             }
 
             if(this.Mode == DeploymentMode.Complete)

src/ResourceManager/Resources/Commands.Resources/ResourceGroupDeployments/NewAzureResourceGroupDeploymentCommand.cs

@@ -50,6 +50,7 @@ public override void ExecuteCmdlet()
 
             if (PassThru)
             {
+                WriteWarning("The PassThru switch parameter is being deprecated and will be removed in a future release.");
                 WriteObject(true);
             }
         }

src/ResourceManager/Resources/Commands.Resources/ResourceGroupDeployments/RemoveAzureResourceGroupDeploymentCommand.cs

@@ -50,6 +50,7 @@ public override void ExecuteCmdlet()
 
             if (PassThru)
             {
+                WriteWarning("The output object of this cmdlet will be modified in a future release.");
                 WriteObject(true);
             }
         }

src/ResourceManager/Resources/Commands.Resources/ResourceGroupDeployments/StopAzureResourceGroupDeploymentCommand.cs

@@ -29,6 +29,7 @@ public class GetAzureLocationCommand : ResourcesBaseCmdlet, IModuleAssemblyIniti
     {
         public override void ExecuteCmdlet()
         {
+            WriteWarning("The output object of this cmdlet will be modified in a future release.");
             WriteObject(ResourcesClient.GetLocations(), true);
         }
 

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/GetAzureLocationCommand.cs

@@ -38,6 +38,15 @@ public class GetAzureResourceGroupCommand : ResourcesBaseCmdlet
 
         public override void ExecuteCmdlet()
         {
+            if(this.Tag != null)
+            {
+                WriteWarning("The Tag parameter is being deprecated and will be removed in a future release.");
+            }
+            if(this.Detailed.IsPresent)
+            {
+                WriteWarning("The Detailed switch parameter is being deprecated and will be removed in a future release.");
+            }
+            WriteWarning("The output object of this cmdlet will be modified in a future release.");
             var detailed = Detailed.IsPresent || !string.IsNullOrEmpty(Name);
             WriteObject(ResourcesClient.FilterResourceGroups(Name, Tag, detailed), true);
         }

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/GetAzureResourceGroupCommand.cs

@@ -67,6 +67,7 @@ public override void ExecuteCmdlet()
             {
                 WriteWarning("The deployment parameters in New-AzureResourceGroup cmdlet is being deprecated and will be removed in a future release. Please use New-AzureResourceGroupDeployment to submit deployments.");
             }
+            WriteWarning("The output object of this cmdlet will be modified in a future release.");
             WriteObject(ResourcesClient.CreatePSResourceGroup(parameters));
         }
     }

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/GetAzureResourceGroupLogCommand.cs

@@ -46,6 +46,7 @@ public override void ExecuteCmdlet()
 
             if (PassThru)
             {
+                WriteWarning("The PassThru switch parameter is being deprecated and will be removed in a future release.");
                 WriteObject(true);
             }
         }

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/NewAzureResourceGroupCommand.cs

@@ -40,7 +40,7 @@ public override void ExecuteCmdlet()
                 ResourceGroupName = Name,
                 Tag = Tag
             };
-
+            WriteWarning("The output object of this cmdlet will be modified in a future release.");
             WriteObject(ResourcesClient.UpdatePSResourceGroup(parameters));
         }
     }

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/RemoveAzureResourceGroupCommand.cs

@@ -49,6 +49,7 @@ public class GetAzureResourceGroupGalleryTemplateCommand : ResourcesBaseCmdlet
 
         public override void ExecuteCmdlet()
         {
+            WriteWarning("This cmdlet is being deprecated and will be removed in a future release.");
             FilterGalleryTemplatesOptions options = new FilterGalleryTemplatesOptions()
             {
                 Category = Category,

src/ResourceManager/Resources/Commands.Resources/ResourceGroups/SetAzureResourceGroupCommand.cs

@@ -37,6 +37,7 @@ public class SaveAzureResourceGroupGalleryTemplateCommand : ResourcesBaseCmdlet
 
         public override void ExecuteCmdlet()
         {
+            WriteWarning("This cmdlet is being deprecated and will be removed in a future release.");
             string path = GalleryTemplatesClient.DownloadGalleryTemplateFile(
                 Identity,
                 string.IsNullOrEmpty(Path) ? System.IO.Path.Combine(CurrentPath(), Identity) : this.TryResolvePath(Path),

src/ResourceManager/Resources/Commands.Resources/Templates/GetAzureResourceGroupGalleryTemplateCommand.cs

@@ -41,6 +41,10 @@ public TestAzureResourceGroupTemplateCommand()
         public override void ExecuteCmdlet()
         {
             this.WriteWarning("The Test-AzureResourceGroupTemplate cmdlet is being renamed to Test-AzureResourceGroupDeployment in a future release.");
+            if (!string.IsNullOrEmpty(TemplateVersion) || !string.IsNullOrEmpty(StorageAccountName) || !string.IsNullOrEmpty(GalleryTemplateIdentity))
+            {
+                WriteWarning("The GalleryTemplateIdentity, TemplateVersion and StorageAccountName parameters are being deprecated and will be removed in a future release.");
+            }
             ValidatePSResourceGroupDeploymentParameters parameters = new ValidatePSResourceGroupDeploymentParameters()
             {
                 ResourceGroupName = ResourceGroupName,