address comment

Author: b564518128

src/Network/Network/Az.Network.psd1

@@ -451,7 +451,8 @@ AliasesToExport = 'List-AzApplicationGatewayAvailableWafRuleSets',
                'Get-AzExpressRouteCircuitStats', 
                'Get-AzApplicationGatewayAvailableWafRuleSets', 
                'Get-AzApplicationGatewayAvailableSslOptions', 
-               'Get-AzInterfaceEndpoint'
+               'Get-AzInterfaceEndpoint',
+               'New-AzFirewallThreatIntelWhitelistObject'
 
 # DSC resources to export from this module
 # DscResourcesToExport = @()

src/Network/Network/AzureFirewall/NewAzureFirewallCommand.cs

@@ -137,7 +137,6 @@ public class NewAzureFirewallCommand : AzureFirewallBaseCmdlet
 
         [Parameter(
             Mandatory = false,
-            ValueFromPipelineByPropertyName = true,
             HelpMessage = "The whitelist for Threat Intelligence")]
         public PSAzureFirewallThreatIntelWhitelist ThreatIntelWhitelist { get; set; }
 

src/Network/Network/AzureFirewall/ThreatIntelWhitelist/NewAzureFirewallThreatIntelWhitelistCommand.cs

@@ -20,7 +20,8 @@
 
 namespace Microsoft.Azure.Commands.Network
 {
-    [Cmdlet(VerbsCommon.New, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "FirewallThreatIntelWhitelist", SupportsShouldProcess = true), OutputType(typeof(PSAzureFirewallThreatIntelWhitelist))]
+    [Cmdlet(VerbsCommon.New, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "FirewallThreatIntelWhitelist"), OutputType(typeof(PSAzureFirewallThreatIntelWhitelist))]
+    [Alias("New-AzFirewallThreatIntelWhitelistObject")]
     public class NewAzureFirewallThreatIntelWhitelistCommand : AzureFirewallBaseCmdlet
     {
         [Parameter(

src/Network/Network/Models/AzureFirewall/PSAzureFirewallThreatIntelWhitelist.cs

@@ -52,9 +52,10 @@ private void ValidateFqdns(string[] fqdns)
         {
             if (fqdns == null)
                 return;
+
+            var matchingRegEx = new Regex(SecureGatewayThreatIntelFqdnRegex);
             foreach (var fqdn in fqdns)
             {
-                var matchingRegEx = new Regex(SecureGatewayThreatIntelFqdnRegex);
                 if (!matchingRegEx.IsMatch(fqdn))
                 {
                     throw new PSArgumentException(String.Format("\'{0}\' is not a valid threat intel whitelist FQDN", fqdn));
@@ -66,6 +67,7 @@ private void ValidateIpAddresses(string[] ipAddresses)
         {
             if (ipAddresses == null)
                 return;
+
             foreach (var ip in ipAddresses)
             {
                 IPAddress ipVal;

src/Network/Network/help/Az.Network.md

@@ -141,7 +141,7 @@ Adds a VPN client root certificate.
 Approves a private endpoint connection.
 
 ### [Deny-AzPrivateEndpointConnection](Deny-AzPrivateEndpointConnection.md)
-denies a private endpoint connection.
+Denies a private endpoint connection.
 
 ### [Get-AzApplicationGateway](Get-AzApplicationGateway.md)
 Gets an application gateway.

src/Network/Network/help/Get-AzFirewall.md

@@ -315,7 +315,7 @@ Required: False
 Position: Named
 Default value: None
 Accept pipeline input: True (ByPropertyName)
-Accept wildcard characters: False
+Accept wildcard characters: True
 ```
 
 ### CommonParameters

src/Network/Network/help/New-AzFirewall.md

@@ -160,6 +160,18 @@ New-AzFirewall -Name "azFw" -ResourceGroupName $rgName -Location centralus -Sku
 
 This example creates a Firewall attached to virtual hub "vHub". A firewall policy $fp will be attached to the firewall. This firewall allows/denies the traffic based on the rules mentioned in the firewall policy $fp. The virtual hub and the firewall should be in the same regions.
 
+### 10: Create a Firewall with threat intelligence whitelist setup
+```
+$rgName = "resourceGroupName"
+$vnet = Get-AzVirtualNetwork -ResourceGroupName $rgName -Name "vnet"
+$pip = Get-AzPublicIpAddress -ResourceGroupName $rgName -Name "publicIpName"
+
+$tiWhitelist = New-AzFirewallThreatIntelWhitelist -FQDN @("www.microsoft.com") -IpAddresses @("8.8.8.8")
+New-AzFirewall -Name "azFw" -ResourceGroupName $rgName -Location centralus -VirtualNetwork $vnet -PublicIpAddress $pip -ThreatIntelWhitelist $tiWhitelist
+```
+
+This example creates a Firewall that whitelist "www.microsoft.com" and "8.8.8.8" from threat intelligence
+
 ## PARAMETERS
 
 ### -ApplicationRuleCollection
@@ -402,7 +414,7 @@ Aliases:
 Required: False
 Position: Named
 Default value: None
-Accept pipeline input: True (ByPropertyName)
+Accept pipeline input: False
 Accept wildcard characters: False
 ```
 

src/Network/Network/help/New-AzFirewallThreatIntelWhitelist.md

@@ -14,11 +14,11 @@ Create a new threat intelligence whitelist for Azure Firewall
 
 ```
 New-AzFirewallThreatIntelWhitelist [-FQDN <String[]>] [-IpAddress <String[]>]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
-The **New-AzFirewallThreatIntelWhitelist** cmdlet creates a threat intel whitelist for Azure Firewall.
+The **New-AzFirewallThreatIntelWhitelist** cmdlet creates a threat intel whitelist object, which can be used when creating or setting an Azure Firewall.
 
 ## EXAMPLES
 
@@ -76,37 +76,6 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -Confirm
-Prompts you for confirmation before running the cmdlet.
-
-```yaml
-Type: System.Management.Automation.SwitchParameter
-Parameter Sets: (All)
-Aliases: cf
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
-### -WhatIf
-Shows what would happen if the cmdlet runs.
-The cmdlet is not run.
-
-```yaml
-Type: System.Management.Automation.SwitchParameter
-Parameter Sets: (All)
-Aliases: wi
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### CommonParameters
 This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).