Bug fixes and modifications

Author: NehaRaje

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Commands.RecoveryServices.csproj

@@ -142,6 +142,9 @@
     <Compile Include="PSRecoveryServicesClient\PSRecoveryServicesVMClient.cs" />
     <Compile Include="RecoveryServicesCmdletBase.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
+    <Compile Include="Service\SetAzureSiteRecoveryProtectionProfile.cs" />
+    <Compile Include="Service\StartAzureSiteRecoveryProtectionProfileDissociationJob.cs" />
+    <Compile Include="Service\StartAzureSiteRecoveryProtectionProfileAssociationJob.cs" />
     <Compile Include="Service\CreateAzureSiteRecoveryProtectionProfileObject.cs" />
     <Compile Include="Service\CreateAzureSiteRecoveryVault.cs" />
     <Compile Include="Service\GetAzureSiteRecoveryStorage.cs" />

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.Designer.cs

@@ -209,4 +209,7 @@ ClientRequestId: {3}</value>
   <data name="VaultCreationSuccessMessage" xml:space="preserve">
     <value>Vault has been created</value>
   </data>
+  <data name="ReplicationStartTimeInvalid" xml:space="preserve">
+    <value>Replication Start Time span value cannot be greater then 24 hours.</value>
+  </data>
 </root>

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.resx

@@ -33,7 +33,8 @@ public class CreateAzureSiteRecoveryProtectionProfileObject : RecoveryServicesCm
         /// <summary>
         /// Gets or sets Replication Provider of the Protection Profile.
         /// </summary>
-        [Parameter(ParameterSetName = ASRParameterSets.Default, Mandatory = true)]
+        [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToEnterprise, Mandatory = true)]
+        [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToAzure, Mandatory = true)]
         [ValidateNotNullOrEmpty]
         [ValidateSet(
             Constants.HyperVReplica,
@@ -94,8 +95,7 @@ public class CreateAzureSiteRecoveryProtectionProfileObject : RecoveryServicesCm
         /// </summary>
         [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToEnterprise, Mandatory = true)]
         [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToAzure, Mandatory = true)]
-        [ValidateNotNullOrEmpty]
-        public bool CompressionEnabled { get; set; }
+        public SwitchParameter CompressionEnabled { get; set; }
 
         /// <summary>
         /// Gets or sets the Replication Port of the Protection Profile.
@@ -119,8 +119,7 @@ public class CreateAzureSiteRecoveryProtectionProfileObject : RecoveryServicesCm
         /// </summary>
         [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToEnterprise, Mandatory = true)]
         [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToAzure, Mandatory = true)]
-        [ValidateNotNullOrEmpty]
-        public bool AllowReplicaDeletion { get; set; }
+        public SwitchParameter AllowReplicaDeletion { get; set; }
 
         #endregion Parameters
 
@@ -168,6 +167,8 @@ private void EnterpriseToAzureProtectionProfileObject()
             // Verify whether the subscription is associated with the account or not.
             PSRecoveryServicesClientHelper.ValidateSubscriptionAccountAssociation(this.RecoveryAzureSubscription);
 
+            this.ValidateReplicationStartTime(this.ReplicationStartTime);
+
             ASRProtectionProfile protectionProfile = new ASRProtectionProfile()
             {
                 ReplicationProvider = this.ReplicationProvider,
@@ -190,11 +191,31 @@ private void EnterpriseToAzureProtectionProfileObject()
             this.WriteObject(protectionProfile);
         }
 
+        /// <summary>
+        /// Validates if the time span object has a valid value.
+        /// </summary>
+        /// <param name="timeSpan">Time span object to be validated</param>
+        private void ValidateReplicationStartTime(TimeSpan? timeSpan)
+        {
+            if (timeSpan == null)
+            {
+                return;
+            }
+
+            if (TimeSpan.Compare(timeSpan.Value, new TimeSpan(24, 0, 0)) == 1)
+            {
+                throw new InvalidOperationException(
+                    string.Format(Properties.Resources.ReplicationStartTimeInvalid));
+            }
+        }
+
         /// <summary>
         /// Creates an E2E Protection Profile object
         /// </summary>
         private void EnterpriseToEnterpriseProtectionProfileObject()
         {
+            this.ValidateReplicationStartTime(this.ReplicationStartTime);
+
             ASRProtectionProfile protectionProfile = new ASRProtectionProfile()
             {
                 ReplicationProvider = this.ReplicationProvider,

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/CreateAzureSiteRecoveryProtectionProfileObject.cs

@@ -29,13 +29,13 @@ namespace Microsoft.Azure.Commands.RecoveryServices
     [OutputType(typeof(ASRJob))]
     public class SetAzureSiteRecoveryProtectionProfile : RecoveryServicesCmdletBase
     {
-        #region Parameters
-
         /// <summary>
         /// Job response.
         /// </summary>
         private JobResponse jobResponse = null;
 
+        #region Parameters
+
         /// <summary>
         /// Gets or sets Protection Profile object.
         /// </summary>

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/SetAzureSiteRecoveryProtectionProfile.cs

@@ -27,13 +27,13 @@ namespace Microsoft.Azure.Commands.RecoveryServices
     [OutputType(typeof(ASRJob))]
     public class StartAzureSiteRecoveryProtectionProfileJob : RecoveryServicesCmdletBase
     {
-        #region Parameters
-
         /// <summary>
         /// Job response.
         /// </summary>
         private JobResponse jobResponse = null;
 
+        #region Parameters
+
         /// <summary>
         /// Gets or sets Protection Container to be applied the Protection Profile settings on.
         /// </summary>

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/StartAzureSiteRecoveryProtectionProfileAssociationJob.cs

@@ -26,13 +26,13 @@ namespace Microsoft.Azure.Commands.RecoveryServices
     [OutputType(typeof(ASRJob))]
     public class StartAzureSiteRecoveryProtectionProfileDissociationJob : RecoveryServicesCmdletBase
     {
-        #region Parameters
-
         /// <summary>
         /// Job response.
         /// </summary>
         private JobResponse jobResponse = null;
 
+        #region Parameters
+
         /// <summary>
         /// Gets or sets Protection Container to be removed the Protection Profile settings off.
         /// </summary>