FW: Implement PR comments from SDK team

gucalder · gucalder · commit ecd90ccf6bed · 2016-02-26T16:19:04.000-08:00
diff --git a/src/ResourceManager/Insights/Commands.Insights.Test/packages.config b/src/ResourceManager/Insights/Commands.Insights.Test/packages.config
@@ -24,6 +24,7 @@
   <package id="System.Spatial" version="5.6.4" targetFramework="net45" />
   <package id="WindowsAzure.Storage" version="6.0.0" targetFramework="net45" />
   <package id="xunit" version="2.1.0" targetFramework="net45" />
+  <package id="xunit.abstractions" version="2.0.0" targetFramework="net45" /> 
   <package id="xunit.assert" version="2.1.0" targetFramework="net45" />
   <package id="xunit.core" version="2.1.0" targetFramework="net45" />
   <package id="xunit.extensibility.core" version="2.1.0" targetFramework="net45" />
diff --git a/src/ResourceManager/Insights/Commands.Insights/Alerts/AddAlertRuleCommandBase.cs b/src/ResourceManager/Insights/Commands.Insights/Alerts/AddAlertRuleCommandBase.cs
@@ -116,7 +116,7 @@ public abstract class AddAlertRuleCommandBase : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             RuleCreateOrUpdateParameters parameters = this.CreateSdkCallParameters();
 
diff --git a/src/ResourceManager/Insights/Commands.Insights/Alerts/GetAlertHistoryCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Alerts/GetAlertHistoryCommand.cs
@@ -71,7 +71,7 @@ protected override bool KeepTheRecord(EventData record)
         /// <returns>Modified query filter including the condition for eventSource</returns>
         protected override string ProcessParticularParameters(string currentQueryFilter)
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             // Make sure only events for alerts come back
             return this.AddConditionIfPResent(currentQueryFilter, "eventSource", AlertsEventSourceName);
diff --git a/src/ResourceManager/Insights/Commands.Insights/Alerts/GetAlertRuleCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Alerts/GetAlertRuleCommand.cs
@@ -71,7 +71,7 @@ public class GetAlertRuleCommand : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             if (string.IsNullOrWhiteSpace(this.Name))
             {
diff --git a/src/ResourceManager/Insights/Commands.Insights/Alerts/RemoveAlertRuleCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Alerts/RemoveAlertRuleCommand.cs
@@ -49,7 +49,7 @@ public class RemoveAlertRuleCommand : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             AzureOperationResponse result = this.InsightsManagementClient.AlertOperations.DeleteRuleAsync(resourceGroupName: this.ResourceGroup, ruleName: this.Name).Result;
             WriteObject(result);
diff --git a/src/ResourceManager/Insights/Commands.Insights/Autoscale/AddAutoscaleSettingCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Autoscale/AddAutoscaleSettingCommand.cs
@@ -93,7 +93,7 @@ public class AddAutoscaleSettingCommand : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             AutoscaleSettingCreateOrUpdateParameters parameters = this.CreateSdkCallParameters();
 
diff --git a/src/ResourceManager/Insights/Commands.Insights/Autoscale/GetAutoscaleHistoryCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Autoscale/GetAutoscaleHistoryCommand.cs
@@ -71,7 +71,7 @@ protected override bool KeepTheRecord(EventData record)
         /// <returns>Modified query filter including the condition for eventSource</returns>
         protected override string ProcessParticularParameters(string currentQueryFilter)
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             return this.AddConditionIfPResent(currentQueryFilter, "category", AutoscaleEventSourceName);
         }
diff --git a/src/ResourceManager/Insights/Commands.Insights/Autoscale/GetAutoscaleSettingCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Autoscale/GetAutoscaleSettingCommand.cs
@@ -58,7 +58,7 @@ public class GetAutoscaleSettingCommand : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             if (string.IsNullOrWhiteSpace(this.Name))
             {
diff --git a/src/ResourceManager/Insights/Commands.Insights/Autoscale/NewAutoscaleProfileCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Autoscale/NewAutoscaleProfileCommand.cs
@@ -136,7 +136,7 @@ public class NewAutoscaleProfileCommand : AzureRMCmdlet
         /// </summary>
         public override void ExecuteCmdlet()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             AutoscaleProfile profile = this.CreateSettingProfile();
             WriteObject(profile);
diff --git a/src/ResourceManager/Insights/Commands.Insights/Autoscale/NewAutoscaleRuleCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Autoscale/NewAutoscaleRuleCommand.cs
@@ -113,7 +113,7 @@ public class NewAutoscaleRuleCommand : AzureRMCmdlet
         /// </summary>
         public override void ExecuteCmdlet()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             ScaleRule rule = this.CreateSettingRule();
             WriteObject(rule);
diff --git a/src/ResourceManager/Insights/Commands.Insights/Autoscale/RemoveAutoscaleSettingCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Autoscale/RemoveAutoscaleSettingCommand.cs
@@ -48,7 +48,7 @@ public class RemoveAutoscaleSettingCommand : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             AzureOperationResponse result = this.InsightsManagementClient.AutoscaleOperations.DeleteSettingAsync(resourceGroupName: this.ResourceGroup, autoscaleSettingName: this.Name).Result;
             WriteObject(result);
diff --git a/src/ResourceManager/Insights/Commands.Insights/ManagementCmdletBase.cs b/src/ResourceManager/Insights/Commands.Insights/ManagementCmdletBase.cs
@@ -35,7 +35,8 @@ public abstract class ManagementCmdletBase : InsightsCmdletBase
         /// </summary>
         public IInsightsManagementClient InsightsManagementClient
         {
-            // The premise is that a command to establish a context (like Add-AzureRmAccount) has been called before this command in order to have a correct CurrentContext
+            // The premise is that a command to establish a context (like Add-AzureRmAccount) has
+            //   been called before this command in order to have a correct CurrentContext
             get {
                 if (this.insightsManagementClient == null)
                 {
diff --git a/src/ResourceManager/Insights/Commands.Insights/Metrics/FormatMetricsAsTableCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Metrics/FormatMetricsAsTableCommand.cs
@@ -76,7 +76,7 @@ public PSMetricTabularResult[] ProcessParameter()
         /// </summary>
         public override void ExecuteCmdlet()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             WriteObject(this.ProcessParameter());
         }
diff --git a/src/ResourceManager/Insights/Commands.Insights/Metrics/GetMetricDefinitionsCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Metrics/GetMetricDefinitionsCommand.cs
@@ -70,7 +70,7 @@ protected string ProcessParameters()
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             string queryFilter = this.ProcessParameters();
             bool fullDetails = this.DetailedOutput.IsPresent;
diff --git a/src/ResourceManager/Insights/Commands.Insights/Metrics/GetMetricsCommand.cs b/src/ResourceManager/Insights/Commands.Insights/Metrics/GetMetricsCommand.cs
@@ -127,7 +127,7 @@ protected string ProcessParameters()
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             string queryFilter = this.ProcessParameters();
             bool fullDetails = this.DetailedOutput.IsPresent;
diff --git a/src/ResourceManager/Insights/Commands.Insights/UsageMetrics/GetUsageMetricsCommand.cs b/src/ResourceManager/Insights/Commands.Insights/UsageMetrics/GetUsageMetricsCommand.cs
@@ -121,7 +121,7 @@ protected string ProcessParameters()
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");
+            WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");
 
             string queryFilter = this.ProcessParameters();
             string apiVersion = this.ApiVersion ?? DefaultApiVersion;
diff --git a/src/ResourceManager/Insights/Insights.sln b/src/ResourceManager/Insights/Insights.sln
@@ -12,6 +12,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Insights.Test", "C
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.ScenarioTests.ResourceManager.Common", "..\Common\Commands.ScenarioTests.ResourceManager.Common\Commands.ScenarioTests.ResourceManager.Common.csproj", "{3436A126-EDC9-4060-8952-9A1BE34CDD95}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Profile", "..\Profile\Commands.Profile\Commands.Profile.csproj", "{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}"
+EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common", "..\..\Common\Commands.Common\Commands.Common.csproj", "{5EE72C53-1720-4309-B54B-5FB79703195F}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common.Authentication", "..\..\Common\Commands.Common.Authentication\Commands.Common.Authentication.csproj", "{D3804B64-C0D3-48F8-82EC-1F632F833C9E}"
@@ -38,6 +40,10 @@ Global
 		{3436A126-EDC9-4060-8952-9A1BE34CDD95}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{3436A126-EDC9-4060-8952-9A1BE34CDD95}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{3436A126-EDC9-4060-8952-9A1BE34CDD95}.Release|Any CPU.Build.0 = Release|Any CPU
+		{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Release|Any CPU.Build.0 = Release|Any CPU
 		{5EE72C53-1720-4309-B54B-5FB79703195F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{5EE72C53-1720-4309-B54B-5FB79703195F}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{5EE72C53-1720-4309-B54B-5FB79703195F}.Release|Any CPU.ActiveCfg = Release|Any CPU

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public abstract class AddAlertRuleCommandBase : ManagementCmdletBase`
`116`	`116`	`/// </summary>`
`117`	`117`	`protected override void ProcessRecordInternal()`
`118`	`118`	`{`
`119`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`119`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`120`	`120`
`121`	`121`	`RuleCreateOrUpdateParameters parameters = this.CreateSdkCallParameters();`
`122`	`122`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ protected override bool KeepTheRecord(EventData record)`
`71`	`71`	`/// <returns>Modified query filter including the condition for eventSource</returns>`
`72`	`72`	`protected override string ProcessParticularParameters(string currentQueryFilter)`
`73`	`73`	`{`
`74`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`74`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`75`	`75`
`76`	`76`	`// Make sure only events for alerts come back`
`77`	`77`	`return this.AddConditionIfPResent(currentQueryFilter, "eventSource", AlertsEventSourceName);`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ public class GetAlertRuleCommand : ManagementCmdletBase`
`71`	`71`	`/// </summary>`
`72`	`72`	`protected override void ProcessRecordInternal()`
`73`	`73`	`{`
`74`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`74`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`75`	`75`
`76`	`76`	`if (string.IsNullOrWhiteSpace(this.Name))`
`77`	`77`	`{`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public class RemoveAlertRuleCommand : ManagementCmdletBase`
`49`	`49`	`/// </summary>`
`50`	`50`	`protected override void ProcessRecordInternal()`
`51`	`51`	`{`
`52`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`52`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`53`	`53`
`54`	`54`	`AzureOperationResponse result = this.InsightsManagementClient.AlertOperations.DeleteRuleAsync(resourceGroupName: this.ResourceGroup, ruleName: this.Name).Result;`
`55`	`55`	`WriteObject(result);`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public class AddAutoscaleSettingCommand : ManagementCmdletBase`
`93`	`93`	`/// </summary>`
`94`	`94`	`protected override void ProcessRecordInternal()`
`95`	`95`	`{`
`96`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`96`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`97`	`97`
`98`	`98`	`AutoscaleSettingCreateOrUpdateParameters parameters = this.CreateSdkCallParameters();`
`99`	`99`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public class GetAutoscaleSettingCommand : ManagementCmdletBase`
`58`	`58`	`/// </summary>`
`59`	`59`	`protected override void ProcessRecordInternal()`
`60`	`60`	`{`
`61`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`61`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`62`	`62`
`63`	`63`	`if (string.IsNullOrWhiteSpace(this.Name))`
`64`	`64`	`{`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ public class NewAutoscaleProfileCommand : AzureRMCmdlet`
`136`	`136`	`/// </summary>`
`137`	`137`	`public override void ExecuteCmdlet()`
`138`	`138`	`{`
`139`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`139`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`140`	`140`
`141`	`141`	`AutoscaleProfile profile = this.CreateSettingProfile();`
`142`	`142`	`WriteObject(profile);`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public class NewAutoscaleRuleCommand : AzureRMCmdlet`
`113`	`113`	`/// </summary>`
`114`	`114`	`public override void ExecuteCmdlet()`
`115`	`115`	`{`
`116`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`116`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`117`	`117`
`118`	`118`	`ScaleRule rule = this.CreateSettingRule();`
`119`	`119`	`WriteObject(rule);`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public class RemoveAutoscaleSettingCommand : ManagementCmdletBase`
`48`	`48`	`/// </summary>`
`49`	`49`	`protected override void ProcessRecordInternal()`
`50`	`50`	`{`
`51`		`- WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.\n\r");`
	`51`	`+ WriteWarning("This cmdlet is being modified to enable better experience and may contain breaking changes in a future release.");`
`52`	`52`
`53`	`53`	`AzureOperationResponse result = this.InsightsManagementClient.AutoscaleOperations.DeleteSettingAsync(resourceGroupName: this.ResourceGroup, autoscaleSettingName: this.Name).Result;`
`54`	`54`	`WriteObject(result);`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,8 @@ public abstract class ManagementCmdletBase : InsightsCmdletBase`
`35`	`35`	`/// </summary>`
`36`	`36`	`public IInsightsManagementClient InsightsManagementClient`
`37`	`37`	`{`
`38`		`- // The premise is that a command to establish a context (like Add-AzureRmAccount) has been called before this command in order to have a correct CurrentContext`
	`38`	`+ // The premise is that a command to establish a context (like Add-AzureRmAccount) has`
	`39`	`+ // been called before this command in order to have a correct CurrentContext`
`39`	`40`	`get {`
`40`	`41`	`if (this.insightsManagementClient == null)`
`41`	`42`	`{`