Addressing static analysis failures

Author: Vini Soto

src/ResourceManager/Websites/Commands.Websites/Cmdlets/WebApps/EnterAzureRmWebAppContainerPSSession.cs

@@ -18,9 +18,13 @@ namespace Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps
     /// <summary>
     /// this commandlet will create remote ps session with site
     /// </summary>
-    [Cmdlet("Enter", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppContainerPSSession")]
+    [Cmdlet("Enter", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppContainerPSSession", DefaultParameterSetName = ParameterSet1Name, SupportsShouldProcess = true)]
+    [OutputType(typeof(void))]
     public class EnterAzureRmWebAppContainerPSSession : WebAppBaseCmdlet
     {
+        [Parameter(Mandatory = false, HelpMessage = "Return a value indicating success or failure")]
+        public SwitchParameter PassThru { get; set; }
+
         [Parameter(ParameterSetName = ParameterSet1Name, Position = 1, Mandatory = false, HelpMessage = "The name of the web app slot.", ValueFromPipelineByPropertyName = true)]
         [ValidateNotNullOrEmpty]
         public string SlotName { get; set; }
@@ -34,7 +38,10 @@ public override void ExecuteCmdlet()
                 Name = name;
                 SlotName = slot;
             }
-            WebsitesClient.RunWebAppContainerPSSessionScript(this, ResourceGroupName, Name, SlotName);
+            if (ShouldProcess(Properties.Resources.EnterPSSessionWarning))
+            {
+                WebsitesClient.RunWebAppContainerPSSessionScript(this, ResourceGroupName, Name, SlotName);
+            }
         }
     }
 }

src/ResourceManager/Websites/Commands.Websites/Cmdlets/WebApps/GetAzureRMWebAppContainerContinuousDeploymentUrl.cs

@@ -17,7 +17,7 @@ namespace Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps
     /// <summary>
     /// this commandlet will return ContainerContinuousDeploymentUrl
     /// </summary>
-    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppContainerContinuousDeploymentUrl")]
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppContainerContinuousDeploymentUrl", DefaultParameterSetName = ParameterSet1Name)]
     [OutputType(typeof(string))]
     public class GetAzureRMWebAppContainerContinuousDeploymentUrl : WebAppBaseCmdlet
     {

src/ResourceManager/Websites/Commands.Websites/Cmdlets/WebApps/NewAzureRmWebAppContainerPSSession.cs

@@ -18,7 +18,7 @@ namespace Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps
     /// <summary>
     /// this commandlet will create remote ps session with site
     /// </summary>
-    [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppContainerPSSession")]
+    [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppContainerPSSession", DefaultParameterSetName = ParameterSet1Name, SupportsShouldProcess = true)]
     [OutputType(typeof(System.Management.Automation.Runspaces.PSSession))]
     public class NewAzureRmWebAppContainerPSSession : WebAppBaseCmdlet
     {
@@ -35,7 +35,10 @@ public override void ExecuteCmdlet()
                 Name = name;
                 SlotName = slot;
             }
-            WebsitesClient.RunWebAppContainerPSSessionScript(this, ResourceGroupName, Name, SlotName, true);
+            if (ShouldProcess(Properties.Resources.EnterPSSessionWarning))
+            {
+                WebsitesClient.RunWebAppContainerPSSessionScript(this, ResourceGroupName, Name, SlotName, true);
+            }
         }
     }
 }

src/ResourceManager/Websites/Commands.Websites/Properties/Resources.Designer.cs

@@ -162,4 +162,7 @@
     <value>Failed to add git remote to directory '{0}' with error '{1}'</value>
     <comment>{0} = directory, {1} = error message</comment>
   </data>
+  <data name="EnterPSSessionWarning" xml:space="preserve">
+    <value>This will modify LocalHost\Client\TrustedHosts and LocalHost\Client\Auth policy. Continue?</value>
+  </data>
 </root>