updated review comments

Author: Ajit Navasare (MINDTREE LIMITED)

src/ResourceManager/ServiceBus/ChangeLog.md

@@ -20,7 +20,8 @@
 -->
 ## Current Release
 
-* Bug fix : some properties were not updated beacuse of the space inserted in swagger spec. 
+* Bug fix : some properties of Queue object were not updated beacuse of the space inserted in there name in swagger spec. 
+		- e.g. not able to set value for MaxDeliveryCount, lockDuration, entityAvailabilityStatus, duplicateDetectionHistoryTimeWindow, maxDeliveryCount, messageCount,entityAvailabilityStatus and duplicateDetectionHistoryTimeWindow properties of Queue object.
 
 ## Version 0.2.0
 

src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Queue/SetAzureServiceBusQueue.cs

@@ -56,10 +56,13 @@ public override void ExecuteCmdlet()
         {
             QueueAttributes queueAttributes = new QueueAttributes();
 
-            NamespaceAttributes getNamespaceLoc = Client.GetNamespace(ResourceGroup, NamespaceName);
-            QueueObj.Location = getNamespaceLoc.Location;
-            queueAttributes = QueueObj;
-            
+            if (QueueObj != null)
+               {
+                NamespaceAttributes getNamespaceLoc = Client.GetNamespace(ResourceGroup, NamespaceName);
+                QueueObj.Location = getNamespaceLoc.Location;
+                queueAttributes = QueueObj;
+               }
+
             if (ShouldProcess(target: QueueName, action: string.Format("Updating Queue:{0} of the NameSpace:{1}", QueueName, NamespaceName)))
             {
                 WriteObject(Client.CreateUpdateQueue(ResourceGroup, NamespaceName, queueAttributes.Name, queueAttributes));

src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/QueueAttributes.cs

@@ -52,6 +52,7 @@ public QueueAttributes(QueueResource quResource)
                 Status = quResource.Status;
                 SupportOrdering = quResource.SupportOrdering;
                 UpdatedAt = quResource.UpdatedAt;
+
             }
         }
 

src/ResourceManager/ServiceBus/Commands.ServiceBus/Utilities/ServiceBusClient.cs

@@ -59,16 +59,13 @@ public NamespaceAttributes GetNamespace(string resourceGroupName, string namespa
         public IEnumerable<NamespaceAttributes> ListNamespaces(string resourceGroupName)
         {
             Rest.Azure.IPage<NamespaceResource> response = Client.Namespaces.ListByResourceGroup(resourceGroupName);
-            //IEnumerable<NamespaceAttributes> resourceList = response.Select(resource => new NamespaceAttributes(resourceGroupName, resource));
             IEnumerable<NamespaceAttributes> resourceList = response.Select(resource => new NamespaceAttributes(resource));
             return resourceList;
         }
 
         public IEnumerable<NamespaceAttributes> ListAllNamespaces()
         {
             Rest.Azure.IPage<NamespaceResource> response = Client.Namespaces.ListBySubscription();
-
-            //var resourceList = response.Select(resource => new NamespaceAttributes(null, resource));
             var resourceList = response.Select(resource => new NamespaceAttributes(resource));
             return resourceList;
         }
@@ -253,7 +250,6 @@ public QueueAttributes UpdateQueue(string resourceGroupName, string namespaceNam
         public IEnumerable<QueueAttributes> ListQueues(string resourceGroupName, string namespaceName)
         {
             Rest.Azure.IPage<QueueResource> response = Client.Queues.ListAll(resourceGroupName, namespaceName);
-            //IEnumerable<NamespaceAttributes> resourceList = response.Select(resource => new NamespaceAttributes(resourceGroupName, resource));
             IEnumerable<QueueAttributes> resourceList = response.Select(resource => new QueueAttributes(resource));
             return resourceList;
         }
@@ -374,7 +370,6 @@ public TopicAttributes UpdateTopic(string resourceGroupName, string namespaceNam
         public IEnumerable<TopicAttributes> ListTopics(string resourceGroupName, string namespaceName)
         {
             Rest.Azure.IPage<TopicResource> response = Client.Topics.ListAll(resourceGroupName, namespaceName);
-            //IEnumerable<NamespaceAttributes> resourceList = response.Select(resource => new NamespaceAttributes(resourceGroupName, resource));
             IEnumerable<TopicAttributes> resourceList = response.Select(resource => new TopicAttributes(resource));
             return resourceList;
         }