Skip to content

Commit f3fee01

Browse files
committed
Merge branch 'tesha/FqdnFilteringFqSupport' of https://github.com/tejasshah7/azure-powershell into tesha/FqdnFilteringFqSupport
2 parents a8bf953 + 3fc8dcc commit f3fee01

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

src/Network/Network.Test/ScenarioTests/AzureFirewallFqdnTagTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public AzureFirewallFqdnTagTests(ITestOutputHelper output)
2727
{
2828
}
2929

30-
[Fact(Skip = "skip")]
30+
[Fact]
3131
[Trait(Category.AcceptanceType, Category.CheckIn)]
3232
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
3333
public void TestListAzureFirewallFqdnTag()

src/Network/Network.Test/ScenarioTests/AzureFirewallPolicyTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public AzureFirewallPolicyTests(ITestOutputHelper output)
2626
{
2727
}
2828

29-
[Fact(Skip = "skip")]
29+
[Fact]
3030
[Trait(Category.AcceptanceType, Category.CheckIn)]
3131
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
3232
public void TestAzureFirewallPolicyCRUD()

src/Network/Network.Test/ScenarioTests/AzureFirewallTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,23 +42,23 @@ public void TestAzureFirewallCRUDWithZones()
4242
TestRunner.RunTestScript("Test-AzureFirewallCRUDWithZones");
4343
}
4444

45-
[Fact(Skip ="skip")]
45+
[Fact]
4646
[Trait(Category.AcceptanceType, Category.CheckIn)]
4747
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
4848
public void TestAzureFirewallPIPAndVNETObjectTypeParams()
4949
{
5050
TestRunner.RunTestScript("Test-AzureFirewallPIPAndVNETObjectTypeParams");
5151
}
5252

53-
[Fact(Skip = "skip")]
53+
[Fact]
5454
[Trait(Category.AcceptanceType, Category.CheckIn)]
5555
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
5656
public void TestAzureFirewallAllocateAndDeallocate()
5757
{
5858
TestRunner.RunTestScript("Test-AzureFirewallAllocateAndDeallocate");
5959
}
6060

61-
[Fact(Skip = "skip")]
61+
[Fact]
6262
[Trait(Category.AcceptanceType, Category.CheckIn)]
6363
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
6464
public void TestAzureFirewallVirtualHubCRUD()

src/Network/Network/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
- Update-AzureRmVpnConnection : added parameter EnableInternetSecurity
4444
- New-AzureRmExpressRouteConnection : added parameter EnableInternetSecurity
4545
- Set-AzureRmExpressRouteConnection : added parameter EnableInternetSecurity
46+
* Fix required subnet with name AzureBastionSubnet in `PSBastion` can be case insensitive
4647
* Support for Destination FQDNs in Network Rules and Translated FQDN in NAT Rules for Azure Firewall
4748

4849
## Version 1.15.0

src/Network/Network/Models/Bastion/PSBastion.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public void Allocate(PSVirtualNetwork virtualNetwork, PSPublicIpAddress publicIp
5353
PSSubnet BastionSubnet = null;
5454
try
5555
{
56-
BastionSubnet = virtualNetwork.Subnets.Single(subnet => BastionSubnetName.Equals(subnet.Name));
56+
BastionSubnet = virtualNetwork.Subnets.Single(subnet => BastionSubnetName.Equals(subnet.Name, StringComparison.OrdinalIgnoreCase));
5757
}
5858

5959
catch (InvalidOperationException)

0 commit comments

Comments
 (0)