Skip to content

Commit f4792e4

Browse files
committed
Change parameter Progress to ShowProgress as per design review #100
1 parent 5ea99db commit f4792e4

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/DataPlaneCommands/RemoveAzureRmDataLakeStoreItemAclEntry.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public class RemoveAzureDataLakeStoreItemAclEntry : DataLakeStoreFileSystemCmdle
9898
HelpMessage =
9999
"If passed then progress status is showed. Only applicable when recursive Acl remove is done."
100100
)]
101-
public SwitchParameter Progress { get; set; }
101+
public SwitchParameter ShowProgress { get; set; }
102102

103103
public override void ExecuteCmdlet()
104104
{
@@ -114,7 +114,7 @@ public override void ExecuteCmdlet()
114114
if (Recurse)
115115
{
116116
DataLakeStoreFileSystemClient.ChangeAclRecursively(Path.TransformedPath,
117-
Account, aclSpec, RequestedAclType.RemoveAcl, Concurrency, this, Progress, CmdletCancellationToken);
117+
Account, aclSpec, RequestedAclType.RemoveAcl, Concurrency, this, ShowProgress, CmdletCancellationToken);
118118
}
119119
else
120120
{

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/DataPlaneCommands/SetAzureRmDataLakeStoreItemAcl.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class SetAzureDataLakeStoreItemAcl : DataLakeStoreFileSystemCmdletBase
6969
HelpMessage =
7070
"If passed then progress status is showed. Only applicable when recursive Acl Set is done."
7171
)]
72-
public SwitchParameter Progress { get; set; }
72+
public SwitchParameter ShowProgress { get; set; }
7373

7474
public override void ExecuteCmdlet()
7575
{
@@ -83,7 +83,7 @@ public override void ExecuteCmdlet()
8383
{
8484
DataLakeStoreFileSystemClient.ChangeAclRecursively(Path.TransformedPath,
8585
Account,
86-
Acl.Select(entry => entry.ParseDataLakeStoreItemAce()).ToList(), RequestedAclType.SetAcl, Concurrency, this, Progress, CmdletCancellationToken);
86+
Acl.Select(entry => entry.ParseDataLakeStoreItemAce()).ToList(), RequestedAclType.SetAcl, Concurrency, this, ShowProgress, CmdletCancellationToken);
8787
}
8888
else
8989
{

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/DataPlaneCommands/SetAzureRmDataLakeStoreItemAclEntry.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public class SetAzureDataLakeStoreItemAclEntry : DataLakeStoreFileSystemCmdletBa
9999
HelpMessage =
100100
"If passed then progress status is showed. Only applicable when recursive Acl modify is done."
101101
)]
102-
public SwitchParameter Progress { get; set; }
102+
public SwitchParameter ShowProgress { get; set; }
103103

104104
public override void ExecuteCmdlet()
105105
{
@@ -137,7 +137,7 @@ public override void ExecuteCmdlet()
137137

138138
DataLakeStoreFileSystemClient.ChangeAclRecursively(Path.TransformedPath,
139139
Account,
140-
aclSpec, RequestedAclType.ModifyAcl, Concurrency, this, Progress, CmdletCancellationToken);
140+
aclSpec, RequestedAclType.ModifyAcl, Concurrency, this, ShowProgress, CmdletCancellationToken);
141141
}
142142
else
143143
{

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/help/Remove-AzureRmDataLakeStoreItemAclEntry.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ Removes an entry from the ACL of a file or folder in Data Lake Store.
1616
### RemoveByACLObject (Default)
1717
```
1818
Remove-AzureRmDataLakeStoreItemAclEntry [-Account] <String> [-Path] <DataLakeStorePathInstance>
19-
[-Acl] <DataLakeStoreItemAce[]> [-PassThru] [-Progress] [-Recurse] [-Concurrency <Int32>]
19+
[-Acl] <DataLakeStoreItemAce[]> [-PassThru] [-ShowProgress] [-Recurse] [-Concurrency <Int32>]
2020
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2121
```
2222

2323
### RemoveSpecificACE
2424
```
2525
Remove-AzureRmDataLakeStoreItemAclEntry [-Account] <String> [-Path] <DataLakeStorePathInstance>
26-
[-AceType] <AceType> [[-Id] <Guid>] [-Default] [-PassThru] [-Progress] [-Recurse] [-Concurrency <Int32>]
26+
[-AceType] <AceType> [[-Id] <Guid>] [-Default] [-PassThru] [-ShowProgress] [-Recurse] [-Concurrency <Int32>]
2727
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2828
```
2929

@@ -197,7 +197,7 @@ Accept pipeline input: True (ByPropertyName)
197197
Accept wildcard characters: False
198198
```
199199
200-
### -Progress
200+
### -ShowProgress
201201
If passed then progress status is showed. Only applicable when recursive Acl remove is done.
202202
203203
```yaml

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/help/Set-AzureRmDataLakeStoreItemAcl.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Modifies the ACL of a file or folder in Data Lake Store.
1515

1616
```
1717
Set-AzureRmDataLakeStoreItemAcl [-Account] <String> [-Path] <DataLakeStorePathInstance>
18-
[-Acl] <DataLakeStoreItemAce[]> [-PassThru] [-Progress] [-Recurse] [-Concurrency <Int32>]
18+
[-Acl] <DataLakeStoreItemAce[]> [-PassThru] [-ShowProgress] [-Recurse] [-Concurrency <Int32>]
1919
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2020
```
2121

@@ -136,7 +136,7 @@ Accept pipeline input: True (ByPropertyName)
136136
Accept wildcard characters: False
137137
```
138138
139-
### -Progress
139+
### -ShowProgress
140140
If passed then progress status is showed. Only applicable when recursive Acl set is done.
141141
142142
```yaml

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/help/Set-AzureRmDataLakeStoreItemAclEntry.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ Modifies an entry in the ACL of a file or folder in Data Lake Store.
1616
### SetByACLObject (Default)
1717
```
1818
Set-AzureRmDataLakeStoreItemAclEntry [-Account] <String> [-Path] <DataLakeStorePathInstance>
19-
[-Acl] <DataLakeStoreItemAce[]> [-PassThru] [-Progress] [-Recurse] [-Concurrency <Int32>]
19+
[-Acl] <DataLakeStoreItemAce[]> [-PassThru] [-ShowProgress] [-Recurse] [-Concurrency <Int32>]
2020
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2121
```
2222

2323
### SetSpecificACE
2424
```
2525
Set-AzureRmDataLakeStoreItemAclEntry [-Account] <String> [-Path] <DataLakeStorePathInstance>
26-
[-AceType] <AceType> [[-Id] <Guid>] [-Permissions] <Permission> [-Default] [-PassThru] [-Progress] [-Recurse]
26+
[-AceType] <AceType> [[-Id] <Guid>] [-Permissions] <Permission> [-Default] [-PassThru] [-ShowProgress] [-Recurse]
2727
[-Concurrency <Int32>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2828
```
2929

@@ -221,8 +221,8 @@ Default value: None
221221
Accept pipeline input: True (ByPropertyName)
222222
Accept wildcard characters: False
223223
```
224-
### -Progress
225-
If passed then progress status is showed. Only applicable when recursive Acl modufy is done.
224+
### -ShowProgress
225+
If passed then progress status is showed. Only applicable when recursive Acl modify is done.
226226
227227
```yaml
228228
Type: SwitchParameter

0 commit comments

Comments
 (0)