Skip to content

Commit f6d7616

Browse files
Adding strings to resource file for PsBackupProviderManager.cs
1 parent 7ebc459 commit f6d7616

File tree

4 files changed

+71
-17
lines changed

4 files changed

+71
-17
lines changed

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/CommonModels/Enums.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ public enum ContainerType
3030
public enum BackupManagementType
3131
{
3232
AzureVM = 1,
33-
MARS
33+
MARS,
34+
SCDPM
3435
}
3536

3637
public enum BackupEngineType

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.Designer.cs

Lines changed: 46 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.resx

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,4 +416,19 @@ Please contact Microsoft for further assistant.</value>
416416
<data name="UnsupportedContainerException" xml:space="preserve">
417417
<value>Please provide Container of containerType as Windows and backupManagementType as MARS. Provided Container has containerType {0} and backupManagementType {1} which is invalid.</value>
418418
</data>
419+
<data name="BackupManagementTypeNotExpectedForWorkloadType" xml:space="preserve">
420+
<value>BackupManagementType is not expected for WorkloadType: {0}</value>
421+
</data>
422+
<data name="BackupManagementTypeRequiredForContainerType" xml:space="preserve">
423+
<value>BackupManagementType provider for ContainerType {1} is incorrect.</value>
424+
</data>
425+
<data name="BackupManagementTypeRequiredForWorkloadType" xml:space="preserve">
426+
<value>BackupManagementType is also required for WorkloadType: {0}</value>
427+
</data>
428+
<data name="UnsupportedContainerType" xml:space="preserve">
429+
<value>Unsupported containerType: {0}</value>
430+
</data>
431+
<data name="UnsupportedWorkloadType" xml:space="preserve">
432+
<value>Unsupported workloadType: {0}</value>
433+
</data>
419434
</root>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/PsBackupProviderManager.cs

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.HydraAdapterNS;
1616
using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models;
17+
using Microsoft.Azure.Commands.RecoveryServices.Backup.Properties;
1718
using System;
1819
using System.Collections.Generic;
1920
using System.Linq;
@@ -49,18 +50,10 @@ public IPsBackupProvider GetProviderInstance(ContainerType containerType, Backup
4950
if (backupManagementType == BackupManagementType.MARS)
5051
providerType = PsBackupProviderTypes.Mab;
5152
else
52-
throw new ArgumentException(String.Format("BackupManagementType is required for ContainerType {1}.", backupManagementType.ToString(), containerType));
53+
throw new ArgumentException(String.Format(Resources.BackupManagementTypeRequiredForContainerType, containerType));
5354
break;
54-
//case ContainerType.AzureSqlContainer:
55-
// if (backupManagementType.HasValue)
56-
// {
57-
// throw new ArgumentException("BackupManagementType is not expected for ContainerType: " +
58-
// containerType.ToString());
59-
// }
60-
// providerType = PsBackupProviderTypes.AzureSql;
61-
// break;
6255
default:
63-
throw new ArgumentException("Unsupported containerType: " + containerType.ToString());
56+
throw new ArgumentException(String.Format(Resources.UnsupportedContainerType, containerType.ToString()));
6457
}
6558

6659
return GetProviderInstance(providerType);
@@ -81,8 +74,8 @@ public IPsBackupProvider GetProviderInstance(WorkloadType workloadType)
8174
providerType = PsBackupProviderTypes.IaasVm;
8275
break;
8376
default:
84-
throw new ArgumentException("BackupManagementType is also required for WorkloadType: " +
85-
workloadType.ToString());
77+
throw new ArgumentException(String.Format(Resources.BackupManagementTypeRequiredForWorkloadType,
78+
workloadType.ToString()));
8679
}
8780

8881
return GetProviderInstance(providerType);
@@ -104,13 +97,13 @@ public IPsBackupProvider GetProviderInstance(WorkloadType workloadType, BackupMa
10497
if (backupManagementType.HasValue && backupManagementType != BackupManagementType.AzureVM)
10598
{
10699
// throw exception that it is not expected
107-
throw new ArgumentException("BackupManagementType is not expected for WorkloadType: " +
108-
workloadType.ToString());
100+
throw new ArgumentException(String.Format(Resources.BackupManagementTypeNotExpectedForWorkloadType,
101+
workloadType.ToString()));
109102
}
110103
psProviderType = PsBackupProviderTypes.IaasVm;
111104
break;
112105
default:
113-
throw new ArgumentException("Unsupported workloadType: " + workloadType.ToString());
106+
throw new ArgumentException(String.Format(Resources.UnsupportedWorkloadType, workloadType.ToString()));
114107
}
115108

116109
return GetProviderInstance(psProviderType);

0 commit comments

Comments
 (0)