Address PR comments

Author: antoniowmsft

src/ResourceManager/AzureBatch/ChangeLog.md

@@ -18,12 +18,12 @@
         - Additional information about change #1
 -->
 ## Current Release
+* Release new cmdlet Get-AzureBatchPoolNodeCounts
+* Release new cmdlet Start-AzureBatchComputeNodeServiceLogUpload
 
 ## Version 4.0.7
 * Set minimum dependency of module to PowerShell 5.0
 * Updated New-AzureBatchPool documentation to remove deprecated example
-* Release new cmdlet Get-AzureBatchPoolNodeCounts
-* Release new cmdlet Start-AzureBatchComputeNodeServiceLogUpload
 
 ## Version 4.0.6
 * Updated to the latest version of the Azure ClientRuntime

src/ResourceManager/AzureBatch/Commands.Batch/Commands.Batch.csproj

@@ -61,12 +61,6 @@
       <HintPath>..\..\..\packages\WindowsAzure.Storage.6.2.0\lib\net40\Microsoft.WindowsAzure.Storage.dll</HintPath>
       <Private>True</Private>
     </Reference>
-    <Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Newtonsoft.Json.6.0.8\lib\net45\Newtonsoft.Json.dll</HintPath>
-    </Reference>
-    <Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <SpecificVersion>False</SpecificVersion>
-    </Reference>
     <Reference Include="System.Spatial, Version=5.6.4.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <HintPath>..\..\..\packages\System.Spatial.5.6.4\lib\net40\System.Spatial.dll</HintPath>
     </Reference>

src/ResourceManager/AzureBatch/Commands.Batch/ComputeNodes/StartBatchComputeNodeServiceLogUploadCommand.cs

@@ -37,7 +37,7 @@ public class StartBatchComputeNodeServiceLogUploadCommand : BatchObjectModelCmdl
         [ValidateNotNullOrEmpty]
         public string ComputeNodeId { get; set; }
 
-        [Parameter(Position = 1, ParameterSetName = Constants.ParentObjectParameterSet, ValueFromPipeline = true)]
+        [Parameter(Position = 1, ParameterSetName = Constants.ParentObjectParameterSet, Mandatory = true, ValueFromPipeline = true)]
         [ValidateNotNullOrEmpty]
         public PSComputeNode ComputeNode { get; set; }
 
@@ -51,7 +51,7 @@ public class StartBatchComputeNodeServiceLogUploadCommand : BatchObjectModelCmdl
         [ValidateNotNullOrEmpty]
         public DateTime StartTime { get; set; }
 
-        [Parameter(Position = 4, Mandatory = false,
+        [Parameter(Mandatory = false,
             HelpMessage = "The end of the time range from which to upload Batch Service log file(s).")]
         public DateTime? EndTime { get; set; }
 

src/ResourceManager/AzureBatch/Commands.Batch/Pools/GetBatchPoolNodeCountsCommand.cs

@@ -27,12 +27,12 @@ public class GetBatchPoolNodeCountsCommand : BatchObjectModelCmdletBase
     {
         private const int defaultMaxCount = 10;
 
-        [Parameter(Position = 0, ParameterSetName = Constants.PoolIdParameterSet, Mandatory = false,
+        [Parameter(ParameterSetName = Constants.PoolIdParameterSet, Mandatory = false,
             ValueFromPipelineByPropertyName = true, HelpMessage = "The id of the pool for which to get node counts.")]
         [ValidateNotNullOrEmpty]
         public string PoolId { get; set; }
 
-        [Parameter(Position = 0, ParameterSetName = Constants.ParentObjectParameterSet, 
+        [Parameter(ParameterSetName = Constants.ParentObjectParameterSet, 
             ValueFromPipeline = true, Mandatory = false, HelpMessage = "The pool object for which to get node counts.")]
         [ValidateNotNullOrEmpty]
         public PSCloudPool Pool { get; set; }