Removed status filter from Get-AzRecoveryServicesBackupContainer command

Author: hiaga

src/RecoveryServices/RecoveryServices.Backup.Models/CommonModels/Enums.cs

@@ -199,6 +199,7 @@ public enum ContainerRegistrationStatus
         /// Represents the registered state of the container with the recovery services vault.
         /// </summary>
         Registered = 1,
+        NotRegistered = 2,
     }
 
     /// <summary>

src/RecoveryServices/RecoveryServices.Backup.Providers/AzureWorkloadProviderHelper.cs

@@ -340,28 +340,13 @@ public List<ProtectedItemResource> ListProtectedItemsByContainer(
         {
             string vaultName = (string)providerData[CmdletModel.VaultParams.VaultName];
             string vaultResourceGroupName = (string)providerData[CmdletModel.VaultParams.ResourceGroupName];
-            string friendlyName = (string)providerData[CmdletModel.ContainerParams.FriendlyName];
-            CmdletModel.ContainerRegistrationStatus status =
-                (CmdletModel.ContainerRegistrationStatus)providerData[CmdletModel.ContainerParams.Status];
+            string friendlyName = (string)providerData[CmdletModel.ContainerParams.FriendlyName];            
 
             string nameQueryFilter = friendlyName;
-
-            ODataQuery<ServiceClientModel.BMSContainerQueryObject> queryParams = null;
-            if (status == 0)
-            {
-                queryParams = new ODataQuery<ServiceClientModel.BMSContainerQueryObject>(
+            ODataQuery<ServiceClientModel.BMSContainerQueryObject> queryParams = new ODataQuery<ServiceClientModel.BMSContainerQueryObject>(
                 q => q.FriendlyName == nameQueryFilter &&
                 q.BackupManagementType == backupManagementType);
-            }
-            else
-            {
-                var statusString = status.ToString();
-                queryParams = new ODataQuery<ServiceClientModel.BMSContainerQueryObject>(
-                q => q.FriendlyName == nameQueryFilter &&
-                q.BackupManagementType == backupManagementType &&
-                q.Status == statusString);
-            }
-
+            
             var listResponse = ServiceClientAdapter.ListContainers(
                 queryParams,
                 vaultName: vaultName,

src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Container/GetAzureRmRecoveryServicesBackupContainer.cs

@@ -58,15 +58,7 @@ public class GetAzureRmRecoveryServicesBackupContainer : RSBackupVaultCmdletBase
             HelpMessage = ParamHelpMsgs.Container.ResourceGroupName)]
         [ResourceGroupCompleter]
         [ValidateNotNullOrEmpty]
-        public string ResourceGroupName { get; set; }
-
-        /// <summary>
-        /// Status of the registration of the container with the recovery services vault.
-        /// </summary>
-        [Parameter(Mandatory = false, Position = 5,
-            HelpMessage = ParamHelpMsgs.Container.Status)]
-        [ValidateNotNullOrEmpty]
-        public ContainerRegistrationStatus Status { get; set; }
+        public string ResourceGroupName { get; set; }        
 
         public override void ExecuteCmdlet()
         {
@@ -86,9 +78,10 @@ public override void ExecuteCmdlet()
                     backupManagementTypeNullable = backupManagementType;
                 }
 
-                // Forcing this cmdlet to return only Registered containers for now. 
-                // Once we support containers returning other status types, one can undo this behavior.
-                Status = ContainerRegistrationStatus.Registered;
+                // Currently the containers API doesn't support any status level filtering 
+                // Also the NotRegitered container isn't a valid scenario, so we're not allowing client filtering too
+                // If the filtering is required in future we can add client side filtering                 
+                // Status = ContainerRegistrationStatus.Registered;
 
                 PsBackupProviderManager providerManager =
                     new PsBackupProviderManager(new Dictionary<Enum, object>()
@@ -98,8 +91,7 @@ public override void ExecuteCmdlet()
                         { ContainerParams.ContainerType, ContainerType },
                         { ContainerParams.BackupManagementType, backupManagementTypeNullable },
                         { ContainerParams.FriendlyName, FriendlyName },
-                        { ContainerParams.ResourceGroupName, ResourceGroupName },
-                        { ContainerParams.Status, Status },
+                        { ContainerParams.ResourceGroupName, ResourceGroupName },                        
                     }, ServiceClientAdapter);
 
                 IPsBackupProvider psBackupProvider =