Merge pull request #9434 from MabOneSdk/user/sisi/iaasvmretention

[RecoveryServices] Removed validation for Get-Policy commands

Author: cormacpayne

src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/RetentionPolicyConversions.cs

@@ -67,9 +67,6 @@ public static LongTermRetentionPolicy GetPSLongTermRetentionPolicy(
                 ltrPolicy.YearlySchedule = GetPSLTRYearlySchedule(serviceClientRetPolicy.YearlySchedule, timeZone);
             }
 
-            // safe side validate
-            ltrPolicy.Validate();
-
             return ltrPolicy;
         }
 

src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/IaasVm/PolicyTests.ps1

@@ -19,6 +19,11 @@ $defaultPolicyName = "DefaultPolicy";
 $DefaultSnapshotDays = 2;
 $UpdatedSnapShotDays = 5;
 
+# Test old polices in the VaultId
+$oldResourceGroupName = "shracrg"
+$oldVaultName = "shracsql"
+$oldPolicyName = "iaasvmretentioncheck"
+
 function Test-AzureVMPolicy
 {
 	$location = Get-ResourceGroupLocation
@@ -47,6 +52,11 @@ function Test-AzureVMPolicy
 		Assert-AreEqual $policy.Name $policyName
 		Assert-AreEqual $policy.SnapshotRetentionInDays $DefaultSnapshotDays
 
+		# Get policy to test older policies
+		$oldVault = Get-AzRecoveryServicesVault -ResourceGroupName $oldResourceGroupName -Name $oldVaultName
+		$oldPolicy = Get-AzRecoveryServicesBackupProtectionPolicy -Name $oldPolicyName -VaultId $oldVault.ID
+		Assert-AreEqual $oldPolicy.RetentionPolicy.DailySchedule.DurationCountInDays 1
+		
 		# Get policy
 	    $policy = Get-AzRecoveryServicesBackupProtectionPolicy `
 			-VaultId $vault.ID `