Skip to content

Commit f96032c

Browse files
frankguodongchenfrankguodongchen
committed
address code review feedback
1 parent ad6d675 commit f96032c

24 files changed

+144
-577
lines changed

‎src/ResourceManager/ApplicationInsights/ApplicationInsights.sln

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,8 @@ VisualStudioVersion = 14.0.25420.1
44
MinimumVisualStudioVersion = 10.0.40219.1
55
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.ResourceManager.Common", "..\Common\Commands.ResourceManager.Common\Commands.ResourceManager.Common.csproj", "{3819D8A7-C62C-4C47-8DDD-0332D9CE1252}"
66
EndProject
7-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Resources", "..\Resources\Commands.Resources\Commands.Resources.csproj", "{E1F5201D-6067-430E-B303-4E367652991B}"
8-
EndProject
9-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Tags", "..\Tags\Commands.Tags\Commands.Tags.csproj", "{2493A8F7-1949-4F29-8D53-9D459046C3B8}"
10-
EndProject
11-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common.Storage", "..\..\Common\Commands.Common.Storage\Commands.Common.Storage.csproj", "{65C3A86A-716D-4E7D-AB67-1DB00B3BF72D}"
12-
EndProject
137
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common", "..\..\Common\Commands.Common\Commands.Common.csproj", "{5EE72C53-1720-4309-B54B-5FB79703195F}"
148
EndProject
15-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Storage", "..\..\Storage\Commands.Storage\Commands.Storage.csproj", "{08CF7DA7-0392-4A19-B79B-E1FF67CDB81A}"
16-
EndProject
179
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.ServiceManagement.Common", "..\..\ServiceManagement\Common\Commands.ServiceManagement.Common\Commands.ServiceManagement.Common.csproj", "{CFF09E81-1E31-444E-B4D4-A21E946C29E2}"
1810
EndProject
1911
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{13BB1C60-A70E-4780-ABEF-D5EE36754085}"
@@ -42,26 +34,10 @@ Global
4234
{3819D8A7-C62C-4C47-8DDD-0332D9CE1252}.Debug|Any CPU.Build.0 = Debug|Any CPU
4335
{3819D8A7-C62C-4C47-8DDD-0332D9CE1252}.Release|Any CPU.ActiveCfg = Release|Any CPU
4436
{3819D8A7-C62C-4C47-8DDD-0332D9CE1252}.Release|Any CPU.Build.0 = Release|Any CPU
45-
{E1F5201D-6067-430E-B303-4E367652991B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
46-
{E1F5201D-6067-430E-B303-4E367652991B}.Debug|Any CPU.Build.0 = Debug|Any CPU
47-
{E1F5201D-6067-430E-B303-4E367652991B}.Release|Any CPU.ActiveCfg = Release|Any CPU
48-
{E1F5201D-6067-430E-B303-4E367652991B}.Release|Any CPU.Build.0 = Release|Any CPU
49-
{2493A8F7-1949-4F29-8D53-9D459046C3B8}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
50-
{2493A8F7-1949-4F29-8D53-9D459046C3B8}.Debug|Any CPU.Build.0 = Debug|Any CPU
51-
{2493A8F7-1949-4F29-8D53-9D459046C3B8}.Release|Any CPU.ActiveCfg = Release|Any CPU
52-
{2493A8F7-1949-4F29-8D53-9D459046C3B8}.Release|Any CPU.Build.0 = Release|Any CPU
53-
{65C3A86A-716D-4E7D-AB67-1DB00B3BF72D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
54-
{65C3A86A-716D-4E7D-AB67-1DB00B3BF72D}.Debug|Any CPU.Build.0 = Debug|Any CPU
55-
{65C3A86A-716D-4E7D-AB67-1DB00B3BF72D}.Release|Any CPU.ActiveCfg = Release|Any CPU
56-
{65C3A86A-716D-4E7D-AB67-1DB00B3BF72D}.Release|Any CPU.Build.0 = Release|Any CPU
5737
{5EE72C53-1720-4309-B54B-5FB79703195F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
5838
{5EE72C53-1720-4309-B54B-5FB79703195F}.Debug|Any CPU.Build.0 = Debug|Any CPU
5939
{5EE72C53-1720-4309-B54B-5FB79703195F}.Release|Any CPU.ActiveCfg = Release|Any CPU
6040
{5EE72C53-1720-4309-B54B-5FB79703195F}.Release|Any CPU.Build.0 = Release|Any CPU
61-
{08CF7DA7-0392-4A19-B79B-E1FF67CDB81A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
62-
{08CF7DA7-0392-4A19-B79B-E1FF67CDB81A}.Debug|Any CPU.Build.0 = Debug|Any CPU
63-
{08CF7DA7-0392-4A19-B79B-E1FF67CDB81A}.Release|Any CPU.ActiveCfg = Release|Any CPU
64-
{08CF7DA7-0392-4A19-B79B-E1FF67CDB81A}.Release|Any CPU.Build.0 = Release|Any CPU
6541
{CFF09E81-1E31-444E-B4D4-A21E946C29E2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
6642
{CFF09E81-1E31-444E-B4D4-A21E946C29E2}.Debug|Any CPU.Build.0 = Debug|Any CPU
6743
{CFF09E81-1E31-444E-B4D4-A21E946C29E2}.Release|Any CPU.ActiveCfg = Release|Any CPU

‎src/ResourceManager/ApplicationInsights/AzureRM.ApplicationInsights.psd1

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,9 @@ FunctionsToExport = @()
7474
# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
7575
CmdletsToExport = 'Get-AzureRmApplicationInsights',
7676
'New-AzureRmApplicationInsights',
77-
'Remove-AzureRmApplicationInsights',
78-
'Get-AzureRmApplicationInsightsPricingPlan',
79-
'Set-AzureRmApplicationInsightsPricingPlan',
80-
'Get-AzureRmApplicationInsightsDailyCap',
81-
'Set-AzureRmApplicationInsightsDailyCap',
82-
'Get-AzureRmApplicationInsightsDailyCapStatus',
77+
'Remove-AzureRmApplicationInsights',
78+
'Set-AzureRmApplicationInsightsPricingPlan',
79+
'Set-AzureRmApplicationInsightsDailyCap',
8380
'Get-AzureRmApplicationInsightsContinuousExport',
8481
'Set-AzureRmApplicationInsightsContinuousExport',
8582
'New-AzureRmApplicationInsightsContinuousExport',

‎src/ResourceManager/ApplicationInsights/ChangeLog.md

Lines changed: 20 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -18,37 +18,24 @@
1818
- Additional information about change #1
1919
-->
2020
## Current Release
21+
Add commands to get/create/remove applicaiton insights resource
22+
Get-AzureRmApplicationInsights
23+
New-AzureRmApplicationInsights
24+
Remove-AzureRmApplicationInsights
25+
26+
Add commands to get/update pricing/daily cap of applicaiton insights resource
27+
Get-AzureRmApplicationInsights -IncludeDailyCap
28+
Set-AzureRmApplicationInsightsPricingPlan
29+
Set-AzureRmApplicationInsightsDailyCap
30+
31+
Add commands to get/create/update/remove continuous export of applicaiton insights resource
32+
Get-AzureRmApplicationInsightsContinuousExport
33+
Set-AzureRmApplicationInsightsContinuousExport
34+
New-AzureRmApplicationInsightsContinuousExport
35+
Remove-AzureRmApplicationInsightsContinuousExport
36+
37+
Add commands to get/create/remove api keys of applicaiton insights resoruce
38+
Get-AzureRmApplicationInsightsApiKey
39+
New-AzureRmApplicationInsightsApiKey
40+
Remove-AzureRmApplicationInsightsApiKey
2141

22-
## Version 3.2.0
23-
24-
## Version 3.1.0
25-
* Add AssignIdentity setting support to resource mode storage account cmdlets
26-
- New-AzureRmStorageAccount
27-
- Set-AzureRmStorageAccount
28-
* Add Customer Key Support to resource mode storage account cmdlets
29-
- Set-AzureRmStorageAccount
30-
- New-AzureRmStorageAccountEncryptionKeySource
31-
32-
## Version 3.0.2
33-
34-
## Version 3.0.0
35-
* Upgrade SRP SDK to 6.3.0
36-
* New/Set-AzureRmStorageAccount:Add a new parameter to support EnableHttpsTrafficOnly
37-
* New/Set/Get-AzureRmStorageAccount: Returned Storage Account contains a new attribute EnableHttpsTrafficOnly
38-
39-
## Version 2.8.0
40-
41-
## Version 2.7.0
42-
43-
## Version 2.6.0
44-
* Upgrade Microsoft.Azure.Management.Storage to version 6.1.0-preview
45-
* Add File Encryption features support to resource mode storage account cmdlets
46-
- New-AzureRmStorageAccount
47-
- Set-AzureRmStorageAccount
48-
49-
50-
## Version 2.5.0
51-
52-
## Version 2.4.0
53-
54-
## Version 2.3.0

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights.Test/Commands.ApplicationInsights.Test.csproj

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@
3636
<WarningLevel>4</WarningLevel>
3737
</PropertyGroup>
3838
<ItemGroup>
39-
<Reference Include="Hyak.Common">
40-
<HintPath>..\..\..\packages\Hyak.Common.1.0.3\lib\net45\Hyak.Common.dll</HintPath>
41-
</Reference>
4239
<Reference Include="Microsoft.Azure.Common">
4340
<HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath>
4441
</Reference>
@@ -197,4 +194,5 @@
197194
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
198195
</ItemGroup>
199196
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
197+
<Import Project="..\..\..\..\tools\Common.Dependencies.targets" />
200198
</Project>

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights.Test/packages.config

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="Hyak.Common" version="1.0.3" targetFramework="net45" />
4-
<package id="Microsoft.Azure.Common" version="2.1.0" targetFramework="net45" />
5-
<package id="Microsoft.Azure.Common.Dependencies" version="1.0.0" targetFramework="net45" />
63
<package id="Microsoft.Azure.Gallery" version="2.6.2-preview" targetFramework="net45" />
7-
<package id="Microsoft.Azure.Management.Authorization" version="1.0.0" targetFramework="net45" />
4+
<package id="Microsoft.Azure.Management.Authorization" version="2.0.0" targetFramework="net45" />
85
<package id="Microsoft.Azure.Management.ApplicationInsights" version="0.1.1-preview" targetFramework="net452" />
96
<package id="Microsoft.Azure.Management.Resources" version="2.20.0-preview" targetFramework="net45" />
107
<package id="Microsoft.Azure.Management.Storage" version="6.5.0-preview" targetFramework="net452" />
118
<package id="Microsoft.Azure.Test.Framework" version="1.0.6179.26854-prerelease" targetFramework="net45" />
129
<package id="Microsoft.Azure.Test.HttpRecorder" version="1.7.0" targetFramework="net45" />
13-
<package id="Microsoft.Bcl" version="1.1.9" targetFramework="net45" />
14-
<package id="Microsoft.Bcl.Async" version="1.0.168" targetFramework="net45" />
15-
<package id="Microsoft.Bcl.Build" version="1.0.14" targetFramework="net45" />
1610
<package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
1711
<package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
1812
<package id="Microsoft.Rest.ClientRuntime" version="2.3.8" targetFramework="net452" />

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/ApplicationInsightsBaseCmdlet.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ protected void WriteComponentApiKeys(IEnumerable<ApplicationInsightsComponentAPI
170170
{
171171
List<PSApiKey> output = new List<PSApiKey>();
172172
apiKeys.ForEach(e => output.Add(new PSApiKeyTableView(e)));
173-
WriteObject(output);
173+
WriteObject(output, true);
174174
}
175175
}
176176

@@ -188,7 +188,7 @@ protected void WriteComponentExportConfiguration(IEnumerable<ApplicationInsights
188188
{
189189
List<PSExportConfiguration> output = new List<PSExportConfiguration>();
190190
exports.ForEach(e => output.Add(new PSExportConfigurationTableView(e)));
191-
WriteObject(output);
191+
WriteObject(output, true);
192192
}
193193
}
194194

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/GetApplicationInsights.cs

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,28 +18,25 @@
1818

1919
namespace Microsoft.Azure.Commands.ApplicationInsights
2020
{
21-
[Cmdlet(VerbsCommon.Get, ApplicationInsightsNounStr), OutputType(typeof(PSApplicationInsightsComponent))]
21+
[Cmdlet(VerbsCommon.Get, ApplicationInsightsNounStr, DefaultParameterSetName = ResourceGroupParameterSet), OutputType(typeof(PSApplicationInsightsComponent))]
2222
public class GetApplicationInsightsCommand : ApplicationInsightsBaseCmdlet
2323
{
2424
[Parameter(
2525
Position = 0,
2626
Mandatory = false,
2727
ParameterSetName = ResourceGroupParameterSet,
28-
ValueFromPipelineByPropertyName = true,
2928
HelpMessage = "Resource Group Name.")]
3029
[Parameter(
3130
Position = 0,
3231
Mandatory = true,
3332
ParameterSetName = ComponentNameParameterSet,
34-
ValueFromPipelineByPropertyName = true,
3533
HelpMessage = "Resource Group Name.")]
3634
[ValidateNotNullOrEmpty]
3735
public string ResourceGroupName { get; set; }
3836

3937
[Parameter(
4038
Position = 1,
4139
Mandatory = true,
42-
ValueFromPipelineByPropertyName = true,
4340
ParameterSetName = ComponentNameParameterSet,
4441
HelpMessage = "Application Insights Resource Name.")]
4542
[Alias(ApplicationInsightsComponentNameAlias, ComponentNameAlias)]
@@ -57,16 +54,14 @@ public class GetApplicationInsightsCommand : ApplicationInsightsBaseCmdlet
5754

5855
[Parameter(
5956
Mandatory = false,
60-
ValueFromPipelineByPropertyName = true,
6157
ParameterSetName = ComponentNameParameterSet,
6258
HelpMessage = "If specified, it will get back pricing plan of the application insights component.")]
6359
[Parameter(
6460
Mandatory = false,
65-
ValueFromPipelineByPropertyName = true,
6661
ParameterSetName = ResourceIdParameterSet,
6762
HelpMessage = "If specified, it will get back pricing plan of the application insights component.")]
68-
[Alias("IncludeDailyCap", "IncludeDailyCapStatus")]
69-
public SwitchParameter IncludePricingPlan { get; set; }
63+
[Alias("IncludeDailyCap", "IncludeDailyCapStatus", "IncludePricingPlan")]
64+
public SwitchParameter Full { get; set; }
7065

7166
public override void ExecuteCmdlet()
7267
{
@@ -99,7 +94,7 @@ public override void ExecuteCmdlet()
9994
this.Name)
10095
.GetAwaiter()
10196
.GetResult();
102-
if (IncludePricingPlan)
97+
if (this.Full)
10398
{
10499
var pricingPlanResponse = this.AppInsightsManagementClient
105100
.ComponentCurrentBillingFeatures

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/GetApplicationInsightsApiKey.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
namespace Microsoft.Azure.Commands.ApplicationInsights
2020
{
21-
[Cmdlet(VerbsCommon.Get, ApplicationInsightsApiKeyNounStr), OutputType(typeof(PSApiKey))]
21+
[Cmdlet(VerbsCommon.Get, ApplicationInsightsApiKeyNounStr, DefaultParameterSetName = ComponentNameParameterSet), OutputType(typeof(PSApiKey))]
2222
public class GetApplicationInsightsApiKeyCommand : ApplicationInsightsBaseCmdlet
2323
{
2424
[Parameter(
@@ -43,7 +43,6 @@ public class GetApplicationInsightsApiKeyCommand : ApplicationInsightsBaseCmdlet
4343
Position = 0,
4444
Mandatory = true,
4545
ParameterSetName = ComponentNameParameterSet,
46-
ValueFromPipelineByPropertyName = true,
4746
HelpMessage = "Resource Group Name.")]
4847
[ValidateNotNullOrEmpty]
4948
public string ResourceGroupName { get; set; }
@@ -52,7 +51,6 @@ public class GetApplicationInsightsApiKeyCommand : ApplicationInsightsBaseCmdlet
5251
Position = 1,
5352
Mandatory = true,
5453
ParameterSetName = ComponentNameParameterSet,
55-
ValueFromPipelineByPropertyName = true,
5654
HelpMessage = "Application Insights Component Name.")]
5755
[Alias(ApplicationInsightsComponentNameAlias, ComponentNameAlias)]
5856
[ValidateNotNullOrEmpty]
@@ -61,7 +59,6 @@ public class GetApplicationInsightsApiKeyCommand : ApplicationInsightsBaseCmdlet
6159
[Parameter(
6260
Position = 2,
6361
Mandatory = false,
64-
ValueFromPipelineByPropertyName = true,
6562
HelpMessage = "Application Insights Api Key Id.")]
6663
[ValidateNotNullOrEmpty]
6764
public string ApiKeyId { get; set; }

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/GetApplicationInsightsContinuousExport.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
namespace Microsoft.Azure.Commands.ApplicationInsights
2020
{
21-
[Cmdlet(VerbsCommon.Get, ApplicationInsightsContinuousExportNounStr), OutputType(typeof(PSExportConfiguration))]
21+
[Cmdlet(VerbsCommon.Get, ApplicationInsightsContinuousExportNounStr, DefaultParameterSetName = ComponentNameParameterSet), OutputType(typeof(PSExportConfiguration))]
2222
public class GetApplicationInsightsContinuousExportCommand : ApplicationInsightsBaseCmdlet
2323
{
2424
[Parameter(
@@ -43,7 +43,6 @@ public class GetApplicationInsightsContinuousExportCommand : ApplicationInsights
4343
Position = 0,
4444
Mandatory = true,
4545
ParameterSetName = ComponentNameParameterSet,
46-
ValueFromPipelineByPropertyName = true,
4746
HelpMessage = "Resource Group Name.")]
4847
[ValidateNotNullOrEmpty]
4948
public string ResourceGroupName { get; set; }
@@ -52,7 +51,6 @@ public class GetApplicationInsightsContinuousExportCommand : ApplicationInsights
5251
Position = 1,
5352
Mandatory = true,
5453
ParameterSetName = ComponentNameParameterSet,
55-
ValueFromPipelineByPropertyName = true,
5654
HelpMessage = "Application Insights Component Name.")]
5755
[Alias(ApplicationInsightsComponentNameAlias, ComponentNameAlias)]
5856
[ValidateNotNullOrEmpty]
@@ -61,7 +59,6 @@ public class GetApplicationInsightsContinuousExportCommand : ApplicationInsights
6159
[Parameter(
6260
Position = 2,
6361
Mandatory = false,
64-
ValueFromPipelineByPropertyName = true,
6562
HelpMessage = "Application Insights Continuous Export Id.")]
6663
[ValidateNotNullOrEmpty]
6764
public string ExportId { get; set; }

‎src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/NewApplicationInsights.cs

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,19 @@
2121

2222
namespace Microsoft.Azure.Commands.ApplicationInsights
2323
{
24-
[Cmdlet(VerbsCommon.New, ApplicationInsightsNounStr), OutputType(typeof(PSApplicationInsightsComponent))]
24+
[Cmdlet(VerbsCommon.New, ApplicationInsightsNounStr, SupportsShouldProcess = true), OutputType(typeof(PSApplicationInsightsComponent))]
2525
public class NewAzureApplicationInsights : ApplicationInsightsBaseCmdlet
2626
{
2727
[Parameter(
2828
Position = 0,
2929
Mandatory = true,
30-
ValueFromPipelineByPropertyName = true,
3130
HelpMessage = "Resource Group Name.")]
3231
[ValidateNotNullOrEmpty]
3332
public string ResourceGroupName { get; set; }
3433

3534
[Parameter(
3635
Position = 1,
3736
Mandatory = true,
38-
ValueFromPipelineByPropertyName = true,
3937
HelpMessage = "Application Insights Resource Name.")]
4038
[Alias(ApplicationInsightsComponentNameAlias, ComponentNameAlias)]
4139
[ValidateNotNullOrEmpty]
@@ -44,22 +42,20 @@ public class NewAzureApplicationInsights : ApplicationInsightsBaseCmdlet
4442
[Parameter(
4543
Position = 2,
4644
Mandatory = true,
47-
ValueFromPipelineByPropertyName = true,
4845
HelpMessage = "Application Insights Resource Location.")]
4946
[ValidateNotNullOrEmpty]
5047
public string Location { get; set; }
5148

5249
[Parameter(
5350
Mandatory = false,
54-
ValueFromPipelineByPropertyName = true,
5551
HelpMessage = "Application kind.")]
5652
[Alias(ApplicationKindAlias)]
5753
[ValidateSet(ApplicationType.WEB,
5854
ApplicationType.General,
5955
ApplicationType.NodeJs,
6056
ApplicationType.JAVA,
6157
IgnoreCase = true)]
62-
[PSDefaultValue(Value =ApplicationType.WEB)]
58+
[PSDefaultValue(Value = ApplicationType.WEB)]
6359
public string Kind
6460
{
6561
get
@@ -113,15 +109,18 @@ public override void ExecuteCmdlet()
113109
RequestSource = "AzurePowerShell",
114110
};
115111

116-
var newComponentResponse = this.AppInsightsManagementClient
117-
.Components
118-
.CreateOrUpdateWithHttpMessagesAsync(
119-
ResourceGroupName,
120-
Name,
121-
newComponentProperties)
122-
.Result;
112+
if (this.ShouldProcess(this.ResourceGroupName, $"Create Application Insights Component {this.Name}"))
113+
{
114+
var newComponentResponse = this.AppInsightsManagementClient
115+
.Components
116+
.CreateOrUpdateWithHttpMessagesAsync(
117+
ResourceGroupName,
118+
Name,
119+
newComponentProperties)
120+
.Result;
123121

124-
this.WriteComponent(newComponentResponse.Body);
122+
this.WriteComponent(newComponentResponse.Body);
123+
}
125124
}
126125
}
127126
}

0 commit comments

Comments
 (0)