Skip to content

Commit fa4a058

Browse files
NilambariNilambari
committed
Incorporate code review comments
1 parent 70e002a commit fa4a058

15 files changed

+149
-141
lines changed

‎src/ResourceManager/Dns/Commands.Dns.Test/ScenarioTests/ZoneTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,31 +31,31 @@ public void TestZoneCrud()
3131
DnsTestsBase.NewInstance.RunPowerShellTest("Test-ZoneCrud");
3232
}
3333

34-
[Fact(Skip = "Test is failing, service team needs to re-record")]
34+
[Fact]
3535
public void TestPrivateZoneCrud()
3636
{
3737
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrud");
3838
}
3939

40-
[Fact(Skip = "Test is failing, service team needs to re-record")]
40+
[Fact]
4141
public void TestPrivateZoneCrudRegistrationVirtualNetwork()
4242
{
4343
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudRegistrationVnet");
4444
}
4545

46-
[Fact(Skip = "Test is failing, service team needs to re-record")]
46+
[Fact]
4747
public void TestPrivateZoneCrudResolutionVirtualNetwork()
4848
{
4949
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudResolutionVnet");
5050
}
5151

52-
[Fact(Skip = "Test is failing, service team needs to re-record")]
52+
[Fact]
5353
public void TestPrivateZoneCrudByVirtualNetworkIds()
5454
{
5555
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudByVirtualNetworkIds");
5656
}
5757

58-
[Fact(Skip = "Test is failing, service team needs to re-record")]
58+
[Fact]
5959
public void TestPrivateZoneCrudByVirtualNetworkObjects()
6060
{
6161
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudByVirtualNetworkObjects");

‎src/ResourceManager/Network/ChangeLog.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@
2121
## Current Release
2222

2323
* Bump up Network SDK version from 18.0.0-preview to 19.0.0-preview
24+
* Updated below commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.
25+
- Updated New-AzureRmVirtualNetworkGateway: Added optional parameter -VpnClientIpsecPolicy [Pass the value from output of newly added command:- New-AzureRmVpnClientIpsecPolicy]
26+
- Updated Set-AzureRmVirtualNetworkGateway: Added optional parameter -VpnClientIPsecParameter [Pass the value from output of newly added command:- New-AzureRmVpnClientIpsecPolicy]
27+
* Added new commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.
28+
- New-AzureRmVpnClientIpsecPolicy : Added for passing output from this command to existing commands: New-AzureRmVirtualNetworkGateway & Set-AzureRmVirtualNetworkGateway to set Vpn IPSec policy
29+
- New-AzureRmVpnClientIpsecParameter
30+
- Set-AzureRmVpnClientIpsecParameter
31+
- Get-AzureRmVpnClientIpsecParameter
32+
- Remove-AzureRmVpnClientIpsecParameter
33+
* Added a warning note for existing command: Set-AzureRmVirtualNetworkGatewayVpnClientConfig to let users know of its plan of removal in next release.
2434

2535
## Version 6.0.0
2636
* Added cmdlet to add a new circuit connection to an existing express route circuit.
@@ -34,16 +44,6 @@
3444
* Add support for DDoS protection plan resource
3545
* Introduced multiple breaking changes
3646
- Please refer to the migration guide for more information
37-
* Updated below commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.
38-
- Updated New-AzureRmVirtualNetworkGateway: Added optional parameter -VpnClientIpsecPolicy [Pass the value from output of newly added command:- New-AzureRmVpnClientIpsecPolicy]
39-
- Updated Set-AzureRmVirtualNetworkGateway: Added optional parameter -VpnClientIPsecParameter [Pass the value from output of newly added command:- New-AzureRmVpnClientIpsecPolicy]
40-
* Added new commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.
41-
- New-AzureRmVpnClientIpsecPolicy : Added for passing output from this command to existing commands: New-AzureRmVirtualNetworkGateway & Set-AzureRmVirtualNetworkGateway to set Vpn IPSec policy
42-
- New-AzureRmVpnClientIpsecParameter
43-
- Set-AzureRmVpnClientIpsecParameter
44-
- Get-AzureRmVpnClientIpsecParameter
45-
- Remove-AzureRmVpnClientIpsecParameter
46-
* Added a warning note for existing command: Set-AzureRmVirtualNetworkGatewayVpnClientConfig to let users know of its plan of removal in next release.
4747

4848
## Version 5.4.2
4949
* Fix error message with Network cmdlets

‎src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/VirtualNetworkGatewayTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ param
721721
Assert-AreEqual $expected.VpnClientConfiguration.VpnClientIpsecPolicies[0].PfsGroup $vpnIpsecParams.PfsGroup
722722

723723
# Remove custom Ipsec policy set from P2S VPNClient Configuration using new API:- Remove-AzureRmVpnClientIpsecParameter
724-
$delete = Remove-AzureRmVpnClientIpsecParameter -ResourceGroupName $rgname -VirtualNetworkGatewayName $rname -Force
724+
$delete = Remove-AzureRmVpnClientIpsecParameter -ResourceGroupName $rgname -VirtualNetworkGatewayName $rname
725725
Assert-AreEqual $True $delete
726726
$expected = Get-AzureRmVirtualNetworkGateway -ResourceGroupName $rgname -name $rname
727727
Assert-AreEqual 0 @($expected.VpnClientConfiguration.VpnClientIpsecPolicies).Count

‎src/ResourceManager/Network/Commands.Network/Properties/Resources.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/ResourceManager/Network/Commands.Network/Properties/Resources.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@
134134
<data name="VirtualNetworkGatewayIpConfigName" xml:space="preserve">
135135
<value>virtualNetworkGatewayIpConfiguration</value>
136136
</data>
137-
<data name="VirtualNetworkGatewayVpnClientIpsecPolicy" xml:space="preserve">
138-
<value>VirtualNetworkGatewayVpnClientIpsecPolicy</value>
137+
<data name="VirtualNetworkGatewayName" xml:space="preserve">
138+
<value>virtualNetworkGatewayName</value>
139139
</data>
140140
<data name="LoadBalancerInBoundNatRuleName" xml:space="preserve">
141141
<value>inboundNatRules</value>

‎src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/GetAzureVpnClientIpsecParametersCommand.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,9 @@ public override void Execute()
4141
{
4242
base.Execute();
4343

44-
if (ShouldProcess("AzureRmVpnClientIpsecParameter", VerbsCommon.Get))
45-
{
46-
var vpnClientIpsecParameters = this.GetVpnClientIpsecParameters(this.ResourceGroupName, this.Name);
44+
var vpnClientIpsecParameters = this.GetVpnClientIpsecParameters(this.ResourceGroupName, this.Name);
4745

48-
WriteObject(vpnClientIpsecParameters);
49-
}
46+
WriteObject(vpnClientIpsecParameters);
5047
}
5148
}
5249
}

‎src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/NewAzureRmVpnClientIpsecParametersCommand.cs

Lines changed: 24 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
namespace Microsoft.Azure.Commands.Network
2121
{
22-
[Cmdlet(VerbsCommon.New, "AzureRmVpnClientIpsecParameter", SupportsShouldProcess = true), OutputType(typeof(PSVpnClientIPsecParameters))]
22+
[Cmdlet(VerbsCommon.New, "AzureRmVpnClientIpsecParameter"), OutputType(typeof(PSVpnClientIPsecParameters))]
2323
public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
2424
{
2525
[Parameter(
@@ -42,8 +42,7 @@ public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
4242
MNM.IpsecEncryption.GCMAES256,
4343
MNM.IpsecEncryption.GCMAES128,
4444
MNM.IpsecEncryption.AES256,
45-
MNM.IpsecEncryption.AES128,
46-
IgnoreCase = false)]
45+
MNM.IpsecEncryption.AES128)]
4746
public string IpsecEncryption { get; set; }
4847

4948
[Parameter(
@@ -53,8 +52,7 @@ public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
5352
[ValidateSet(
5453
MNM.IpsecIntegrity.GCMAES256,
5554
MNM.IpsecIntegrity.GCMAES128,
56-
MNM.IpsecIntegrity.SHA256,
57-
IgnoreCase = false)]
55+
MNM.IpsecIntegrity.SHA256)]
5856
public string IpsecIntegrity { get; set; }
5957

6058
[Parameter(
@@ -65,8 +63,7 @@ public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
6563
MNM.IkeEncryption.GCMAES256,
6664
MNM.IkeEncryption.GCMAES128,
6765
MNM.IkeEncryption.AES256,
68-
MNM.IkeEncryption.AES128,
69-
IgnoreCase = false)]
66+
MNM.IkeEncryption.AES128)]
7067
public string IkeEncryption { get; set; }
7168

7269
[Parameter(
@@ -75,8 +72,7 @@ public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
7572
[ValidateNotNullOrEmpty]
7673
[ValidateSet(
7774
MNM.IkeIntegrity.SHA384,
78-
MNM.IkeIntegrity.SHA256,
79-
IgnoreCase = false)]
75+
MNM.IkeIntegrity.SHA256)]
8076
public string IkeIntegrity { get; set; }
8177

8278
[Parameter(
@@ -88,8 +84,7 @@ public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
8884
MNM.DhGroup.ECP384,
8985
MNM.DhGroup.ECP256,
9086
MNM.DhGroup.DHGroup14,
91-
MNM.DhGroup.DHGroup2,
92-
IgnoreCase = false)]
87+
MNM.DhGroup.DHGroup2)]
9388
public string DhGroup { get; set; }
9489

9590
[Parameter(
@@ -103,39 +98,35 @@ public class NewAzureRmVpnClientIpsecParametersCommand : NetworkBaseCmdlet
10398
MNM.PfsGroup.ECP256,
10499
MNM.PfsGroup.PFS14,
105100
MNM.PfsGroup.PFS2,
106-
MNM.PfsGroup.None,
107-
IgnoreCase = false)]
101+
MNM.PfsGroup.None)]
108102
public string PfsGroup { get; set; }
109103

110104
public override void Execute()
111105
{
112106
base.Execute();
113107

114-
if (ShouldProcess(Properties.Resources.CreatingResourceMessage + Properties.Resources.VirtualNetworkGatewayVpnClientIpsecPolicy))
115-
{
116-
var vpnclientIPsecParameters = new PSVpnClientIPsecParameters();
108+
var vpnclientIPsecParameters = new PSVpnClientIPsecParameters();
117109

118-
// default SA values
119-
vpnclientIPsecParameters.SaLifeTimeSeconds = (!this.MyInvocation.BoundParameters.ContainsKey("SaLifeTime")) ? 7200 : this.SALifeTime;
120-
vpnclientIPsecParameters.SaDataSizeKilobytes = (!this.MyInvocation.BoundParameters.ContainsKey("SaDataSize")) ? 104857600 : this.SADataSize;
110+
// default SA values
111+
vpnclientIPsecParameters.SaLifeTimeSeconds = (!this.MyInvocation.BoundParameters.ContainsKey("SaLifeTime")) ? 7200 : this.SALifeTime;
112+
vpnclientIPsecParameters.SaDataSizeKilobytes = (!this.MyInvocation.BoundParameters.ContainsKey("SaDataSize")) ? 104857600 : this.SADataSize;
121113

122-
vpnclientIPsecParameters.IpsecEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecEncryption")) ? MNM.IpsecEncryption.GCMAES256 : this.IpsecEncryption;
123-
vpnclientIPsecParameters.IpsecIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecIntegrity")) ? MNM.IpsecIntegrity.GCMAES256 : this.IpsecIntegrity;
114+
vpnclientIPsecParameters.IpsecEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecEncryption")) ? MNM.IpsecEncryption.GCMAES256 : this.IpsecEncryption;
115+
vpnclientIPsecParameters.IpsecIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecIntegrity")) ? MNM.IpsecIntegrity.GCMAES256 : this.IpsecIntegrity;
124116

125-
// GCM matching check
126-
if ((vpnclientIPsecParameters.IpsecEncryption.Contains("GCM") || vpnclientIPsecParameters.IpsecIntegrity.Contains("GCM"))
127-
&& vpnclientIPsecParameters.IpsecEncryption != vpnclientIPsecParameters.IpsecIntegrity)
128-
{
129-
throw new ArgumentException("Vpnclient IpsecEncryption and IpsecIntegrity must use matching GCM algorithms");
130-
}
117+
// GCM matching check
118+
if ((vpnclientIPsecParameters.IpsecEncryption.Contains("GCM") || vpnclientIPsecParameters.IpsecIntegrity.Contains("GCM"))
119+
&& vpnclientIPsecParameters.IpsecEncryption != vpnclientIPsecParameters.IpsecIntegrity)
120+
{
121+
throw new ArgumentException("Vpnclient IpsecEncryption and IpsecIntegrity must use matching GCM algorithms");
122+
}
131123

132-
vpnclientIPsecParameters.IkeEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IkeEncryption")) ? MNM.IkeEncryption.AES256 : this.IkeEncryption;
133-
vpnclientIPsecParameters.IkeIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IkeIntegrity")) ? MNM.IkeIntegrity.SHA256 : this.IkeIntegrity;
134-
vpnclientIPsecParameters.DhGroup = (!this.MyInvocation.BoundParameters.ContainsKey("DhGroup")) ? MNM.DhGroup.DHGroup24 : this.DhGroup;
135-
vpnclientIPsecParameters.PfsGroup = (!this.MyInvocation.BoundParameters.ContainsKey("PfsGroup")) ? MNM.PfsGroup.PFS24 : this.PfsGroup;
124+
vpnclientIPsecParameters.IkeEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IkeEncryption")) ? MNM.IkeEncryption.AES256 : this.IkeEncryption;
125+
vpnclientIPsecParameters.IkeIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IkeIntegrity")) ? MNM.IkeIntegrity.SHA256 : this.IkeIntegrity;
126+
vpnclientIPsecParameters.DhGroup = (!this.MyInvocation.BoundParameters.ContainsKey("DhGroup")) ? MNM.DhGroup.DHGroup24 : this.DhGroup;
127+
vpnclientIPsecParameters.PfsGroup = (!this.MyInvocation.BoundParameters.ContainsKey("PfsGroup")) ? MNM.PfsGroup.PFS24 : this.PfsGroup;
136128

137-
WriteObject(vpnclientIPsecParameters);
138-
}
129+
WriteObject(vpnclientIPsecParameters);
139130
}
140131
}
141132
}

‎src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/NewAzureRmVpnClientIpsecPolicyCommand.cs

Lines changed: 24 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
namespace Microsoft.Azure.Commands.Network
2121
{
22-
[Cmdlet(VerbsCommon.New, "AzureRmVpnClientIpsecPolicy", SupportsShouldProcess = true), OutputType(typeof(PSIpsecPolicy))]
22+
[Cmdlet(VerbsCommon.New, "AzureRmVpnClientIpsecPolicy"), OutputType(typeof(PSIpsecPolicy))]
2323
public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
2424
{
2525
[Parameter(
@@ -42,8 +42,7 @@ public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
4242
MNM.IpsecEncryption.GCMAES256,
4343
MNM.IpsecEncryption.GCMAES128,
4444
MNM.IpsecEncryption.AES256,
45-
MNM.IpsecEncryption.AES128,
46-
IgnoreCase = false)]
45+
MNM.IpsecEncryption.AES128)]
4746
public string IpsecEncryption { get; set; }
4847

4948
[Parameter(
@@ -53,8 +52,7 @@ public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
5352
[ValidateSet(
5453
MNM.IpsecIntegrity.GCMAES256,
5554
MNM.IpsecIntegrity.GCMAES128,
56-
MNM.IpsecIntegrity.SHA256,
57-
IgnoreCase = false)]
55+
MNM.IpsecIntegrity.SHA256)]
5856
public string IpsecIntegrity { get; set; }
5957

6058
[Parameter(
@@ -65,8 +63,7 @@ public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
6563
MNM.IkeEncryption.GCMAES256,
6664
MNM.IkeEncryption.GCMAES128,
6765
MNM.IkeEncryption.AES256,
68-
MNM.IkeEncryption.AES128,
69-
IgnoreCase = false)]
66+
MNM.IkeEncryption.AES128)]
7067
public string IkeEncryption { get; set; }
7168

7269
[Parameter(
@@ -75,8 +72,7 @@ public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
7572
[ValidateNotNullOrEmpty]
7673
[ValidateSet(
7774
MNM.IkeIntegrity.SHA384,
78-
MNM.IkeIntegrity.SHA256,
79-
IgnoreCase = false)]
75+
MNM.IkeIntegrity.SHA256)]
8076
public string IkeIntegrity { get; set; }
8177

8278
[Parameter(
@@ -88,8 +84,7 @@ public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
8884
MNM.DhGroup.ECP384,
8985
MNM.DhGroup.ECP256,
9086
MNM.DhGroup.DHGroup14,
91-
MNM.DhGroup.DHGroup2,
92-
IgnoreCase = false)]
87+
MNM.DhGroup.DHGroup2)]
9388
public string DhGroup { get; set; }
9489

9590
[Parameter(
@@ -103,39 +98,35 @@ public class NewAzureRmVpnClientIpsecPolicyCommand : NetworkBaseCmdlet
10398
MNM.PfsGroup.ECP256,
10499
MNM.PfsGroup.PFS14,
105100
MNM.PfsGroup.PFS2,
106-
MNM.PfsGroup.None,
107-
IgnoreCase = false)]
101+
MNM.PfsGroup.None)]
108102
public string PfsGroup { get; set; }
109103

110104
public override void Execute()
111105
{
112106
base.Execute();
113107

114-
if (ShouldProcess(Properties.Resources.CreatingResourceMessage + Properties.Resources.VirtualNetworkGatewayVpnClientIpsecPolicy))
115-
{
116-
var vpnclientIpsecPolicy = new PSIpsecPolicy();
108+
var vpnclientIpsecPolicy = new PSIpsecPolicy();
117109

118-
// default SA values
119-
vpnclientIpsecPolicy.SALifeTimeSeconds = (!this.MyInvocation.BoundParameters.ContainsKey("SALifeTime")) ? 7200 : this.SALifeTime;
120-
vpnclientIpsecPolicy.SADataSizeKilobytes = (!this.MyInvocation.BoundParameters.ContainsKey("SADataSize")) ? 104857600 : this.SADataSize;
110+
// default SA values
111+
vpnclientIpsecPolicy.SALifeTimeSeconds = (!this.MyInvocation.BoundParameters.ContainsKey("SALifeTime")) ? 7200 : this.SALifeTime;
112+
vpnclientIpsecPolicy.SADataSizeKilobytes = (!this.MyInvocation.BoundParameters.ContainsKey("SADataSize")) ? 104857600 : this.SADataSize;
121113

122-
vpnclientIpsecPolicy.IpsecEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecEncryption")) ? MNM.IpsecEncryption.GCMAES256 : this.IpsecEncryption;
123-
vpnclientIpsecPolicy.IpsecIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecIntegrity")) ? MNM.IpsecIntegrity.GCMAES256 : this.IpsecIntegrity;
114+
vpnclientIpsecPolicy.IpsecEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecEncryption")) ? MNM.IpsecEncryption.GCMAES256 : this.IpsecEncryption;
115+
vpnclientIpsecPolicy.IpsecIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IpsecIntegrity")) ? MNM.IpsecIntegrity.GCMAES256 : this.IpsecIntegrity;
124116

125-
// GCM matching check
126-
if ((vpnclientIpsecPolicy.IpsecEncryption.Contains("GCM") || vpnclientIpsecPolicy.IpsecIntegrity.Contains("GCM"))
127-
&& vpnclientIpsecPolicy.IpsecEncryption != vpnclientIpsecPolicy.IpsecIntegrity)
128-
{
129-
throw new ArgumentException("Vpnclient IpsecEncryption and IpsecIntegrity must use matching GCM algorithms");
130-
}
117+
// GCM matching check
118+
if ((vpnclientIpsecPolicy.IpsecEncryption.Contains("GCM") || vpnclientIpsecPolicy.IpsecIntegrity.Contains("GCM"))
119+
&& vpnclientIpsecPolicy.IpsecEncryption != vpnclientIpsecPolicy.IpsecIntegrity)
120+
{
121+
throw new ArgumentException("Vpnclient IpsecEncryption and IpsecIntegrity must use matching GCM algorithms");
122+
}
131123

132-
vpnclientIpsecPolicy.IkeEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IkeEncryption")) ? MNM.IkeEncryption.AES256 : this.IkeEncryption;
133-
vpnclientIpsecPolicy.IkeIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IkeIntegrity")) ? MNM.IkeIntegrity.SHA256 : this.IkeIntegrity;
134-
vpnclientIpsecPolicy.DhGroup = (!this.MyInvocation.BoundParameters.ContainsKey("DhGroup")) ? MNM.DhGroup.DHGroup24 : this.DhGroup;
135-
vpnclientIpsecPolicy.PfsGroup = (!this.MyInvocation.BoundParameters.ContainsKey("PfsGroup")) ? MNM.PfsGroup.PFS24 : this.PfsGroup;
124+
vpnclientIpsecPolicy.IkeEncryption = (!this.MyInvocation.BoundParameters.ContainsKey("IkeEncryption")) ? MNM.IkeEncryption.AES256 : this.IkeEncryption;
125+
vpnclientIpsecPolicy.IkeIntegrity = (!this.MyInvocation.BoundParameters.ContainsKey("IkeIntegrity")) ? MNM.IkeIntegrity.SHA256 : this.IkeIntegrity;
126+
vpnclientIpsecPolicy.DhGroup = (!this.MyInvocation.BoundParameters.ContainsKey("DhGroup")) ? MNM.DhGroup.DHGroup24 : this.DhGroup;
127+
vpnclientIpsecPolicy.PfsGroup = (!this.MyInvocation.BoundParameters.ContainsKey("PfsGroup")) ? MNM.PfsGroup.PFS24 : this.PfsGroup;
136128

137-
WriteObject(vpnclientIpsecPolicy);
138-
}
129+
WriteObject(vpnclientIpsecPolicy);
139130
}
140131
}
141132
}

0 commit comments

Comments
 (0)