Skip to content

Commit faddde8

Browse files
Get-AzureVMSqlServerExtension was not reporting back "AutoBackup" and "AutoPatching" configurations.
SQL VSTS# 4295279 - Extension status cmdlet does not show Backup/Patching settings Issue: - Extension name was not fully qualified when we were enumerating Extension Statuses Fix: - construct fully qualified Extension handler name like Microsoft.SqlServer.Management.SqlIaaSAgent - This approach is similar to DSC extension's get cmdlet
1 parent bc81a61 commit faddde8

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/GetAzureVMSqlServerExtension.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ protected override void ProcessRecord()
6868
/// <returns></returns>
6969
private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExtensionReference r)
7070
{
71+
string extensionName= VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedNamespace + "."
72+
+ VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedName;
73+
7174
VirtualMachineSqlServerExtensionContext context = new VirtualMachineSqlServerExtensionContext
7275
{
7376
ExtensionName = r.Name,
@@ -90,7 +93,7 @@ private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExte
9093
foreach (NSM.ResourceExtensionStatus res in extensionStatusList)
9194
{
9295
// Expected ReferenceName = "Microsoft.SqlServer.Management.SqlIaaSAgent"
93-
if (!res.HandlerName.Equals(r.ReferenceName, System.StringComparison.InvariantCulture))
96+
if (!res.HandlerName.Equals(extensionName, System.StringComparison.InvariantCulture))
9497
{
9598
// skip all non-sql extensions
9699
continue;

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/SetAzureVMSqlServerExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ internal void ExecuteCommand()
109109
protected override void ValidateParameters()
110110
{
111111
base.ValidateParameters();
112-
this.ReferenceName = string.IsNullOrEmpty(this.ReferenceName) ? ExtensionDefaultName : this.ReferenceName;
112+
this.ReferenceName = string.IsNullOrEmpty(this.ReferenceName) ? ExtensionPublishedName : this.ReferenceName;
113113
this.SetupAutoTelemetrySettings();
114114
this.PublicConfiguration = GetPublicConfiguration();
115115
this.PrivateConfiguration = GetPrivateConfiguration();

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/VirtualMachineSqlServerExtensionCmdletBase.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ public class VirtualMachineSqlServerExtensionCmdletBase : VirtualMachineExtensio
2828
/// <summary>
2929
/// Extension's publisher name
3030
/// </summary>
31-
protected const string ExtensionDefaultPublisher = "Microsoft.SqlServer.Management";
31+
protected const string ExtensionPublishedNamespace = "Microsoft.SqlServer.Management";
3232

3333
/// <summary>
3434
/// Extension's name -
3535
/// </summary>
36-
protected const string ExtensionDefaultName = "SqlIaaSAgent";
36+
protected const string ExtensionPublishedName = "SqlIaaSAgent";
3737

3838
/// <summary>
3939
/// Extension's default version
@@ -60,8 +60,8 @@ public class VirtualMachineSqlServerExtensionCmdletBase : VirtualMachineExtensio
6060
/// </summary>
6161
public VirtualMachineSqlServerExtensionCmdletBase()
6262
{
63-
base.publisherName = ExtensionDefaultPublisher;
64-
base.extensionName = ExtensionDefaultName;
63+
base.publisherName = ExtensionPublishedNamespace;
64+
base.extensionName = ExtensionPublishedName;
6565
}
6666

6767
/// <summary>

0 commit comments

Comments
 (0)